From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: admin@tsv-stahl-riesa.de
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Kevin Tsai" <ktsai@capellamicro.com>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: light: Add Capella CM3217 ambient light sensor driver
Date: Mon, 16 Nov 2026 11:43:09 +0200 [thread overview]
Message-ID: <avrQLQyTPODd4gcZ@ashevche-desk.local> (raw)
In-Reply-To: <20261113-upstream-iio-cm3217-v3-2-c4d5b2485dff@tsv-stahl-riesa.de>
On Fri, Nov 13, 2026 at 08:59:00PM +0100, Patrick Fischer via B4 Relay wrote:
> The CM3217 has no registers and no ID. Writing a byte to address 0x10
> or 0x11 sets command byte 1 or 2, reading a byte from 0x10 or 0x11
> returns the high or low byte of the 16-bit light count. The driver
> takes the second address from the second reg entry and falls back to
> 0x11 when there is no firmware node, as with new_device.
>
> Command byte 1 holds the shutdown bit and the IT_T field (1/2 T, 1 T,
> 2 T or 4 T), command byte 2 the FD_IT field (800 ms down to 66 ms). The
> count scales linearly with both. The driver exposes FD_IT as the
> integration time and IT_T through the scale, so the scale list offers
> four ranges for each integration time.
>
> The datasheet is not public. The bit fields, the reserved bits that are
> written as 1 and the startup setting of 2 T and 100 ms come from NVIDIA's
> downstream drivers (drivers/staging/iio/light/cm3217.c in the 3.4 kernel
> rel-tegranote-r8 and the 3.10 kernel
> android-tegra-flounder-3.10-nougat-mr1.1). One value differs: the vendor
> header defines 4 T as 4 << 2, which is outside the two-bit field. On a
> Tegra Note 7 field value 3 gave four times the 1 T count, so the driver
> uses that. For the resolution, Capella
> gives a range of 0.01875 to 119156 lux. The driver takes 0.01875 lux
> per count at 4 T and 800 ms. This matches both the upper end (65535
> counts at 1/2 T and 66 ms) and the 0.3 lux per count that the NVIDIA
> 3.4 driver uses at 2 T and 100 ms.
>
> The sensor has no data-ready flag, and a new setting only takes effect
> when the conversion in progress ends. A conversion takes IT_T times
> FD_IT, up to 3.2 s. Leaving shutdown starts a new one at once, so the
> driver passes through shutdown on every change and waits one conversion
> period plus a margin before it reads the count. The timing was measured
> on a Tegra Note 7.
There are a few nit-picks below. But in general looks very good.
...
> +static int cm3217_read_count(struct cm3217_data *data, int *val)
> + __must_hold(&data->lock)
> +{
> + s64 wait_ms;
> + int lsb, msb;
Reversed xmas tree order.
> + wait_ms = ktime_ms_delta(data->ready, ktime_get());
> + if (wait_ms > 0)
> + msleep(wait_ms);
> +
> + lsb = i2c_smbus_read_byte(data->client_lsb);
> + if (lsb < 0)
> + return lsb;
> +
> + msb = i2c_smbus_read_byte(data->client);
> + if (msb < 0)
> + return msb;
> +
> + *val = msb << 8 | lsb;
> +
> + return 0;
> +}
...
> +static int cm3217_find_avail(const int (*avail)[2], unsigned int len,
This parameter is weird as we don't use at_least or so. It might be that
compiler can test it with the static const parameters supplied, but better
not to rely on that.
> + int val, int val2)
> +{
> + for (unsigned int i = 0; i < len; i++) {
> + if (avail[i][0] == val && avail[i][1] == val2)
> + return i;
> + }
> +
> + return -EINVAL;
> +}
With all complexity this gives, I would rather make one helper per each case.
static int cm3217_find_scale_avail(unsigned int fd_it, int val, int val2)
{
for (unsigned int i = 0; i < ARRAY_SIZE(cm3217_scale_avail[idx]); i++) {
if (cm3217_scale_avail[fd_it][i][0] == val &&
cm3217_scale_avail[fd_it][i][1] == val2)
return i;
}
return -EINVAL;
}
> +static int cm3217_write_raw(struct iio_dev *indio_dev,
> + struct iio_chan_spec const *chan,
> + int val, int val2, long mask)
> +{
> + struct cm3217_data *data = iio_priv(indio_dev);
> + unsigned int fd_it;
> + u8 cmd1, cmd2;
> + int i;
> +
> + guard(mutex)(&data->lock);
> +
> + switch (mask) {
> + case IIO_CHAN_INFO_SCALE:
> + fd_it = FIELD_GET(CM3217_CMD2_FD_IT, data->cmd2);
> + i = cm3217_find_avail(cm3217_scale_avail[fd_it],
> + ARRAY_SIZE(cm3217_scale_avail[0]),
> + val, val2);
> + if (i < 0)
> + return i;
fd_it = FIELD_GET(CM3217_CMD2_FD_IT, data->cmd2);
i = cm3217_find_scale_avail(fd_it, val, val2);
if (i < 0)
return i;
> + cmd1 = data->cmd1;
> + FIELD_MODIFY(CM3217_CMD1_IT_T, &cmd1, i);
> +
> + return cm3217_write_cmd(data, cmd1, data->cmd2);
> + case IIO_CHAN_INFO_INT_TIME:
> + i = cm3217_find_avail(cm3217_int_time_avail,
> + ARRAY_SIZE(cm3217_int_time_avail),
> + val, val2);
> + if (i < 0)
> + return i;
In the similar way here. I think it it even grown in LoC, it will be not too
many,
> + cmd2 = FIELD_PREP(CM3217_CMD2_FD_IT, i);
> +
> + return cm3217_write_cmd(data, data->cmd1, cmd2);
> + default:
> + return -EINVAL;
> + }
> +}
...
> + data->client_lsb = devm_i2c_new_dummy_device(dev, client->adapter,
> + addr_lsb);
I would make it one line.
> + if (IS_ERR(data->client_lsb))
> + return dev_err_probe(dev, PTR_ERR(data->client_lsb),
> + "failed to register second address\n");
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-11-16 9:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 19:58 [PATCH v3 0/2] iio: light: Add Capella CM3217 ambient light sensor Patrick Fischer
2026-11-13 19:58 ` Patrick Fischer via B4 Relay
2026-11-13 19:58 ` [PATCH v3 1/2] dt-bindings: iio: light: Add Capella CM3217 Patrick Fischer
2026-11-13 19:58 ` Patrick Fischer via B4 Relay
2026-11-14 1:30 ` Jonathan Cameron
2026-11-16 11:44 ` Krzysztof Kozlowski
2026-11-13 19:59 ` [PATCH v3 2/2] iio: light: Add Capella CM3217 ambient light sensor driver Patrick Fischer
2026-11-13 19:59 ` Patrick Fischer via B4 Relay
2026-11-14 1:29 ` Jonathan Cameron
2026-11-16 9:23 ` Andy Shevchenko
2026-11-17 3:10 ` Jonathan Cameron
2026-11-16 9:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avrQLQyTPODd4gcZ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=admin@tsv-stahl-riesa.de \
--cc=andy@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.