All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: Add quirk to mask ACSViol on XHCI on iMac20,1 And iMac20,2
Date: Mon, 16 Nov 2026 11:46:24 +0100	[thread overview]
Message-ID: <avrfAD_puIZm1yR1@wunner.de> (raw)
In-Reply-To: <20261116010835.1191-1-atharvatiwarilinuxdev@gmail.com>

On Sun, Nov 15, 2026 at 08:08:33PM -0500, Atharva Tiwari wrote:
> On iMac20,1 and iMac20,2 the Thunderbolt xHCI (8086:15ec) triggers an ACS
> Violation on its upstream port whenever it is runtime-resumed from D3hot,
> e.g. on suspend and shutdown:
[...]
> +++ b/arch/x86/pci/fixup.c
[...]
> +static void titan_ridge_xhci_mask_acsv(struct pci_dev *pdev)
> +{
> +	struct pci_dev *up = pci_upstream_bridge(pdev);
> +
> +	if (!dmi_match(DMI_PRODUCT_NAME, "iMac20,1") &&
> +	    !dmi_match(DMI_PRODUCT_NAME, "iMac20,2"))
> +		return;
> +	if (up && up->aer_cap)
> +		pci_clear_and_set_config_dword(up, up->aer_cap + PCI_ERR_UNCOR_MASK,
> +					       0, PCI_ERR_UNC_ACSV);
> +}

See this discussion:

https://lore.kernel.org/r/CAL0aDZ_HOq1Sof90GJoBDzPo7Gmr7P_rSnYJaN75QH4K+iodpw@mail.gmail.com/

It's an LTR message with a zero Requester ID.  This needs to be fixed
more generically, not with a model-specific quirk.

Thanks,

Lukas

      parent reply	other threads:[~2026-11-16 10:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  1:08 [PATCH] PCI: Add quirk to mask ACSViol on XHCI on iMac20,1 And iMac20,2 Atharva Tiwari
2026-11-16  1:24 ` sashiko-bot
2026-11-16 10:46 ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avrfAD_puIZm1yR1@wunner.de \
    --to=lukas@wunner.de \
    --cc=atharvatiwarilinuxdev@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.