All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Peng Fan <peng.fan@linux.dev>
Cc: Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
	Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shivamurthy Shastri <shivamurthy.shastri@linutronix.de>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] irqchip/imx-mu-msi: Fix MSI dispatch through the parent domain
Date: Mon, 16 Nov 2026 11:14:42 -0600	[thread overview]
Message-ID: <avs6Avu4PQrcysPl@SMW015318> (raw)
In-Reply-To: <20261115-imx-mu-msi-v1-1-8beb58854ca4@nxp.com>

On Sun, Nov 15, 2026 at 10:11:25PM +0800, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Since commit 7b2f8aa005bc ("irqchip/imx-mu-msi: Switch to MSI parent")
> the driver creates the MSI parent (nexus) domain in
> imx_mu_msi_domains_init(), but never stores it in msi_data->msi_domain.
> The chained interrupt handler therefore calls generic_handle_domain_irq()
> with a NULL domain, which resolves the hardware interrupt against
> irq_default_domain instead of the MU domain. Depending on the platform
> this dispatches an unrelated interrupt or drops the MSI completely.
>
> Save the nexus domain so that the handler resolves MU channel numbers
> through the domain whose reverse map was populated when the MSI was
> allocated.
>
> Fixes: 7b2f8aa005bc ("irqchip/imx-mu-msi: Switch to MSI parent")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/irqchip/irq-imx-mu-msi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c
> index 6d7baeeb2bc8..c42ea0797624 100644
> --- a/drivers/irqchip/irq-imx-mu-msi.c
> +++ b/drivers/irqchip/irq-imx-mu-msi.c
> @@ -238,6 +238,7 @@ static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *d
>  		return -ENOMEM;
>  	}
>  	parent->dev = parent->pm_dev = dev;
> +	msi_data->msi_domain = parent;
>  	return 0;
>  }
>
>
> --
> 2.56.0
>
>

  reply	other threads:[~2026-11-16 17:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 14:11 [PATCH 0/2] irqchip/imx-mu-msi: Fix MSI dispatch and probe error handling Peng Fan
2026-11-15 14:11 ` [PATCH 1/2] irqchip/imx-mu-msi: Fix MSI dispatch through the parent domain Peng Fan
2026-11-16 17:14   ` Frank Li [this message]
2026-11-15 14:11 ` [PATCH 2/2] irqchip/imx-mu-msi: Fix PM domain teardown on probe errors Peng Fan
2026-11-16 17:17   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avs6Avu4PQrcysPl@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=anna-maria@linutronix.de \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=peng.fan@linux.dev \
    --cc=peng.fan@nxp.com \
    --cc=radu@rendec.net \
    --cc=s.hauer@pengutronix.de \
    --cc=shivamurthy.shastri@linutronix.de \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.