From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: SJ Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>,
Qi Zheng <qi.zheng@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH 3/3] mm/vmscan: consolidate promo vs. high watermark checks
Date: Mon, 16 Nov 2026 09:22:39 -0800 [thread overview]
Message-ID: <avs7i4CqGlEpA4wp@devbig011.atn3.facebook.com> (raw)
In-Reply-To: <20261114014917.86531-1-sj@kernel.org>
On Fri, Nov 13, 2026 at 05:49:17PM -0800, SJ Park wrote:
> On Fri, 13 Nov 2026 15:52:36 -0800 Joshua Hahn <joshua.hahnjy@gmail.com> wrote:
>
> > There are three sites which all check the watermark that kswapd reclaims
> > zones up to, which is the promo watermark when NUMA balancing memory
> > tiering is enabled, and the high watermark otherwise.
> >
> > Consolidate the patern into a helper function. While at it, remove the
>
> Nit of nit. s/patern/pattern/ ?
Thanks for your review on the series, SJ! And yes, thank you for the
catch, totally missed that : -)
Andrew / David -- could you help me to fix this in the commit message?
I'd be happy to send a new version as well, whichever you prefer!
Thanks! Have a great day SJ,
Joshua
> > include for <linux/sched/sysctl.h> in mm/page_alloc.c now that the
> > dependency on sysctl_numa_balancing_mode has been abstracted into
> > vmscan code.
> >
> > No functional changes intended.
>
> Looks good to me.
>
> >
> > Signed-off-by: Joshua Hahn <joshua.hahnjy@gmail.com>
>
> Reviewed-by: SJ Park <sj@kernel.org>
>
>
> Thanks,
> SJ
>
> [...]
next prev parent reply other threads:[~2026-11-16 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 23:52 [PATCH 0/3] mm/page_alloc, vmscan: get_page_from_freelist cleanups Joshua Hahn
2026-11-13 23:52 ` [PATCH 1/3] mm/page_alloc: drop unused gfp_mask from zone_watermark_fast() Joshua Hahn
2026-11-14 1:17 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 21:59 ` Zi Yan
2026-11-16 23:36 ` Gregory Price (Meta)
2026-11-13 23:52 ` [PATCH 2/3] mm/page_alloc: move the kswapd node skip check into a helper Joshua Hahn
2026-11-14 1:45 ` SJ Park
2026-11-16 21:31 ` Chris Down
2026-11-16 22:59 ` Joshua Hahn
2026-11-16 22:08 ` Zi Yan
2026-11-16 23:36 ` Gregory Price (Meta)
2026-11-13 23:52 ` [PATCH 3/3] mm/vmscan: consolidate promo vs. high watermark checks Joshua Hahn
2026-11-14 1:49 ` SJ Park
2026-11-16 17:22 ` Joshua Hahn [this message]
2026-11-16 21:31 ` Chris Down
2026-11-16 22:10 ` Zi Yan
2026-11-16 23:37 ` Gregory Price (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avs7i4CqGlEpA4wp@devbig011.atn3.facebook.com \
--to=joshua.hahnjy@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.jackman@linux.dev \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.