All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petre Rodan <petre.rodan@linux.dev>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, David Lechner <dlechner@baylibre.com>,
	Nuno S?? <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
	linux-kernel@vger.kernel.org,
	Martin Tuma <martin.tuma@digiteqautomotive.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org,
	Gustavo Silva <gustavograzs@gmail.com>,
	Marcelo Schmitt <marcelo.schmitt@analog.com>,
	Antoniu Miclaus <antoniu.miclaus@analog.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Ramona Alexandra Nechita <ramona.nechita@analog.com>,
	Tomislav Denis <tomislav.denis@avl.com>,
	Jorge Marques <jorge.marques@analog.com>,
	Dan Robertson <dan@dlrobertson.com>,
	Jianping Shen <Jianping.Shen@de.bosch.com>,
	Gwendal Grignou <gwendal@chromium.org>,
	Maxwell Doose <maxwell@maxwelld.cc>,
	Tomasz Duszynski <tduszyns@gmail.com>,
	Esben Haabendal <esben@geanix.com>,
	Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>,
	Jiri Kosina <jikos@kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Vasileios Amoiridis <vassilisamir@gmail.com>,
	Abhash Jha <abhashkumarjha123@gmail.com>,
	Puranjay Mohan <puranjay@kernel.org>,
	Nishant Malpani <nish.malpani25@gmail.com>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Linus Walleij <linusw@kernel.org>,
	Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
Subject: Re: [PATCH 13/35] iio: accel: bma220: use default_trigger
Date: Mon, 16 Nov 2026 19:27:26 +0200	[thread overview]
Message-ID: <avs8_igmLZIDOrSB@sunspire.home.arpa> (raw)
In-Reply-To: <20261116014823.3132576-14-jic23@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]


Hello Jonathan,

On Mon, Nov 16, 2026 at 01:48:01AM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> 
> Set indio_dev->default_trigger rather than taking a reference to the
> trigger in probe(). The IIO core now takes the reference during
> iio_device_register(), so it is not leaked if probe() fails after
> the trigger is set up.  Whilst this patch closes the specific
> bug, it also makes the ordering less fragile going forwards.
> 
> Fixes: b7e17ca10793 ("iio: accel: bma220: add interrupt trigger")
> Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> ---
>  drivers/iio/accel/bma220_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/bma220_core.c b/drivers/iio/accel/bma220_core.c
> index b83abfdd84fd..23eff578158c 100644
> --- a/drivers/iio/accel/bma220_core.c
> +++ b/drivers/iio/accel/bma220_core.c
> @@ -539,7 +539,7 @@ int bma220_common_probe(struct device *dev, struct regmap *regmap, int irq)
>  		if (ret)
>  			return dev_err_probe(dev, ret,
>  					     "iio trigger register fail\n");
> -		indio_dev->trig = iio_trigger_get(data->trig);
> +		indio_dev->default_trigger = data->trig;
>  		ret = devm_request_threaded_irq(dev, irq, NULL,
>  						&bma220_irq_handler, IRQF_ONESHOT,
>  						indio_dev->name, indio_dev);
> -- 
> 2.56.1
> 

passes all my unit tests on both i2c and spi sensors, thanks for the patch.

Tested-by: Petre Rodan <petre.rodan@subdimension.ro>

best regards,
peter

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 870 bytes --]

  parent reply	other threads:[~2026-11-16 17:27 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  1:47 [PATCH 00/35] iio: closing default trigger handling leaks Jonathan Cameron
2026-11-16  1:47 ` [PATCH 01/35] iio: core: add default_trigger and take reference in iio_device_register() Jonathan Cameron
2026-11-16 10:14   ` Linus Walleij
2026-11-16  1:47 ` [PATCH 02/35] media: pci: mgb4: use IIO default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 03/35] iio: chemical: ens160: use default_trigger Jonathan Cameron
2026-11-16  1:47 ` [PATCH 04/35] iio: adc: ad4130: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 05/35] iio: adc: ad4170-4: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 06/35] iio: adc: ad7768-1: " Jonathan Cameron
2026-11-18  8:44   ` Joshua Crofts
2026-11-16  1:47 ` [PATCH 07/35] iio: adc: ad7779: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 08/35] iio: adc: ti-ads131e08: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 09/35] iio: addac: ad74115: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 10/35] iio: addac: ad74413r: " Jonathan Cameron
2026-11-16  1:47 ` [PATCH 11/35] iio: temperature: tmp006: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 12/35] iio: adc: ad4062: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 13/35] iio: accel: bma220: " Jonathan Cameron
2026-11-16 10:13   ` Linus Walleij
2026-11-16 17:27   ` Petre Rodan [this message]
2026-11-16  1:48 ` [PATCH 14/35] iio: accel: bma400: " Jonathan Cameron
2026-11-16 10:13   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 15/35] iio: imu: smi330: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 16/35] iio: light: acpi-als: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 17/35] iio: chemical: scd30: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 18/35] iio: accel: bma180: " Jonathan Cameron
2026-11-16 10:12   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 19/35] iio: accel: kxcjk-1013: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 20/35] iio: accel: mma8452: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 21/35] iio: chemical: ccs811: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 22/35] iio: pressure: mpl3115: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 23/35] iio: common: st_sensors: " Jonathan Cameron
2026-11-16 10:12   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 24/35] iio: common: hid-sensors: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 25/35] iio: pressure: bmp280: " Jonathan Cameron
2026-11-16 10:11   ` Linus Walleij
2026-11-16  1:48 ` [PATCH 26/35] iio: light: vl6180: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 27/35] iio: gyro: itg3200: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 28/35] iio: imu: bmi160: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 29/35] iio: accel: adxl355: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 30/35] iio: gyro: adxrs290: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 31/35] iio: accel: adxl372: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 32/35] iio: light: si1145: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 33/35] iio: adc: ti-tsc2046: " Jonathan Cameron
2026-11-16 14:19   ` Oleksij Rempel
2026-11-16  1:48 ` [PATCH 34/35] iio: accel: mxc4005: " Jonathan Cameron
2026-11-16  1:48 ` [PATCH 35/35] iio: gyro: mpu3050: " Jonathan Cameron
2026-11-16 10:11   ` Linus Walleij
2026-11-17  7:20 ` [PATCH 00/35] iio: closing default trigger handling leaks Andy Shevchenko
2026-11-18  8:46 ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avs8_igmLZIDOrSB@sunspire.home.arpa \
    --to=petre.rodan@linux.dev \
    --cc=Jianping.Shen@de.bosch.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=abhashkumarjha123@gmail.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dan@dlrobertson.com \
    --cc=dlechner@baylibre.com \
    --cc=esben@geanix.com \
    --cc=gustavograzs@gmail.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=jorge.marques@analog.com \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=martin.tuma@digiteqautomotive.com \
    --cc=maxwell@maxwelld.cc \
    --cc=mchehab@kernel.org \
    --cc=narcisaanamaria12@gmail.com \
    --cc=nish.malpani25@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=o.rempel@pengutronix.de \
    --cc=puranjay@kernel.org \
    --cc=ramona.nechita@analog.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tduszyns@gmail.com \
    --cc=tomislav.denis@avl.com \
    --cc=vassilisamir@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.