All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <avinesh.kumar@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] pids.sh: Wait for killed tasks to leave the cgroup
Date: Mon, 16 Nov 2026 17:24:12 +0100	[thread overview]
Message-ID: <avsuLPpinUJg7a4l@yuki.lan> (raw)
In-Reply-To: <20261116093659.828828-1-avinesh.kumar@suse.com>

Hi!
> pids_task1 leaves an orphaned child in the cgroup, so "wait" in
> stop_pids_tasks_path() can't wait for it, and kill -9 only queues the
> signal. The rmdir that follows can fail with EBUSY (unchecked), leaving
> the child cgroup behind and breaking the cgroup cleanup:
> 
>     rmdir: failed to remove '.../test-3200/child1': Device or resource busy
>     tst_cgroup.c:1052: TBROK: unlinkat(..., 'test-3200', AT_REMOVEDIR): EBUSY
> 
> Wait for the cgroup to become empty at the end of
> stop_pids_tasks_path() and in cleanup() before the test cgroup is removed.
> 
> Fixes: dd2b901a9 ("controllers: Update pids.sh to use newer cgroup lib")
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> ---
>  testcases/kernel/controllers/pids/pids.sh | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/testcases/kernel/controllers/pids/pids.sh b/testcases/kernel/controllers/pids/pids.sh
> index dd27b5616f0c..32434ab0dba0 100755
> --- a/testcases/kernel/controllers/pids/pids.sh
> +++ b/testcases/kernel/controllers/pids/pids.sh
> @@ -32,11 +32,28 @@ OPTIONS
>  EOF
>  }
>  
> +wait_cgroup_empty()
> +{
> +	local delay=1000
> +
> +	while [ -n "$(cat "$1/$task_list" 2>/dev/null)" ]; do
> +		if [ $delay -gt 4000000 ]; then
> +			# tst_brk() only warns in cleanup(), so return after it
> +			tst_brk TBROK "cgroup $1 is not empty"
> +			return
> +		fi
> +		tst_sleep ${delay}us
> +		delay=$((delay * 2))
> +	done
> +}
> +
>  cleanup()
>  {
>  	killall -9 pids_task2 >/dev/null 2>&1
>  	killall -9 pids_task1 >/dev/null 2>&1
>  
> +	[ -n "$testpath" ] && wait_cgroup_empty "$testpath"
> +
>  	cgroup_cleanup
>  }
>  
> @@ -83,6 +100,10 @@ stop_pids_tasks_path()
>  		kill -9 $i 2>/dev/null
>  		wait $i 2>/dev/null
>  	done
> +
> +	# wait can't reap the orphaned pids_task1 children, so wait for them
> +	# to leave the cgroup instead
> +	wait_cgroup_empty "$path"
>  }

This is working around the real problem. The tst_cg_cleanup() function
in lib/tst_cgroup.c that is eventually called from cgroup_cleanup
(testcases/lib/tst_cgctl.c) makes sure there are no processes left
before unlinking the cgroups.

The ugly part of the shell cgroup library is that it dumps the cgroup
library state into a file and then re-loads it in each command. So my
guess is that there is a bug somewhere in that code.

And I also suppose that it would be easier to rewrite the test into C so
that we can use the library natively than trying to find the problem.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2026-11-16 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  9:36 [LTP] [PATCH] pids.sh: Wait for killed tasks to leave the cgroup Avinesh Kumar via ltp
2026-11-16 12:08 ` [LTP] " linuxtestproject.agent
2026-11-16 16:24 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avsuLPpinUJg7a4l@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=avinesh.kumar@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.