From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>
Subject: Re: [PATCH v3 19/26] hw/char: mark common serial / console devices as secure
Date: Mon, 16 Nov 2026 18:06:07 +0000 [thread overview]
Message-ID: <avtGD4N677h5o85q@redhat.com> (raw)
In-Reply-To: <1725710c-a202-406e-9eb6-d8a42a62d86a@oss.qualcomm.com>
On Mon, Nov 16, 2026 at 02:36:39PM +0100, Philippe Mathieu-Daudé wrote:
> On 13/11/26 19:42, Daniel P. Berrangé wrote:
> > These are needed as a baseline feature for many virtualization use
> > cases on x86, PPC64 and s390x.
> >
> > Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Acked-by: Cornelia Huck <cohuck@redhat.com> #sclpconsole(-lm)
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > hw/char/debugcon.c | 1 +
> > hw/char/sclpconsole-lm.c | 1 +
> > hw/char/sclpconsole.c | 1 +
> > hw/char/serial-isa.c | 1 +
> > hw/char/serial-pci.c | 1 +
> > hw/char/serial.c | 1 +
> > hw/char/spapr_vty.c | 1 +
> > 7 files changed, 7 insertions(+)
> >
> > diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c
> > index a1b370b90be..f38ce7b765e 100644
> > --- a/hw/char/debugcon.c
> > +++ b/hw/char/debugcon.c
> > @@ -134,6 +134,7 @@ static const TypeInfo debugcon_isa_info = {
> > .parent = TYPE_ISA_DEVICE,
> > .instance_size = sizeof(ISADebugconState),
> > .class_init = debugcon_isa_class_initfn,
> > + .secure = true,
> > };
>
> What is the rationale for using the debug console in virtualization?
SeaBIOS/EFI are in the virtualization use and the debugcon is how
you get logs out of them to figure out what's gone wrong when they
break. IMHO that makes it worthwhile to include, and as a device,
it is simple enough that it isn't likely to give us a security
burden.
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-11-16 18:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 18:42 [PATCH v3 00/26] Mark user creatable devices for secure for virt use case Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 01/26] hw: mark most virtio PCI devices as secure Daniel P. Berrangé
2026-11-16 13:05 ` Thomas Huth
2026-11-16 13:08 ` Marc-André Lureau
2026-11-13 18:42 ` [PATCH v3 02/26] hw: mark all virtio CCW " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 03/26] hw: mark all vhost devices a secure Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 04/26] hw: mark most remaining virtio object types as secure Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 05/26] hw/vfio: mark all VFIO object classes " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 06/26] hw/xen: mark all Xen related object types as being secure Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 07/26] hw/net: mark e1000, e1000e, rtl8139 & sPAPR VLAN as secure Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 08/26] hw/usb: mark commonly used USB devices/hosts " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 09/26] hw/watchdog: mark some watchdog devices " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 10/26] hw/scsi: mark spapr SCSI controller " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 11/26] hw/scsi: mark SCSI disk endpoint devices " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 12/26] hw/ide: mark ICH9 and ide-hd/ide-cd " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 13/26] hw: define most common PCI types " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 14/26] hw/pci-host: mark common x86, ppc, arm and s390 PCI hosts " Daniel P. Berrangé
2026-11-16 13:12 ` Thomas Huth
2026-11-13 18:42 ` [PATCH v3 15/26] hw/display: mark bochs, ramfb and VGA " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 16/26] hw/tpm: mark all TPM implementations " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 17/26] hw/misc: mark pvpanic, vmcoreinfo " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 18/26] hw/audio: mark Intel HDA devices & codecs " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 19/26] hw/char: mark common serial / console devices " Daniel P. Berrangé
2026-11-16 13:19 ` Thomas Huth
2026-11-16 13:36 ` Philippe Mathieu-Daudé
2026-11-16 18:06 ` Daniel P. Berrangé [this message]
2026-11-16 21:18 ` Philippe Mathieu-Daudé
2026-11-13 18:42 ` [PATCH v3 20/26] hw/mem: mark nvdimm, pc-dimm & spapr-nvdimm " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 21/26] hw/uefi: mark the EFI vars service " Daniel P. Berrangé
2026-11-16 13:20 ` Thomas Huth
2026-11-16 13:37 ` Philippe Mathieu-Daudé
2026-11-13 18:42 ` [PATCH v3 22/26] hw/acpi: mark erst, vmclock and vmgenid devices " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 23/26] hw: mark KVM clock and RTC " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 24/26] hw: device AMD, Intel and ARM IOMMUs " Daniel P. Berrangé
2026-11-16 13:21 ` Thomas Huth
2026-11-13 18:42 ` [PATCH v3 25/26] hw/input: mark PS/2 and PC Keyboard devices " Daniel P. Berrangé
2026-11-13 18:42 ` [PATCH v3 26/26] hw/i386: mark vmmouse / vmport " Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avtGD4N677h5o85q@redhat.com \
--to=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.