From: Nicolin Chen <nicolinc@nvidia.com>
To: John Garry <john.garry@arm.com>
Cc: <will@kernel.org>, <jgg@nvidia.com>, <robin.murphy@arm.com>,
<joro@8bytes.org>, <praan@google.com>, <kevin.tian@intel.com>,
<smostafa@google.com>, <linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<jamien@nvidia.com>, <kas@kernel.org>,
Cristian Prundeanu <cpru@amazon.com>,
Breno Leitao <leitao@kernel.org>, <xueshuai@linux.alibaba.com>
Subject: Re: [PATCH v12 06/12] iommu/arm-smmu-v3: Disable the EVTQ and the PRIQ in a kdump kernel
Date: Mon, 16 Nov 2026 11:04:54 -0800 [thread overview]
Message-ID: <avtT1pIptUUm23Qg@nvidia.com> (raw)
In-Reply-To: <87102de8-0abf-4d33-a43b-85a83ab29ac4@arm.com>
On Mon, Nov 16, 2026 at 11:08:49AM +0000, John Garry wrote:
> On 11/2/26 05:19, Nicolin Chen wrote:
> > A kdump kernel cannot use either queue.
>
> I'd say a "kdump kernel cannot use either queue without potential problems".
OK.
> > @@ -5573,6 +5570,15 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu)
> > if (arm_smmu_sva_supported(smmu))
> > smmu->features |= ARM_SMMU_FEAT_SVA;
> > + /*
> > + * A kdump kernel wants neither queue: the crashed kernel's CDs and page
> > + * tables might be corrupted, spamming events, and page requests cannot
> > + * be served. A disabled queue discards new records without raising any
> > + * global error.
> > + */
> > + if (is_kdump_kernel())
> > + smmu->features &= ~(ARM_SMMU_FEAT_EVTQ | ARM_SMMU_FEAT_PRI);
>
> It's less than ideal that we unconditionally set ARM_SMMU_FEAT_EVTQ at the
> beginning of this function, and then here conditionally unset it. Can we
> just conditionally set it once?
I see the opposite. Conditionally setting would need two pieces of
comments. It's neater to have it here right before:
if (is_kdump_kernel())
arm_smmu_device_kdump_probe()
Nicolin
next prev parent reply other threads:[~2026-11-16 19:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 5:19 [PATCH v12 00/12] iommu/arm-smmu-v3: Adopt the crashed kernel's stream table for kdump Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 01/12] iommu: Pass in NULL old_domain when attaching a deferred device Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 02/12] iommu/arm-smmu-v3: Init the vmid_map ida before the stream table setup Nicolin Chen
2026-11-16 9:30 ` John Garry
2026-11-02 5:19 ` [PATCH v12 03/12] iommu/arm-smmu-v3: Make the ASID space per SMMU instance Nicolin Chen
2026-11-16 9:46 ` John Garry
2026-11-16 18:22 ` Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 04/12] iommu/arm-smmu-v3: Pack the MSI vectors of the used sources Nicolin Chen
2026-11-16 10:29 ` John Garry
2026-11-16 18:57 ` Nicolin Chen
2026-11-17 14:30 ` John Garry
2026-11-17 16:18 ` Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 05/12] iommu/arm-smmu-v3: Add ARM_SMMU_FEAT_EVTQ for the event queue Nicolin Chen
2026-11-16 10:59 ` John Garry
2026-11-02 5:19 ` [PATCH v12 06/12] iommu/arm-smmu-v3: Disable the EVTQ and the PRIQ in a kdump kernel Nicolin Chen
2026-11-16 11:08 ` John Garry
2026-11-16 19:04 ` Nicolin Chen [this message]
2026-11-02 5:19 ` [PATCH v12 07/12] iommu/arm-smmu-v3: Add ARM_SMMU_OPT_KDUMP_ADOPT for " Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 08/12] iommu/arm-smmu-v3-kexec: Reserve crashed kernel's ASIDs and VMIDs Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 09/12] iommu/arm-smmu-v3-kexec: Implement is_attach_deferred() Nicolin Chen
2026-11-16 12:03 ` John Garry
2026-11-02 5:19 ` [PATCH v12 10/12] iommu/arm-smmu-v3: Retain CR0_SMMUEN during kdump device reset Nicolin Chen
2026-11-16 12:19 ` John Garry
2026-11-16 19:12 ` Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 11/12] iommu/arm-smmu-v3: Skip RMR bypass for kdump adoption Nicolin Chen
2026-11-16 12:26 ` John Garry
2026-11-16 19:24 ` Nicolin Chen
2026-11-17 14:34 ` John Garry
2026-11-17 16:20 ` Nicolin Chen
2026-11-02 5:19 ` [PATCH v12 12/12] iommu/arm-smmu-v3: Detect ARM_SMMU_OPT_KDUMP_ADOPT in probe() Nicolin Chen
2026-11-16 12:32 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avtT1pIptUUm23Qg@nvidia.com \
--to=nicolinc@nvidia.com \
--cc=cpru@amazon.com \
--cc=iommu@lists.linux.dev \
--cc=jamien@nvidia.com \
--cc=jgg@nvidia.com \
--cc=john.garry@arm.com \
--cc=joro@8bytes.org \
--cc=kas@kernel.org \
--cc=kevin.tian@intel.com \
--cc=leitao@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.