From: Jarkko Sakkinen <jarkko@kernel.org>
To: William Chuang <founder@logarcheon.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] lib/asn1_decoder: add KUnit test suite
Date: Tue, 17 Nov 2026 03:32:09 +0200 [thread overview]
Message-ID: <avuumVbCS2YQi4cv@kernel.org> (raw)
In-Reply-To: <20261117001711.47722-1-founder@logarcheon.com>
On Tue, Nov 17, 2026 at 12:17:17AM +0000, William Chuang wrote:
> Add a KUnit test suite for the ASN.1 BER/DER decoder in
> lib/asn1_decoder.c. A tiny two-field grammar (SEQUENCE { INTEGER,
> OCTET STRING }) drives asn1_ber_decoder() with well-formed and
> malformed byte strings and checks that valid input is parsed and each
> class of malformed input is rejected with the documented error code
> rather than over-read.
1. I'm not convinced. Why overall?
2. Why KUnit?
3. Why host the test in kernel?
Br, Jarkko
next prev parent reply other threads:[~2026-11-17 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 0:17 [RFC PATCH] lib/asn1_decoder: add KUnit test suite William Chuang
2026-11-17 1:32 ` Jarkko Sakkinen [this message]
2026-11-17 2:39 ` William Chuang, Founder – Logarcheon
2026-11-17 3:09 ` Jarkko Sakkinen
2026-11-17 3:24 ` Jarkko Sakkinen
2026-11-17 22:44 ` William Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avuumVbCS2YQi4cv@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=founder@logarcheon.com \
--cc=keyrings@vger.kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.