All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Caione <ccaione@baylibre.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
	 Weijie Gao <weijie.gao@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Igor Belwon <igor.belwon@mentallysanemainliners.org>,
	Julien Stephan <jstephan@baylibre.com>,
	 GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	Tom Rini <trini@konsulko.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Bhupesh Sharma <bhupesh.linux@gmail.com>,
	 Neha Malcom Francis <n-francis@ti.com>,
	Macpaul Lin <macpaul.lin@mediatek.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	u-boot@lists.u-boot-project.org
Subject: Re: [PATCH 2/7] ufs: mediatek: skip SiP calls when running at EL3
Date: Tue, 17 Nov 2026 07:24:41 +0100	[thread overview]
Message-ID: <avvy2Bm1ckpMBc3y@macbook> (raw)
In-Reply-To: <9f91272a-2f34-4192-b0ae-41320ec552c2@baylibre.com>

On Mon, Nov 16, 2026 at 16:40:05 +0100, David Lechner wrote:
> >> @@ -37,6 +38,10 @@ struct ufs_mtk_smc_arg {
> >>  
> >>  static inline void _ufs_mtk_smc(struct ufs_mtk_smc_arg s)
> >>  {
> >> +	/* No secure monitor to call yet, e.g. in SPL before BL31. */
> >> +	if (current_el() == 3)
> >> +		return;
> > 
> > Can we return an error from here? Otherwise functions like
> > ufs_mtk_device_reset() are going to assume that the function is
> > successful.
> > 
> 
> I don't think we should consider this an error. We return early because
> there is nothing to do, not because we can't do something that is required.

Yes, but for example in ufs_mtk_device_reset_ctrl() we are waiting 26ms
for nothing and printing a now misleading "device reset done".

--
Carlo Caione

  reply	other threads:[~2026-11-17  6:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 21:35 [PATCH 0/7] mediatek: mt8189: add UFS boot for Genio 520 and 720 SPL David Lechner
2026-11-06 21:35 ` [PATCH 1/7] tools: mtk_image: add UFS support David Lechner
2026-11-11 19:04   ` Carlo Caione
2026-11-06 21:35 ` [PATCH 2/7] ufs: mediatek: skip SiP calls when running at EL3 David Lechner
2026-11-11 19:04   ` Carlo Caione
2026-11-16 22:40     ` David Lechner
2026-11-17  6:24       ` Carlo Caione [this message]
2026-11-17 14:36         ` David Lechner
2026-11-06 21:35 ` [PATCH 3/7] arm: dts: mediatek: prepare Genio 520 and 720 UFS for SPL David Lechner
2026-11-06 21:35 ` [PATCH 4/7] arm: mediatek: load the next stage from UFS in SPL David Lechner
2026-11-06 21:35 ` [PATCH 5/7] arm: mediatek: make the BootROM header info configurable David Lechner
2026-11-11 19:04   ` Carlo Caione
2026-11-11 20:03     ` David Lechner
2026-11-06 21:35 ` [PATCH 6/7] board: mediatek: add a Genio 520/720 UFS boot config fragment David Lechner
2026-11-06 21:35 ` [PATCH 7/7] doc: board: mediatek: describe booting Genio 520 and 720 from UFS David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avvy2Bm1ckpMBc3y@macbook \
    --to=ccaione@baylibre.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=bhupesh.linux@gmail.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=dlechner@baylibre.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jstephan@baylibre.com \
    --cc=macpaul.lin@mediatek.com \
    --cc=n-francis@ti.com \
    --cc=neil.armstrong@linaro.org \
    --cc=ryder.lee@mediatek.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.