From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4CB3606A31C for ; Tue, 17 Nov 2026 11:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=xenproject.org header.i=@xenproject.org header.a=rsa-sha256 header.s=20200302mail header.b=KU2BzhgX Received: from list by lists.xenproject.org with outflank-mailman.1492203.1692916 (Exim 4.92) (envelope-from ) id 1xTHTI-0001Aq-2T; Tue, 17 Nov 2026 11:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1492203.1692916; Tue, 17 Nov 2026 11:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xTHTH-0001Aj-Vn; Tue, 17 Nov 2026 11:35:31 +0000 Received: by outflank-mailman (input) for mailman id 1492203; Tue, 17 Nov 2026 11:35:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xTHTG-0001Ad-T2 for xen-devel@lists.xenproject.org; Tue, 17 Nov 2026 11:35:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xTHTG-00000002u8q-1L5n; Tue, 17 Nov 2026 11:35:30 +0000 Received: from 224.pool85-54-217.dynamic.orange.es ([85.54.217.224] helo=localhost) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xTHTG-0000000BiDE-2DQ3; Tue, 17 Nov 2026 11:35:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Post: List-Help: List-Subscribe: , Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=Doel5jJvUpo5d+zZY6yeQjScmR2psmEAggTequD3ejc=; b=KU2BzhgXGNALUaYmeVq8f75zlL zTSoAAsueo9npWveBCfUl6OczWq+c61MDpPgSXGXdNj/IIcbJwgGx+5HFw9n2IdOlyLjDel905rOz 8+NQEYkENrYxvGegalaGG6pfLCwU9/AiZxtwluBMWqLT4nCslDGX67ejRBxSV6aAC7+Y=; Date: Tue, 17 Nov 2026 12:35:28 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Teddy Astie Subject: Re: [PATCH 2/4] x86/IRQ: use less heavy locking in free_domain_pirqs() Message-ID: References: <37c9675b-dc2b-4c57-b5a8-79075836311b@suse.com> <12b095ad-2fbf-4964-bad0-ae930009a22f@suse.com> <97f680e6-0d3c-4077-977d-bd6ba7e64f66@suse.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <97f680e6-0d3c-4077-977d-bd6ba7e64f66@suse.com> X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, Nov 17, 2026 at 11:38:29AM +0100, Jan Beulich wrote: > On 17.11.2026 11:31, Roger Pau Monné wrote: > > On Thu, Oct 29, 2026 at 03:24:13PM +0100, Jan Beulich wrote: > >> Holding the domain's PCI lock (alongside its event lock) is sufficient > >> around unmap_domain_pirq(). > >> > >> Signed-off-by: Jan Beulich > > > > Acked-by: Roger Pau Monné > > Thanks, but: Considering your reply to patch 1, did you forget to make this > conditional upon the same prereq change that you outline there? Strictly speaking this function is only called from arch_domain_destroy(), which is done after PCI devices are deassigned and MSIs are torn down. In this context unmap_domain_pirq() is only caled against GSIs. But yes, for correctness (and to avoid confusion) I should have tied it to the same request as patch 1. Thanks, Roger.