All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Chen Yuxi <chenyuxi19@huawei.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
	patches@opensource.cirrus.com, sebastian.krzyszkowiak@puri.sm,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	yeweihua4@huawei.com, pulehui@huawei.com
Subject: Re: [PATCH] ASoC: wm8962: Fix broken headset button caused by wrong guard constant
Date: Tue, 17 Nov 2026 10:07:38 +0000	[thread overview]
Message-ID: <avwnarkAYaaaSIQJ@opensource.cirrus.com> (raw)
In-Reply-To: <20261117070516.3861828-1-chenyuxi19@huawei.com>

On Tue, Nov 17, 2026 at 07:05:16AM +0000, Chen Yuxi wrote:
> Commit e59075211902 ("ASoC: wm8962: Don't report a microphone if
> it's shorted to ground on plug") guards the mic short report by
> testing wm8962->mic_status against WM8962_MICDET_STS.  But mic_status
> stores the reported jack status, composed of SND_JACK_MICROPHONE and
> SND_JACK_BTN_0, which never has WM8962_MICDET_STS set.  The guard is
> therefore always true, so every mic short event reports nothing.
> 
> Pressing the button on a TRRS headset shorts the mic pin to ground,
> which used to be reported as SND_JACK_BTN_0.  After that commit the
> button press is silently dropped, breaking the headset button on all
> wm8962 boards using the mic detect path.
> 
> Test mic_status against SND_JACK_MICROPHONE instead, restoring the
> intended behaviour: suppress the report only when no microphone was
> previously detected, i.e. a TRS plug in a TRRS socket.
> 
> Fixes: e59075211902 ("ASoC: wm8962: Don't report a microphone if it's shorted to ground on plug")
> Cc: stable@vger.kernel.org
> Signed-off-by: Chen Yuxi <chenyuxi19@huawei.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  parent reply	other threads:[~2026-11-17 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:05 [PATCH] ASoC: wm8962: Fix broken headset button caused by wrong guard constant Chen Yuxi
2026-11-17  7:30 ` sashiko-bot
2026-11-17 10:07 ` Charles Keepax [this message]
2026-11-17 13:57 ` Sebastian Krzyszkowiak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwnarkAYaaaSIQJ@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=chenyuxi19@huawei.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=pulehui@huawei.com \
    --cc=sebastian.krzyszkowiak@puri.sm \
    --cc=yeweihua4@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.