All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Usama Arif <usama.arif@linux.dev>,
	 Andrew Morton <akpm@linux-foundation.org>,
	apopple@nvidia.com, byungchul@sk.com, gourry@gourry.net,
	 jannh@google.com, joshua.hahnjy@gmail.com, liam@infradead.org,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ljs@kernel.org,  matthew.brost@intel.com,
	mhocko@suse.com, pfalcato@suse.de, rppt@kernel.org,
	 surenb@google.com, vbabka@kernel.org,
	ying.huang@linux.alibaba.com, ziy@nvidia.com,
	 hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev,
	kernel-team@meta.com,  baolin.wang@linux.alibaba.com,
	Nico Pache <nico.pache@linux.dev>,
	ryan.roberts@arm.com,  dev.jain@arm.com, baohua@kernel.org,
	lance.yang@linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/4] mm/migrate_device: avoid leaking folio references during THP splitting
Date: Tue, 17 Nov 2026 10:33:48 +0000	[thread overview]
Message-ID: <avwtWUVHwcJJKfWR@shutemov.name> (raw)
In-Reply-To: <40f86b39-96cb-4fb3-9282-ec06504774e5@kernel.org>

On Mon, Nov 16, 2026 at 07:44:42PM +0100, David Hildenbrand (Arm) wrote:
> On 11/16/26 07:34, Usama Arif wrote:
> > migrate_vma_split_unmapped_folio() takes an extra folio reference because
> > split_huge_pmd_address(..., true) drops one when it splits a PMD.
> > 
> > However, migrate_vma only holds mmap_lock for reading. A concurrent
> > MADV_DONTNEED can clear the migration PMD, or split it into PTE migration
> > entries, before the split helper takes the PMD lock. The helper then does
> > nothing and leaves the extra reference behind. folio_split_unmapped()
> > fails with -EAGAIN due to the unexpected reference, and the reference is
> > never dropped, so the source THP is leaked.
> > 
> > If a THP is faulted in at the same address inside that window it is
> > worse: freeze = true replaces the new folio's mappings with migration
> > entries that nothing will ever remove, and drops a reference the caller
> > never took.
> > 
> > An existing migration PMD is expanded into PTE migration entries even
> > with freeze = false. Use that mode and remove the extra folio_get(). The
> > reference already held by migration keeps the source folio alive whether
> > or not its PMD migration entry still exists.
> > 
> > Reported-by: Zi Yan <ziy@nvidia.com>
> > Closes: https://lore.kernel.org/all/DLZ48KMS7YG8.3BTM0UUU8CTU2@nvidia.com/
> > Fixes: 4265d67e405a ("mm/migrate_device: add THP splitting during migration")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Usama Arif <usama.arif@linux.dev>
> > ---
> >  mm/migrate_device.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/mm/migrate_device.c b/mm/migrate_device.c
> > index 9e19fadfa65c6..3286bb8a4b73e 100644
> > --- a/mm/migrate_device.c
> > +++ b/mm/migrate_device.c
> > @@ -920,12 +920,7 @@ static int migrate_vma_split_unmapped_folio(struct migrate_vma *migrate,
> >  	unsigned long flags;
> >  	int ret = 0;
> >  
> > -	/*
> > -	 * take a reference, since split_huge_pmd_address() with freeze = true
> > -	 * drops a reference at the end.
> > -	 */
> > -	folio_get(folio);
> > -	split_huge_pmd_address(migrate->vma, addr, true);
> > +	split_huge_pmd_address(migrate->vma, addr, false);
> >  	ret = folio_split_unmapped(folio, 0);
> >  	if (ret)
> >  		return ret;
> 
> Oh, that means we can remove the parameter from split_huge_pmd_address no? Best
> as a cleanup patch once this is in for-next-fixes.

Yeah, that's would be great.

> Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>

The patch looks good to me too:

Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov

  reply	other threads:[~2026-11-17 10:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:34 [PATCH v2 0/4] mm: fixes for THP migration, swap-in and device-private smaps Usama Arif
2026-11-16  6:34 ` [PATCH v2 1/4] mm/migrate_device: avoid leaking folio references during THP splitting Usama Arif
2026-11-16 18:44   ` David Hildenbrand (Arm)
2026-11-17 10:33     ` Kiryl Shutsemau (Meta) [this message]
2026-11-16 18:58   ` Zi Yan
2026-11-16  6:34 ` [PATCH v2 2/4] mm: don't PTE-batch a swap-in of a folio with a hardware-poisoned page Usama Arif
2026-11-16 18:33   ` Joshua Hahn
2026-11-16 18:45   ` David Hildenbrand (Arm)
2026-11-16 19:31   ` Zi Yan
2026-11-17 11:02   ` Kiryl Shutsemau (Meta)
2026-11-16  6:34 ` [PATCH v2 3/4] fs/proc/task_mmu: don't read young/dirty from a non-present PMD in smaps Usama Arif
2026-11-17 11:08   ` Kiryl Shutsemau (Meta)
2026-11-16  6:34 ` [PATCH v2 4/4] fs/proc/task_mmu: account device-private PMDs as present " Usama Arif
2026-11-17 11:13   ` Kiryl Shutsemau (Meta)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwtWUVHwcJJKfWR@shutemov.name \
    --to=kas@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=jannh@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=mhocko@suse.com \
    --cc=nico.pache@linux.dev \
    --cc=pfalcato@suse.de \
    --cc=riel@surriel.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=shakeel.butt@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.