From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Xue Boyang <fuchen.dust@gmail.com>
Cc: kadlec@netfilter.org, fw@strlen.de,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
phil@nwl.cc, sunyiqixm@gmail.com, bsdhenrymartin@gmail.com
Subject: Re: [PATCH nf v4] netfilter: ipset: fix double free on kernel-side delete during resize
Date: Tue, 17 Nov 2026 13:19:22 +0100 [thread overview]
Message-ID: <avxGSmw0DYWUZJrn@chamomile> (raw)
In-Reply-To: <20261117114451.608829-1-fuchen.dust@gmail.com>
On Tue, Nov 17, 2026 at 05:44:51AM -0600, Xue Boyang wrote:
> Thanks for the pointer. I had not taken that series into account when
> preparing v4.
>
> I have now looked through it. The rhashtable conversion removes the
> ipset-specific table-copy resize path, so it appears to avoid this
> double-free/UAF class at its root rather than fixing the individual
> races in the old resize implementation.
>
> I will run the reproducer and the related GC/dump tests against v10 and
> report the results.
Thanks.
> Since that series targets nf-next and is a fairly large conversion,
> while this issue also affects existing and stable kernels, would you
> prefer that I replace this v4 synchronization rework with a smaller
> targeted fix for nf/stable, leaving the complete cleanup to the
> rhashtable series?
I think -stable backports of Florian's ipset update for net-next will
be needed.
prev parent reply other threads:[~2026-11-17 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:10 [PATCH nf v4] netfilter: ipset: fix double free on kernel-side delete during resize Xue Boyang
2026-11-17 10:30 ` Pablo Neira Ayuso
2026-11-17 11:44 ` Xue Boyang
2026-11-17 12:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxGSmw0DYWUZJrn@chamomile \
--to=pablo@netfilter.org \
--cc=bsdhenrymartin@gmail.com \
--cc=coreteam@netfilter.org \
--cc=fuchen.dust@gmail.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=sunyiqixm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.