From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Badhri Jagan Sridharan <badhri@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 5/8] usb: typec: fusb302: rename init_gpio into fusb302_init_irq
Date: Tue, 17 Nov 2026 14:23:24 +0100 [thread overview]
Message-ID: <avxVTBLViL7LMmgY@black.igk.intel.com> (raw)
In-Reply-To: <20261113-fusb302-probe-cleanup-v1-5-e5c65a8c58c8@collabora.com>
On Fri, Nov 13, 2026 at 05:42:41PM +0100, Sebastian Reichel wrote:
> Add the fusb302_ prefix to init_gpio, since it is used by all
> the other functions and allows easy figuring out that it is a
> local function.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/fusb302.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index 8b83414c5819..1b3ee5715a74 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -1643,7 +1643,7 @@ static void fusb302_irq_work(struct work_struct *work)
> enable_irq(chip->gpio_int_n_irq);
> }
>
> -static int init_gpio(struct fusb302_chip *chip)
> +static int fusb302_init_irq(struct fusb302_chip *chip)
> {
> struct device *dev = chip->dev;
> int ret = 0;
> @@ -1758,7 +1758,7 @@ static int fusb302_probe(struct i2c_client *client)
> if (client->irq) {
> chip->gpio_int_n_irq = client->irq;
> } else {
> - ret = init_gpio(chip);
> + ret = fusb302_init_irq(chip);
> if (ret < 0)
> return ret;
> }
>
> --
> 2.53.0
>
--
heikki
next prev parent reply other threads:[~2026-11-17 13:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 16:42 [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Sebastian Reichel
2026-11-13 16:42 ` [PATCH 1/8] usb: typec: tcpm: allocate pd_list entries non device managed Sebastian Reichel
2026-11-13 16:55 ` sashiko-bot
2026-11-13 16:42 ` [PATCH 2/8] usb: typec: tcpm: add device managed port registration Sebastian Reichel
2026-11-13 17:06 ` sashiko-bot
2026-11-13 16:42 ` [PATCH 3/8] usb: typec: fusb302: Switch to device managed resources Sebastian Reichel
2026-11-13 17:21 ` sashiko-bot
2026-11-13 16:42 ` [PATCH 4/8] usb: typec: fusb302: switch to devm_pm_set_wake_irq Sebastian Reichel
2026-11-13 17:34 ` sashiko-bot
2026-11-17 13:20 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 5/8] usb: typec: fusb302: rename init_gpio into fusb302_init_irq Sebastian Reichel
2026-11-13 17:35 ` sashiko-bot
2026-11-17 13:23 ` Heikki Krogerus [this message]
2026-11-13 16:42 ` [PATCH 6/8] usb: typec: fusb302: move gpio_int_n into function local scope Sebastian Reichel
2026-11-13 17:36 ` sashiko-bot
2026-11-17 13:24 ` Heikki Krogerus
2026-11-17 13:37 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 7/8] usb: typec: fusb302: rework gpio_int_n_irq handling Sebastian Reichel
2026-11-13 17:41 ` sashiko-bot
2026-11-17 13:35 ` Heikki Krogerus
2026-11-13 16:42 ` [PATCH 8/8] usb: typec: fusb302: drop custom gpio interrupt logic Sebastian Reichel
2026-11-13 17:51 ` sashiko-bot
2026-11-16 8:32 ` [PATCH 0/8] usb: typec: fusb302: cleanup device driver probe Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxVTBLViL7LMmgY@black.igk.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.