From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: David Hildenbrand <david@kernel.org>,
Gregory Price <gourry@gourry.net>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, larips <larips950@gmail.com>,
stable@vger.kernel.org, Zi Yan <ziy@nvidia.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>,
Ying Huang <ying.huang@linux.alibaba.com>,
Brendan Jackman <brendan.jackman@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>,
Jackie Liu <liuyun01@kylinos.cn>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mempolicy: fix copy_nodes_to_user() for odd inputs
Date: Tue, 17 Nov 2026 14:59:39 +0000 [thread overview]
Message-ID: <avxnIQTcFni9G4IN@gremlin> (raw)
In-Reply-To: <20261117142628.3931151-1-arnd@kernel.org>
On Tue, Nov 17, 2026 at 03:25:53PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ALIGN(maxnode-1, 64) check has an off-by-one error that leads to
> rounding down too much, and ends up not copying the last word when
> userspace asks for one bit over a multiple of 64.
From what I can tell, this isn't an off-by-one, but just the (possibly weird)
convention in mempolicy.c. E.g. in get_nodes():
static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask,
unsigned long maxnode)
{
--maxnode;
< etc. >
}
>
> For compat syscalls, the effect is worse, as the actual calculation for
> the size does include the extra word, but the check for the input size
> does not take it into account and can leak a word of stack data.
>
> In addition, the size calculation rounds up to multiples of 64 bits
> instead of multiples of word size as documented in the man page and
> expected by numactl.
>
> Fortunately numactl always passes multiples of 64 here, so none of
(Claude) went looking at numactl source (e.g. via libnuma) and it seems it
passes size + 1 matching the convention?
> this affects userspace we care about. Finally, the 'nbytes' calculation
> for compat mode makes no sense since that is the size of the kernel's
> internal representation, not the userspace side.
>
> Fix the 'copy' calculation to address all of the above. Note that the
> off-by-one error has been in there since the beginning, but commit
> e130242dc351 ("mm: simplify compat numa syscalls") is where we starting
> copying the wrong data.
>
> Reported-by: larips <larips950@gmail.com>
> Reported-by: Gregory Price (Meta) <gourry@gourry.net>
> Fixes: e130242dc351 ("mm: simplify compat numa syscalls")
> Link: https://lore.kernel.org/all/20261117101910.1820066-1-gourry@gourry.net/
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Please double-check the calculation and retest this with the original
> reproducer. The off-by-one error does explain all of this, I'm still
> worried about getting this version wrong again as everyone including
> myself seems to have missed this in the past 25 years and there may
> still be additional subtle issues around it. Apparently we had many
> instances of the same off-by-one in this file but all (most?) others
> got fixed inadvertently by other changes in the past.
> ---
> mm/mempolicy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 6d662a9a8c74..f318e1155770 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1749,12 +1749,12 @@ static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask,
> static int copy_nodes_to_user(unsigned long __user *mask, unsigned long maxnode,
> nodemask_t *nodes)
> {
> - unsigned long copy = ALIGN(maxnode-1, 64) / 8;
> + unsigned long copy = ALIGN(maxnode, BITS_PER_LONG) / 8;
This looks like it'll be broken given the convention of passing bits + 1,
e.g. ALIGN(1025, 64) / 8 != ALIGN(1024, 64) / 8.
Then later that could case a buffer overflow potentially?
> unsigned int nbytes = BITS_TO_LONGS(nr_node_ids) * sizeof(long);
> bool compat = in_compat_syscall();
>
> if (compat)
> - nbytes = BITS_TO_COMPAT_LONGS(nr_node_ids) * sizeof(compat_long_t);
> + copy = ALIGN(maxnode, BITS_PER_COMPAT_LONG) / 8;
>
Claude suggests that this is potentially broken too for similar reasons.
> if (copy > nbytes) {
> if (copy > PAGE_SIZE)
> --
> 2.53.0
>
Overall it seems the issue is that e130242dc351 (understandably!) passes maxnode
rather than maxnode-1.
So a really small fixup would be something like:
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index fb627b37afcb..051d411c04ee 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1733,12 +1733,12 @@ static int copy_nodes_to_user(unsigned long __user *mask, unsigned long maxnode,
if (clear_user((char __user *)mask + nbytes, copy - nbytes))
return -EFAULT;
copy = nbytes;
- maxnode = nr_node_ids;
+ maxnode = nr_node_ids + 1;
}
if (compat)
return compat_put_bitmap((compat_ulong_t __user *)mask,
- nodes_addr(*nodes), maxnode);
+ nodes_addr(*nodes), maxnode - 1);
return copy_to_user(mask, nodes_addr(*nodes), copy) ? -EFAULT : 0;
}
Maybe doing that's the easiest route for this?
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-11-17 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:25 [PATCH] mm/mempolicy: fix copy_nodes_to_user() for odd inputs Arnd Bergmann
2026-11-17 14:59 ` Lorenzo Stoakes (ARM) [this message]
2026-11-17 15:26 ` Arnd Bergmann
2026-11-17 15:36 ` Lorenzo Stoakes (ARM)
2026-11-17 19:59 ` Gregory Price (Meta)
2026-11-17 20:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxnIQTcFni9G4IN@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brendan.jackman@linux.dev \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=larips950@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuyun01@kylinos.cn \
--cc=rakie.kim@sk.com \
--cc=stable@vger.kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.