From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
tomm.merciai@gmail.com
Subject: Re: [PATCH] drm: renesas: rz-du: Add suspend/resume support
Date: Tue, 17 Nov 2026 16:30:06 +0100 [thread overview]
Message-ID: <avxy_u864ZT7vsLx@tom-desktop> (raw)
In-Reply-To: <CAMuHMdXQjm9rqmKn35G9-CqGSuMO9nirDw2GmFfF2PBfsCvH_Q@mail.gmail.com>
Hi Geert,
Thanks for your review.
On Tue, Nov 17, 2026 at 04:12:43PM +0100, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Thu, 12 Nov 2026 at 09:31, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > Add suspend/resume support to the RZ/G2L DU driver.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_drv.c
> > @@ -140,6 +140,27 @@ static const struct drm_driver rzg2l_du_driver = {
> > .minor = 0,
> > };
> >
> > +/* -----------------------------------------------------------------------------
> > + * Power management
> > + */
> > +
> > +static int rzg2l_du_pm_suspend(struct device *dev)
> > +{
> > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > +
> > + return drm_mode_config_helper_suspend(&rcdu->ddev);
>
> error: passing argument 1 of ‘drm_mode_config_helper_suspend’ from
> incompatible pointer type [-Werror=incompatible-pointer-types]
>
> The "&" should be dropped...
Sorry are you apply this patch on top of some other series?
On top of next-20261116 I'm not seeing this issue.
Maybe I'm missing somenthing?
Thanks in advance.
Kind regards,
Tommaso
>
> > +}
> > +
> > +static int rzg2l_du_pm_resume(struct device *dev)
> > +{
> > + struct rzg2l_du_device *rcdu = dev_get_drvdata(dev);
> > +
> > + return drm_mode_config_helper_resume(&rcdu->ddev);
>
> ... likewise.
>
> > +}
> > +
> > +static DEFINE_SIMPLE_DEV_PM_OPS(rzg2l_du_pm_ops,
> > + rzg2l_du_pm_suspend, rzg2l_du_pm_resume);
> > +
> > /* -----------------------------------------------------------------------------
> > * Platform driver
> > */
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2026-11-17 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:24 [PATCH] drm: renesas: rz-du: Add suspend/resume support Tommaso Merciai
2026-11-17 15:12 ` Geert Uytterhoeven
2026-11-17 15:30 ` Tommaso Merciai [this message]
2026-11-17 15:37 ` Geert Uytterhoeven
2026-11-17 15:43 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxy_u864ZT7vsLx@tom-desktop \
--to=tommaso.merciai.xr@bp.renesas.com \
--cc=airlied@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomm.merciai@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.