All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, berrange@redhat.com
Subject: Re: [PULL 2/8] iotests: better heuristics to find I/O tests build/source dirs
Date: Tue, 17 Nov 2026 21:50:50 +0100	[thread overview]
Message-ID: <avy-KqXX-dDPwois@redhat.com> (raw)
In-Reply-To: <389c8700-e10f-4435-a815-2965136bf5a7@linaro.org>

Am 17.11.2026 um 21:06 hat Richard Henderson geschrieben:
> On 11/17/26 09:17, Kevin Wolf wrote:
> > From: Daniel P. Berrangé<berrange@redhat.com>
> > 
> > Currently the I/O tests cannot be run if executing directly
> > from the source directory, even when wrapped by the 'run'
> > script, due to inadequate heuristics to guess the directories.
> > 
> > If using the 'run' script, meson can tell us exactly where the
> > top level build and source directories are, so we don't need
> > to guess. Just read MESON_BUILD_ROOT and MESON_SOURCE_ROOT
> > env variables if present.
> > 
> > If not using the 'run' script, we can do a bit better at
> > guessing the path from the 'check' filename. Always resolve
> > from sys.argv[0], even when it is not a symlink, instead of
> > falling back to 'cwd()' which doesn't work since we stopped
> > having in-tree builds. If invoked directly from the source
> > tree, guess that the build root is the default 'build' name
> > which often works.
> > 
> > With this change the following all work:
> > 
> > 1. From root of build dir, with run script
> > 
> >    cd build
> >    ./run tests/qemu-iotests/check 5
> > 
> > 2. From root of build dir, without run script
> > 
> >    cd build
> >    tests/qemu-iotests/check 5
> > 
> > 3. From I/O tests subdir of build dir, with run script
> > 
> >    cd build/tests/qemu-iotests
> >    ../../run ./check 5
> > 
> > 4. From I/O tests subdir of build dir, without run script
> > 
> >    cd build/tests/qemu-iotests
> >    ./check 5
> > 
> > 5. From root of source dir, with run script
> > 
> >    ./build/run tests/qemu-iotests/check 5
> > 
> > 6. From root of source dir, without run script
> > 
> >    tests/qemu-iotests/check 5
> > 
> > 7. From I/O tests subdir of source dir, with run script
> > 
> >    cd tests/qemu-iotests
> >    ../../build/run ./check 5
> > 
> > 8. From I/O tests subdir of source dir, without run script
> > 
> >    cd tests/qemu-iotests
> >    ./check 5
> > 
> > Before this commit, items 5-8 would always fail. Items 6 and
> > 8 will not work if using a build directory with a name other
> > than the default 'build'. For those scenarios use one of the
> > other 6 possible variants.
> > 
> > Signed-off-by: Daniel P. Berrangé<berrange@redhat.com>
> > Message-ID:<20261111091133.3527549-1-berrange@redhat.com>
> > Reviewed-by: Kevin Wolf<kwolf@redhat.com>
> > Signed-off-by: Kevin Wolf<kwolf@redhat.com>
> > ---
> >   meson.build              |  1 +
> >   tests/qemu-iotests/check | 52 +++++++++++++++++++++++++++++-----------
> >   2 files changed, 39 insertions(+), 14 deletions(-)
> 
> Fails all of the block tests.  E.g.
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/18118947590#L135
> 
> >  === pylint ===
> > +************* Module check
> > +check:44:12: W0719: Raising too general exception: Exception (broad-exception-raised)
> > +check:44:28: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)
> > +check:61:12: W0719: Raising too general exception: Exception (broad-exception-raised)
> > +check:61:28: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation)

I dropped the patch from the pull request for now and sent a v2.

Kevin



  reply	other threads:[~2026-11-17 20:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 17:17 [PULL 0/8] Block layer patches Kevin Wolf
2026-11-17 17:17 ` [PULL 1/8] block/bochs: validate bitmap size and compute extent_blocks after validation Kevin Wolf
2026-11-17 17:17 ` [PULL 2/8] iotests: better heuristics to find I/O tests build/source dirs Kevin Wolf
2026-11-17 20:06   ` Richard Henderson
2026-11-17 20:50     ` Kevin Wolf [this message]
2026-11-17 17:17 ` [PULL 3/8] block/vhdx-log: Improve sanity checks to avoid OOB accesses with bad images Kevin Wolf
2026-11-17 17:17 ` [PULL 4/8] iotests: fix false positive on running-outside-venv warning Kevin Wolf
2026-11-17 17:17 ` [PULL 5/8] block/vhdx: Add alignment checks for region tables Kevin Wolf
2026-11-17 17:17 ` [PULL 6/8] block: read the old child length after draining in bdrv_replace_child_bs() Kevin Wolf
2026-11-17 17:17 ` [PULL 7/8] block: add bdrv_child_notify_resize() to notify a single parent Kevin Wolf
2026-11-17 17:17 ` [PULL 8/8] block: notify only the replaced child in bdrv_replace_child_bs() Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avy-KqXX-dDPwois@redhat.com \
    --to=kwolf@redhat.com \
    --cc=berrange@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.