From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: E Shattow <e@freeshell.de>
Cc: u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v4 1/2] doc: develop/sending_patches: add tips for series
Date: Tue, 17 Nov 2026 14:31:10 -0500 [thread overview]
Message-ID: <avyrfjvcAVBe4qQ5@maple.netwinder.org> (raw)
In-Reply-To: <33c70db1-226a-4108-b690-ad07cecf7752@freeshell.de>
On Thu, Nov 12, 2026 at 03:19:18PM -0800, E Shattow wrote:
>On 11/12/26 13:55, Ralph Siemsen wrote:
>> +
>> +A series of related patches can be sent as a "patch series", as described
>> +above. Individual patches should be small and self-contained. Likewise,
>> +this also applies to each "patch series". Keep the following in mind:
>> +
>> +* large series are harder to review. Maintainers are busy and may postpone
>
>This reads a bit awkwardly. Maybe "A large series is harder to review"
>or "large series patches are harder to review", depending on what the
>meaning is you are wanting to convey.
I'll see if I can reword it more clearly. I was referring to series with
a large number of patches. The existing document already talks about
(individual) large patches.
>Either seems to me like injecting your opinion about what is easy or
>difficult to review which does not align with my view of this that the
>difficulty in reviewing a patch series is proportional to the discipline
>in focus the author has for presenting their idea and developing it to a
>meaningful change with the assistance of code review;
Knowing how to present ideas clearly and develop them based on review
feedback is something that must be learned. Some people are naturally
good at it, but the rest of us appreciate all the guidance we can get.
>if it will
>require a great deal of involvement then don't expect to just dump your
>code off on the list and have it be merged because you gave this "gift"
>of 100+ small patches in a series, or even a single patch large-or-small
>that is several disjointed ideas or bug fixes.
How can we help an author to recognize that their code is going to
require a great deal of involvement from the reviewer? Most submissions
are made in good faith, with lots of effort on the author's part. The
author cannot read the reviewer's mind, so we have to try to document
expectations as best we can. That was my goal with this change.
>Nothing happens "quickly". The point of bug fixes being independent is
>so they can be reviewed and verified independently from unrelated
>changes. Quickness is not the driver of getting merged or not merged, or
>it should not be.
I'll reword it without "quickly". But I do think that certain bug fixes
are more urgent, and should be handled "quickly". Such fixes should not
be bundled into a series with other changes. Which seems pretty obvious,
but still worth writing down.
>> +* tools like ``b4`` and ``patman`` send the entire patch series to
>
>Do correct me if I am mistaken: for consistency I think we are
>recommending people use b4 and patman, and not tools similar to these.
Indeed those two are recommended earlier in the document. I'll remove
the ambiguous "like" and just write "The b4 and patman tools ..."
>> + reviewers, even though individual reviews may only care about some
>> parts.
>> + Filtering out the relevant parts takes time away from actual reviews.
>> +
>What is an "actual review" ? That sounds so strange.
I meant "actually doing code review", as opposed time spent filtering
out emails (parts of series) that are not of interest to the reviewer.
The tools collect reviewers for each patch in a series, but they send
all patches to all reviewers. So if the series contains changes to
driver A and B, each with their own maintainer, then both maintainers
have to dig out the part they care about.
To avoid this, authors need to be aware of this when using the tools.
One warning sign is a large list of auto-generated recipients, which
usually indicates that change needs to be split up further.
>Drop my R-by tag, thanks. -E
Will do.
-R
next prev parent reply other threads:[~2026-11-17 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 21:55 [PATCH v4 0/2] doc: tips for submitting patch series Ralph Siemsen
2026-11-12 21:55 ` [PATCH v4 1/2] doc: develop/sending_patches: add tips for series Ralph Siemsen
2026-11-12 23:19 ` E Shattow
2026-11-13 13:42 ` Quentin Schulz
2026-11-17 19:31 ` Ralph Siemsen [this message]
2026-11-12 21:55 ` [PATCH v4 2/2] doc: CONTRIBUTE: minor spelling and link Ralph Siemsen
2026-11-13 13:42 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyrfjvcAVBe4qQ5@maple.netwinder.org \
--to=ralph.siemsen@linaro.org \
--cc=e@freeshell.de \
--cc=neil.armstrong@linaro.org \
--cc=quentin.schulz@cherry.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.