From: Kuniyuki Iwashima <kuniyu@google.com>
To: Eric Dumazet <edumazet@kernel.org>
Cc: Neal Cardwell <ncardwell@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net 3/8] tcp: Don't bypass GTSM check for reqsk.
Date: Tue, 17 Nov 2026 23:42:50 +0000 [thread overview]
Message-ID: <avzl2v7GXVWc59wN@google.com> (raw)
In-Reply-To: <CAL4WiipiADQzec6YVP6H0rQSzAXZCFdtZb2SemKTSAz0pzHs4Q@mail.gmail.com>
On Tue, 17 Nov 2026 09:45:57 +0100, Eric Dumazet wrote:
> Le mar. 17 nov. 2026 à 06:35, Kuniyuki Iwashima <kuniyu@google.com> a écrit :
> >
> > Since cited commits moved up TCP_NEW_SYN_RECV handling in
> > tcp_v4_err() and tcp_v6_err(), ICMP messages bypass IP_MINTTL
> > and IPV6_MINHOPCOUNT checks.
> >
> > The minimal repro is:
> >
> > --ip_version=ipv6
> > 0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
> > +0 setsockopt(3, SOL_IPV6, 73, [255], 4) = 0
> > +0 bind(3, ..., ...) = 0
> > +0 listen(3, 10) = 0
> > +0 < (ttl 255) S 0:0(0) win 65535 <mss 1440,nop,nop,sackOK>
> > +0 > S. 0:0(0) ack 1 <mss 1440,nop,nop,sackOK>
> > +0 < (ttl 1) icmp unreachable port_unreachable [0:0(0)]
> > +0 < (ttl 255) . 1:1(0) ack 1 win 65535
> > +0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
> > +0 accept(3, ..., ...) = 4
> > +0 %{assert tcpi_state == TCP_ESTABLISHED}%
> >
> > Let's restore IP_MINTTL/IPV6_MINHOPCOUNT for reqsk.
> >
> > Fixes: 26e3736090e1 ("ipv4: tcp: handle ICMP messages on TCP_NEW_SYN_RECV request sockets")
> > Fixes: 2215089b2244 ("ipv6: tcp: handle ICMP messages on TCP_NEW_SYN_RECV request sockets")
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
> > ---
>
> Note the same bypass exists in the receive path : in tcp_v4_rcv() and
> tcp_v6_rcv(), the TCP_NEW_SYN_RECV branch calls tcp_check_req() /
> tcp_child_process() and returns before reaching the min_ttl /
> min_hopcount check done after the process: label.
Yes, and we can move the block to after TIME_WAIT check only
as we don't save min_ttl/min_hopcount for now.
if (sk->sk_state == TCP_TIME_WAIT)
goto do_time_wait;
I'll move the here in v2 (and if needed I can follow up on
net-next for TIME_WAIT).
next prev parent reply other threads:[~2026-11-17 23:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:35 [PATCH v1 net 0/8] tcp: Misc fixes for tcp_v[46]_err() Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 1/8] tcp: Don't accept ICMP for SND.NXT in TCP_SYN_SENT Kuniyuki Iwashima
2026-11-17 8:35 ` Eric Dumazet
2026-11-17 23:30 ` Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 2/8] tcp: Don't use inner IP TTL for IP_MINTTL in tcp_v4_err() Kuniyuki Iwashima
2026-11-17 8:42 ` Eric Dumazet
2026-11-17 23:35 ` Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 3/8] tcp: Don't bypass GTSM check for reqsk Kuniyuki Iwashima
2026-11-17 8:45 ` Eric Dumazet
2026-11-17 23:42 ` Kuniyuki Iwashima [this message]
2026-11-17 5:35 ` [PATCH v1 net 4/8] tcp: Fix reqsk abort condition on ICMP errors Kuniyuki Iwashima
2026-11-17 8:49 ` Eric Dumazet
2026-11-17 23:44 ` Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 5/8] tcp: Check ip_sk_accept_pmtu() in tcp_v4_err() Kuniyuki Iwashima
2026-11-17 8:54 ` Eric Dumazet
2026-11-17 5:35 ` [PATCH v1 net 6/8] selftest: net: packetdrill: Add ICMP and ICMPv6 tests Kuniyuki Iwashima
2026-11-17 8:58 ` Eric Dumazet
2026-11-17 23:45 ` Kuniyuki Iwashima
2026-11-17 5:35 ` [PATCH v1 net 7/8] tcp: Pass inet_sdif() to __inet_lookup_established() in tcp_v4_err() Kuniyuki Iwashima
2026-11-17 9:01 ` Eric Dumazet
2026-11-17 5:35 ` [PATCH v1 net 8/8] tcp: Pass inet6_iif() to __inet6_lookup_established() in tcp_v6_err() Kuniyuki Iwashima
2026-11-17 9:03 ` Eric Dumazet
2026-11-17 23:56 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avzl2v7GXVWc59wN@google.com \
--to=kuniyu@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.