All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Grzeschik <mgr@kernel.org>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: nkapron@google.com, gregkh@linuxfoundation.org,
	 linux-usb@vger.kernel.org, v9fs@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: usb: p9_fwd: Send complete requests to the TCP server
Date: Fri, 20 Nov 2026 10:48:08 +0100	[thread overview]
Message-ID: <awAXLky2Aa6y-RZ5@line.checkpat.ch> (raw)
In-Reply-To: <20261120061937.98224-1-zhujun2@cmss.chinamobile.com>

On Fri, Nov 20, 2026 at 02:19:37PM +0800, Zhu Jun wrote:
> socket.send() can return after sending only a prefix of a request.
> The forwarder ignores that result and waits for a response to an
> incomplete message. Use sendall() so request forwarding completes
> only once all bytes have been sent or a write error is reported.
> 
> Fixes: 673f0c3ffc75 ("tools: usb: p9_fwd: add usb gadget packet forwarder script")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Acked-by: Michael Grzeschik <mgr@kernel.org>

> ---
>  tools/usb/p9_fwd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/usb/p9_fwd.py b/tools/usb/p9_fwd.py
> index 12c76cbb046b..d5ffb2f0c5ab 100755
> --- a/tools/usb/p9_fwd.py
> +++ b/tools/usb/p9_fwd.py
> @@ -124,7 +124,7 @@ class Forwarder:
>              data += self.ep_in.read(size - len(data))
>          logging.log(logging.TRACE, "c2s: writing")
>          self._log_hexdump(data)
> -        self.s.send(data)
> +        self.s.sendall(data)
>          logging.debug("c2s: forwarded %i bytes", size)
>          self.stats["c2s packets"] += 1
>          self.stats["c2s bytes"] += size
> 
> 

      parent reply	other threads:[~2026-11-20  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:19 [PATCH] tools: usb: p9_fwd: Send complete requests to the TCP server Zhu Jun
2026-11-20  6:21 ` sashiko-bot
2026-11-20  9:48 ` Michael Grzeschik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awAXLky2Aa6y-RZ5@line.checkpat.ch \
    --to=mgr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkapron@google.com \
    --cc=v9fs@lists.linux.dev \
    --cc=zhujun2@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.