All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Florent Carli <fcarli@gmail.com>
Cc: stable@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-rt-users@vger.kernel.org
Subject: Re: [REGRESSION] 6.12.y, 6.18.y: fair server runs SCHED_OTHER ahead of SCHED_FIFO on an idle CPU (fixed in 6.19)
Date: Fri, 20 Nov 2026 18:09:58 +0100	[thread overview]
Message-ID: <awB-5usPb2QZXt37@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <CAJuRqcD2=42CTQk2PSHofSmt+=H=qKT-x-ZXD76TwVshaepBAw@mail.gmail.com>

Hello,

On 20/11/26 16:09, Florent Carli wrote:

...

> On 6.12.y and 6.18.y, I see it run SCHED_OTHER tasks ahead of RT tasks
> on a CPU where nothing starves.

...

> The fix went into 6.19:
> 
>   e636ffb9e31b ("sched/deadline: Fix dl_server time accounting")
>   f5a538c07df2 ("sched/deadline: Fix dl_server stop condition")
>   1e0a2ba7afb1 ("sched: Provide idle_rq() helper")
>   ca1e8eede4fc ("sched/deadline: Fix server stopping with runnable tasks")
> 
> None of them carries a stable tag, and only 1e0a2ba7afb1 applies
> cleanly to 6.12.y or 6.18.y.

Thanks for the detailed report and the reproducer, much appreciated.

I had a look and I agree with your analysis. Comparing v6.19 with the
current stable heads (6.12.118 and 6.18.64), these four are the only
dl_server changes not yet in either branch. The other dl_server fixes
from that period (including 115135422562 "Fix 'stuck' dl_server" and
the two "revised wakeup rule" follow-ups) are already in stable.

On applying them: with git am (no -3) I get exactly what you report,
on both 6.18.15 and 6.18.64: only 1e0a2ba7afb1 applies on its own. The
rejects are context only, though (upstream refactors around the
sched_class callbacks that stable doesn't carry), and a 3-way merge
takes care of them. With git cherry-pick, applying them in order:

 - 6.18.y: all four apply cleanly, and the result matches upstream.

 - 6.12.y: e636ffb9e31b and f5a538c07df2 apply cleanly.
   ca1e8eede4fc only has a context conflict in dl_server_start() and
   1e0a2ba7afb1 needs a adaptation.

So I'm in favor of taking these for 6.18.y and 6.12.y. 6.18.y should
go first, so that 6.12.y never carries the fix without the newer
stable branch also having it.

For 6.18.y, since the commits cherry-pick cleanly, it might be enough
to ask the stable team to pick them by SHA.

For 6.12.y, could you then send your backport, rebased on the current
head? Please Cc Peter and Gabriele on both requests, since they authored
the commits and myself.

It would also help if you could rerun your numbers (latency and the
starvation check) on current 6.18.y (64), as 6.18.15 is quite a bit
older and a few dl_server fixes went in since. I tried to reproduce on a
local VM, but I think my system was too noisy to see what you reported.

Until then, setting fair_server runtime to 0 on the isolated CPUs is
a reasonable workaround. Just keep in mind that it removes starvation
protection for all fair tasks on those CPUs (kworkers included).

Thanks,
Juri


  reply	other threads:[~2026-11-20 17:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:09 [REGRESSION] 6.12.y, 6.18.y: fair server runs SCHED_OTHER ahead of SCHED_FIFO on an idle CPU (fixed in 6.19) Florent Carli
2026-11-20 17:09 ` Juri Lelli [this message]
2026-11-20 18:19   ` Florent Carli
2026-11-21 15:27     ` Sasha Levin
2026-11-20 18:19   ` [PATCH 6.12.y 0/4] sched/deadline: dl_server fixes from 6.19 Florent Carli
2026-11-20 18:19     ` [PATCH 6.12.y 1/4] sched/deadline: Fix dl_server time accounting Florent Carli
2026-11-20 18:19     ` [PATCH 6.12.y 2/4] sched/deadline: Fix dl_server stop condition Florent Carli
2026-11-20 18:19     ` [PATCH 6.12.y 3/4] sched: Provide idle_rq() helper Florent Carli
2026-11-20 18:19     ` [PATCH 6.12.y 4/4] sched/deadline: Fix server stopping with runnable tasks Florent Carli
2026-11-21 15:27     ` [PATCH 6.12.y 0/4] sched/deadline: dl_server fixes from 6.19 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awB-5usPb2QZXt37@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=fcarli@gmail.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.