All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Devarsh Thakkar <devarsht@ti.com>,
	dri-devel@lists.freedesktop.org,
	 Paul Cercueil <paul@crapouillou.net>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Jocelyn Falempe <jfalempe@redhat.com>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	 Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Jyri Sarha <jyri.sarha@iki.fi>
Subject: Re: [PATCH v8 00/39] drm: Implement state readout support
Date: Fri, 20 Nov 2026 14:00:44 +0100	[thread overview]
Message-ID: <awBDY37sXERwmU_O@houat> (raw)
In-Reply-To: <ff10a7e1-3a5d-4e0f-be4b-aba3d05de1cd@ideasonboard.com>

[-- Attachment #1: Type: text/plain, Size: 5644 bytes --]

Hi Tomi,

On Tue, Nov 17, 2026 at 05:17:42PM +0200, Tomi Valkeinen wrote:
> On 06/11/2026 15:14, Maxime Ripard wrote:
> > Here's a series that implement what i915 calls "fastboot", ie,
> > initializing the initial KMS state from the hardware state at boot, to
> > skip the first modeset if the firmware already set up the display.
> > 
> > This series creates the infrastructure in KMS to create that state by
> > relying on driver specific hooks. It also implements some infrastructure
> > to check during non-blocking commits that the readout helpers work
> > properly by reading out the state that was just committed and comparing
> > it to what was supposed to be committed.
> > 
> > This relies on another set of driver hooks to compare the entities
> > states, with helpers providing the default implementation.
> > 
> > It then implements the readout support in the TIDSS driver, and was
> > tested with the SK-AM62 board. This board in particular is pretty
> > interesting, since it relies on an DPI to HDMI bridge, and uses the
> > drm_bridge_connector infrastructure.
> > 
> > So the readout works with the current state of the art on embedded-ish
> > platforms.
> > 
> > Unlike the earlier RFCs, it now works fine: the state is picked up
> > properly, doesn't trigger a modeset if what was programmed is the one
> > the first modeset tries to pick as well, will switch properly if it
> > isn't, etc.
> Sorry for taking so long with this, even if I said already a long time back
> that I have additional patches for you. I now finally managed to get them
> into some kind of order, and I have pushed a branch to:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git
> ti/boot-splash-v8.5
> 
> It's based on today's drm-misc-next, with the following posted series on
> top:
> 
> - [PATCH RESEND 00/83] drm: Switch drivers to
> drm_mode_config_create_initial_state
> - [PATCH v8 00/39] drm: Implement state readout support
> 
> However, from the SRO series, I dropped all the tidss patches. It was
> getting so difficult to make my changes at changes on top, so I decided to
> just make fresh clean ones. I've tried to keep authorship where applicable,
> but I could have missed some.
> 
> After the SRO series, I have a pile of patches on top. It starts with tidss
> patches that are not quite SRO related, but fix things or change the
> structure so that SRO gets easier to add:
> 
> drm/tidss: Fix the plane staying disabled after a CRTC off and on
> drm/tidss: Remove the unused 'is_enabled'
> drm/tidss: Split requesting the interrupt from enabling it
> drm/tidss: Split dispc_init_hw() into steps called from probe
> drm/tidss: Reset the DSS after the probe steps that can defer
> drm/tidss: Keep the DSS enabled from the reset to the end of probe
> 
> Then I have some non-tidss patches. Some of these, I think, you already had
> in a local tree or were posted in the tilcdc series. The panel side is
> lacking, so I labeled those as hacks. I'm not quite sure how to correctly
> implement that.
> 
> drm/atomic_sro: Do not compare the plane zpos
> drm/atomic_sro: Do not compare planes on an inactive CRTC
> drm/atomic_sro: Add a device-level atomic_sro_install_state hook
> drm/bridge: Add an atomic_sro_install_state hook for bridges
> HACK: drm/bridge: panel: Prepare and enable the panel when installing the
> state
> HACK: drm/panel: simple: Set the sync polarities of Microtips MF-101HIEBCAF0
> 
> Then I have tidss SRO patches. Many of these are based on yours, but there
> are plenty of details that have changed, fixing issues I found when testing
> different combinations.
> 
> drm/tidss: Implement .hw_reset hook
> drm/tidss: Reset the DISPC at runtime suspend if probe did not reset it
> drm/tidss: dispc: Add helpers for the state readout
> drm/tidss: encoder: Implement atomic_sro_get_current_crtc
> drm/tidss: oldi: Implement hw readout support
> drm/tidss: dispc: Keep DPIENABLE of an active VP in dispc_vp_init()
> drm/tidss: crtc: Implement hw readout support
> drm/tidss: plane: Implement hw readout support
> drm/tidss: encoder: Implement bridge state readout
> drm/tidss: Implement hw readout support
> 
> I have been testing these with AM62-SK, HDMI and OLDI, with all the
> different combinations I've come up with. However, I realized just today
> that the bootloader could still do things a bit differently, which wouldn't
> work with the current patches. I decided to ignore that for now.
> 
> I also need to test all this on other TI boards, without SRO, or perhaps
> adding SRO if it's easy-ish.
> 
> So... Again, thanks Maxime for the great work you've done here, I really
> like this series. It's annoyingly complicated to get to work reliably,
> though, but maybe we'll get there =). With all my tests now working, I'll
> try to find the time to actually review the series.

Thanks a lot for your work too. I share the frustration because I don't
have access to all the hardware variants :)

I've just sent a new version that fixes a fair number of issues you were
facing and creates an install_state hook you needed. I've also split the
tidss readout changes to make it easier to review / modify, but then
your branch diverged a fair bit from mine and I didn't have a good
enough understanding of the tidss driver to reconcile most of the tidss
changes you made.

The core should have everything you need though, so hopefully we can
merge the core changes if sashiko doesn't anything of importance, and
merge the tidss changes once we have something reliable.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

      parent reply	other threads:[~2026-11-20 13:01 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 13:14 [PATCH v8 00/39] drm: Implement state readout support Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 01/39] drm/ingenic: Convert to devm_drm_bridge_alloc() Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:55   ` Luca Ceresoli
2026-11-06 13:59     ` Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 02/39] drm/bridge-helper: Don't unlock the connection mutex after a backoff Maxime Ripard
2026-11-06 13:39   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 03/39] drm/tests: hdmi-state-helper: Handle EDEADLK in the 420-only test Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 04/39] drm/tests: hdmi-state-helper: Handle EDEADLK in the color format test Maxime Ripard
2026-11-06 13:32   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 05/39] drm/colorop: Export drm_atomic_helper_colorop_create_state() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 06/39] drm/atomic: Fix private obj error handling Maxime Ripard
2026-11-06 13:29   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 07/39] drm/atomic: Add drm_private_obj name Maxime Ripard
2026-11-06 13:35   ` sashiko-bot
2026-11-19 15:20   ` Luca Ceresoli
2026-11-06 13:14 ` [PATCH v8 08/39] drm/bridge: Switch print_state to use bridge name Maxime Ripard
2026-11-19 15:25   ` Luca Ceresoli
2026-11-06 13:14 ` [PATCH v8 09/39] drm/bridge: Add drm_private_obj_is_bridge() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 10/39] drm/fb-dma-helper: Handle framebuffers without a GEM object Maxime Ripard
2026-11-06 13:32   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 11/39] drm/gem-atomic-helper: " Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 12/39] drm/atomic: Export drm_atomic_*_print_state Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 13/39] drm/atomic_sro: Create drm_atomic_sro_state container Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 14/39] drm/atomic_sro: Create kernel parameter to force or disable readout Maxime Ripard
2026-11-06 13:31   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 15/39] drm/atomic_sro: Add atomic state readout infrastructure Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 16/39] drm/atomic_sro: Add function to install state into drm objects Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 17/39] drm/atomic_sro: Create documentation Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 18/39] drm/bridge: Handle bridges with hardware state readout Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 19/39] drm/mode-config: Read out hardware state in drm_mode_config_create_state Maxime Ripard
2026-11-06 13:33   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 20/39] drm/atomic_sro: Provide helpers to implement hardware state readout Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 21/39] drm/mode-config: Introduce hw_reset hook Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 22/39] drm/modeset-helper: Add drm_mode_config_helper_hw_reset() Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 23/39] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 24/39] drm/atomic-state-helper: Provide comparison macros Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 25/39] drm/atomic-state-helper: Provide atomic_compare_state helpers Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 26/39] drm/atomic-helper: Document State Read-Out as a state initialization approach Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 27/39] drm/tests: kunit: Add a drm_printer helper Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 28/39] drm/tests: Add tests for the atomic state readout Maxime Ripard
2026-11-06 13:44   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 29/39] drm/encoder: Create atomic_sro_get_current_crtc hook Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 30/39] drm/bridge: display-connector: Implement readout support Maxime Ripard
2026-11-06 13:50   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 31/39] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 32/39] drm/tidss: crtc: Add atomic_print_state implementation Maxime Ripard
2026-11-17  7:24   ` Tomi Valkeinen
2026-11-06 13:14 ` [PATCH v8 33/39] drm/tidss: dispc: Improve mode checking logs Maxime Ripard
2026-11-17  7:25   ` Tomi Valkeinen
2026-11-06 13:14 ` [PATCH v8 34/39] drm/tidss: Implement hw_reset Maxime Ripard
2026-11-06 13:50   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 35/39] drm/tidss: Implement readout support Maxime Ripard
2026-11-06 14:06   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 36/39] drm/tidss: encoder: Implement atomic_sro_get_current_crtc Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 37/39] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2026-11-06 13:14 ` [PATCH v8 38/39] drm/panel: Implement state readout support Maxime Ripard
2026-11-06 13:45   ` sashiko-bot
2026-11-06 13:14 ` [PATCH v8 39/39] fixup! drm/tidss: Implement " Maxime Ripard
2026-11-06 13:57   ` sashiko-bot
2026-11-17 15:17 ` [PATCH v8 00/39] drm: Implement state " Tomi Valkeinen
2026-11-18 12:37   ` Tomi Valkeinen
2026-11-20 13:00   ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBDY37sXERwmU_O@houat \
    --to=mripard@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=devarsht@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jfalempe@redhat.com \
    --cc=jonas@kwiboo.se \
    --cc=jyri.sarha@iki.fi \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=neil.armstrong@linaro.org \
    --cc=paul@crapouillou.net \
    --cc=rfoss@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.