From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795180284; b=UwdcN13+c+EerNs+/EDfXUhKtECG1aw8csGsaUdN8YHzZV+jQHvGnzxROWXmnrFqwO7F e6FEw8IhVMv1cOHIccd301N5p+FP3v0O0MKvpiJRUVMFbWMX2R0m0eFGiJSUKm2jZKqWI /6DhbAnvVkGCqLGuPueDT5YrdcVldZPRUU8FYj897cdWhCk9PdMu+c2PwN5jM1Ji/zjUH aozJBB1VPSM7jY1Z3b1PgXC/7q0A9Yoe0HFpxahUdYXsI2c2N9RT8ZJ6wm7xHGR/Ag5g5 +Fk8hkglI4bRDlmIR5UJCYi+XsIIR5MV5TIscFVzC/KjpHXiejrQOEegRqkDakza40g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795180284; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=11EUqqsBHqKJhSEKaLjedxJRvUSCpiSlKRotGWVYopQ=; b=V1zJDDJuHBkyJNC84YTPVu2gJ5U9GO1vOr8sdITSvmjMCoTAfCzbE7y1i6yrJnCV18vf +JkVlsOjCvNlozNsUWMXI9tO5E2fmo+3ZiaCHYnmSwEZtOvqEQ2Z5F+Nm2LGP/b1anQVi HP4LaVw8yXct0PcH8Bx2z+2fWxN3yQ6UYhXAuBCo8tjKwry+6HDaOxY2CRFsrz5Rq/X12 dEEXHSTMKi6NXvpa566gHrLYnU/vhNwmxnBzyBTz3RebNbiQQ90yJvcFDFhHJ5u6wdDB9 1WWFdzF7M4/U8JYRAfC9ryXP8nLfcjJ9tB6kI1FLyH9G2BGMCGyB26LbI+eaFsbzaBQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pcpMXMRk; arc=none smtp.remote-ip=91.218.175.180 Received: from mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B779C606A32A for ; Fri, 20 Nov 2026 13:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B779C606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pcpMXMRk X-Envelope-To: fuse-devel@lists.linux.dev DKIM-Signature: a=rsa-sha256; bh=AFN9OOtQlK1HJO8cWelVMtGeAQ6PKLi87EwwnhaP1iY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795180281; v=1; x=1795785081; b=pcpMXMRkQ4Ns6fd064vPWWatVGroU9IVtkGO3ROe58Y6pOfgmdrRaA8URbSyfTUF5AbEgZhD i68/L46VO8eq6YVzH9zTsvTRNPM0a79tLxALqyXzHBnW3aN7CqxWw7P6596t4l+BKqmEoxYpK8c D1wn0Zhz0yPrczpYDf0gH1hM= X-Envelope-To: fuse-devel@lists.linux.dev Received: by smtp.migadu.com with ESMTPS id 1d043ee31403846b; Fri, 20 Nov 2026 13:11:20 +0000 X-Mizu-Trace-ID: 1d043ee31403846b X-Migadu-Flow: FLOW_OUT Date: Fri, 20 Nov 2026 14:11:11 +0100 From: "Pankaj Raghav (Samsung)" To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Andreas Gruenbacher , gfs2@lists.linux.dev, Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Carlos Maiolino , linux-xfs@vger.kernel.org, David Howells , Marc Dionne , linux-afs@lists.infradead.org, Miklos Szeredi , fuse-devel@lists.linux.dev, linux-block@vger.kernel.org, Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Eric Biggers , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Carlos Maiolino Subject: Re: [PATCH 02/13] xfs: Drop pointless I_DIRTY_PAGES check in xfs_can_free_cowblocks() Message-ID: References: <20261116171044.6938-1-jack@suse.cz> <20261118145941.1063127-15-jack@suse.cz> X-Mailing-List: fuse-devel@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261118145941.1063127-15-jack@suse.cz> On Wed, Nov 18, 2026 at 03:59:36PM +0100, Jan Kara wrote: > PAGECACHE_TAG_DIRTY is the authoritative source of information about any > folio being dirty in the mapping. I_DIRTY_PAGES is just an approximation > used by writeback code that can get stale under certain situations. So > just rely on the authoritative check. > > Reviewed-by: Carlos Maiolino > Signed-off-by: Jan Kara Looks good, Reviewed-by: Pankaj Raghav (Samsung) > --- > fs/xfs/xfs_reflink.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h > index 683c1841e640..1310cc9fe829 100644 > --- a/fs/xfs/xfs_reflink.h > +++ b/fs/xfs/xfs_reflink.h > @@ -17,8 +17,7 @@ xfs_can_free_cowblocks(struct xfs_inode *ip) > { > struct inode *inode = VFS_I(ip); > > - if ((inode_state_read_once(inode) & I_DIRTY_PAGES) || > - mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY) || > + if (mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY) || > mapping_tagged(inode->i_mapping, PAGECACHE_TAG_WRITEBACK) || > atomic_read(&inode->i_dio_count)) > return false; > -- > 2.53.0 >