From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Harald Freudenberger <freude@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eric Farman <farman@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Holger Dengler <dengler@linux.ibm.com>,
Alex Williamson <alex@shazbot.org>,
Vineeth Vijayan <vneethv@linux.ibm.com>,
Peter Oberparleiter <oberpar@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 04/10] s390/vfio: Allow untainted use of driver_override
Date: Fri, 20 Nov 2026 15:05:24 +0100 [thread overview]
Message-ID: <awBSb7VOGyCCBDv2@monoceros> (raw)
In-Reply-To: <8548e9504ec70bec02c6f2cebf69ea91@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3059 bytes --]
On Fri, Nov 20, 2026 at 12:58:52PM +0100, Harald Freudenberger wrote:
> On 2026-11-20 12:11, Uwe Kleine-König wrote:
> > From: Alex Williamson <alex@shazbot.org>
> >
> > The vfio_ap and vfio_ccw drivers bind devices through driver_override.
> > With the introduction of the support_driver_override flag in the core
> > driver struct, it's now required for drivers to declare themselves as
> > driver_override compatible, otherwise driver_override bindings will be
> > denied or generate a kernel taint.
> >
> > Set the support_driver_override flag on the vfio_ap and vfio_ccw driver
> > structs.
> >
> > Signed-off-by: Alex Williamson <alex@shazbot.org>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> > drivers/s390/cio/vfio_ccw_drv.c | 1 +
> > drivers/s390/crypto/vfio_ap_drv.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/s390/cio/vfio_ccw_drv.c
> > b/drivers/s390/cio/vfio_ccw_drv.c
> > index 7546bd137e4e..77765cde87f7 100644
> > --- a/drivers/s390/cio/vfio_ccw_drv.c
> > +++ b/drivers/s390/cio/vfio_ccw_drv.c
> > @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
> > .drv = {
> > .name = "vfio_ccw",
> > .owner = THIS_MODULE,
> > + .support_driver_override = true,
> > },
> > .subchannel_type = vfio_ccw_sch_ids,
> > .irq = vfio_ccw_sch_irq,
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> > b/drivers/s390/crypto/vfio_ap_drv.c
> > index 8e69ed286bb9..2d47dc643269 100644
> > --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
> > .on_config_changed = vfio_ap_on_cfg_changed,
> > .on_scan_complete = vfio_ap_on_scan_complete,
> > .ids = ap_queue_ids,
> > + .driver.support_driver_override = true,
> > };
> >
> > static void vfio_ap_matrix_dev_release(struct device *dev)
>
> Hm, honestly I don' get this...
> The driver_override is a bus thing. So the AP bus has support for
> driver_override.
Yes, and ap_device_probe() calls device_match_driver_override() which
requires .driver.support_driver_override to be true to make the override
work.
> The sysfs functions are in drivers/s390/crypto/ap_queue.c. There exist
> currently
> two drivers which shall be bound to an AP queue: vfio_ap and the default
> driver
> which is the zcrypt driver "cex4queue". It sounds like the driver needs the
> tagging about driver_override support and then similar to the vfio_ap_drv.c
> the static struct ap_driver initialization may also need a
> .driver.support_driver_override = true line.
Can you please talk in form of a patch? I have difficulties following
your words. (Hint: "the driver" is ambigous if you just talked about two
different ones. Also what is "the static struct ap_driver
initialization"?)
Alternatively something like: "I tested you changes and the xyz driver
fails to bind, this is the respective kernel output: ..." would be
welcome, too.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-20 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:11 [PATCH v2 00/10] driver core: Disable driver overriding by default Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 01/10] " Uwe Kleine-König
2026-11-20 18:59 ` Jason Gunthorpe
2026-11-20 11:11 ` [PATCH v2 02/10] PCI: Allow untainted driver_override for PCI stub drivers Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 03/10] vfio: Allow untainted use of driver_override Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 04/10] s390/vfio: " Uwe Kleine-König
2026-11-20 11:58 ` Harald Freudenberger
2026-11-20 14:05 ` Uwe Kleine-König [this message]
2026-11-20 11:11 ` [PATCH v2 05/10] uio: " Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 06/10] spi: spidev: " Uwe Kleine-König
2026-11-20 11:35 ` Mark Brown
2026-11-20 11:11 ` [PATCH v2 07/10] clk: imx: scu: " Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 08/10] remoteproc: " Uwe Kleine-König
2026-11-20 15:13 ` Mathieu Poirier
2026-11-20 11:11 ` [PATCH v2 09/10] slimbus: qcom-ngd-ctrl: " Uwe Kleine-König
2026-11-20 11:11 ` [PATCH v2 10/10] ASoC: samsung: i2s: " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awBSb7VOGyCCBDv2@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=agordeev@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex@shazbot.org \
--cc=dengler@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.