All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Jonathan Cameron <jic23@kernel.org>,
	Chris Li <sparse@chrisli.org>,
	Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
	linux-sparse@vger.kernel.org
Subject: Re: [PATCH v1 1/1] bitmap: Refactor bitmap_read() and bitmap_write() to avoid too big shift
Date: Fri, 20 Nov 2026 09:42:32 -0500	[thread overview]
Message-ID: <awBcWKvDGV8sLcGu@yury> (raw)
In-Reply-To: <awAH8F_UXdcftgV6@ashevche-desk.local>

On Fri, Nov 20, 2026 at 10:42:24AM +0200, Andy Shevchenko wrote:
> On Thu, Nov 19, 2026 at 04:22:06PM -0500, Yury Norov wrote:
> > On Thu, Nov 19, 2026 at 11:03:53PM +0200, Andy Shevchenko wrote:
> > > On Thu, Nov 19, 2026 at 03:37:33PM -0500, Yury Norov wrote:
> > > > On Thu, Nov 19, 2026 at 08:15:30PM +0100, Andy Shevchenko wrote:
> 
> ...
> 
> > > > I guess... Let's keep the patch minimal?
> > > > 
> > > > > -	mask = BITMAP_LAST_WORD_MASK(nbits);
> > > > > -	value &= mask;
> > > > > -	offset = start % BITS_PER_LONG;
> > > > > -	space = BITS_PER_LONG - offset;
> > > > > -	fit = space >= nbits;
> > > > 
> > > > I don't like this 'fit' thing, and would like to drop it. But
> > > > let's find a better motivation to do that?
> > > 
> > > Why? The fit keeps the check I want to refactor, since it makes it twice
> > > the code with that ternary looks ugly and unreadable. This is exactly the
> > > chance to kill two birds with one stone.
> > 
> > That's what I meant regarding the motivational part and minimizing the
> > patch.
> 
> OK. So refactoring bitmap_write() to make it look like bitmap_read() can be
> done after your nice below patch.

Sure, I'll take the patch with the tags suggested. But you're very
welcome to continue optimizing it - my gut feeling says we can
squeeze a few more percents out of it with just a careful refactoring.

> > From dfac9a524aa8658fe63c03804cca9f0980b58ef7 Mon Sep 17 00:00:00 2001
> > From: Yury Norov <ynorov@nvidia.com>
> > Date: Thu, 19 Nov 2026 16:03:21 -0500
> > Subject: [PATCH] bitmap: Rephrase read and write bounds checks for sparse
> > 
> > Reword bitmap_read/write() conditionals such that it improves on code
> > generation and performance.
> > 
> > Tested with minimal x86-64 kernels with GCC 15.2 and CONFIG_TEST_BITMAP=y.
> > Run 400 fresh boots per kernel under virtme/KVM on a Core Ultra 7 268V,
> > using one vCPU and 256 MiB RAM.
> > 
> >           Before, us      After, us   Change, us    t         p
> >   Read    277.00 (6.99)   265.33 (17.05)   -4.21%   -12.695   2.97e-31
> >   Write   496.96 (14.38)  488.56 (10.41)   -1.69%    -9.615   8.03e-20
> > 
> > Bloat-o-meter reports 60 fewer function bytes in vmlinux and in
> > lib/test_bitmap.o:
> > 
> >   Function                       Before  After  Delta
> >   test_bitmap_read_perf             234    227     -7
> >   test_bitmap_write_perf            298    286    -12
> >   test_bitmap_write_helper          880    872     -8
> >   test_bitmap_read_write            800    767    -33
> > 
> > It also fixes the following sparse errors:
> > 
> >   include/linux/bitmap.h:854:55: warning: shift too big (64) for type unsigned long
> >   include/linux/bitmap.h:854:55: warning: shift too big (64) for type unsigned long
> 
> Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Link: https://lore.kernel.org/r/20261119191530.1716850-1-andriy.shevchenko@linux.intel.com
> 
> Should be Closes: tag.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 

      parent reply	other threads:[~2026-11-20 14:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 19:15 [PATCH v1 1/1] bitmap: Refactor bitmap_read() and bitmap_write() to avoid too big shift Andy Shevchenko
2026-11-19 20:37 ` Yury Norov
2026-11-19 21:03   ` Andy Shevchenko
2026-11-19 21:22     ` Yury Norov
2026-11-20  8:42       ` Andy Shevchenko
2026-11-20  8:51         ` Andy Shevchenko
2026-11-20 14:42         ` Yury Norov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBcWKvDGV8sLcGu@yury \
    --to=ynorov@nvidia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luc.vanoostenryck@gmail.com \
    --cc=sparse@chrisli.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.