From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E1860A261E for ; Fri, 20 Nov 2026 17:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=bWejykpF Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 590E6112BF2; Fri, 20 Nov 2026 17:30:43 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2D45112C03 for ; Fri, 20 Nov 2026 17:30:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1795195837; x=1826731837; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Trxj4pq68fR3O6qh6qJSG5FD2indJVbEFsDJ05bwrcU=; b=bWejykpFEZqyon7KLJOucDBzh8GyASh/PcAphiL00KgmZ57m1WQeudPa WDO8Y2QRaEbTZMgbo5Ii4kjaXm42KPTKHKKK+JgdcnnURpAytqDAP3EvK vQAJQfXW8j+70WIvpMsW1+rjSQDq+/cRmjR1cSTMG3DNrSNmw1p2n3D1d hFdPowEz5+ZMdwdxZTDXCA7APk6HtmdAShdge4Y961YH+md0GxTPavYoT lF/DI0OkhSihl95ugBledXmcZ954tjxGDgPSLwq/eg8RZ/azGFB2cnEY7 6nM71151UGk0Rg6AOK86PiQP93y5PxiwyxioPZTzlknu5eXt8F6MLIFAQ Q==; X-CSE-ConnectionGUID: 7gqrCKfyQmGB+NMfMeM+3A== X-CSE-MsgGUID: cog51L8BS5+fSZrYOdFB3w== X-IronPort-AV: E=McAfee;i="6800,10657,11972"; a="3994281" X-IronPort-AV: E=Sophos;i="6.27,223,1787036400"; d="scan'208";a="3994281" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2026 09:30:26 -0800 X-CSE-ConnectionGUID: CsMaA9HRQiKYukNRXCefCQ== X-CSE-MsgGUID: YPeEZgWjQsCp04k1vCuLTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,223,1787036400"; d="scan'208";a="12577352" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.66]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2026 09:30:24 -0800 Date: Fri, 20 Nov 2026 19:30:21 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/i915/gvt: Descend to GVT Makefile through kbuild, not include Message-ID: References: <20261120155734.259742-1-jani.nikula@intel.com> <20261120155734.259742-2-jani.nikula@intel.com> <40de34776e441b082b4dfa5e1d76ef933ea303e7@intel.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <40de34776e441b082b4dfa5e1d76ef933ea303e7@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Intel-gfx" X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Fri, Nov 20, 2026 at 07:04:22PM +0200, Jani Nikula wrote: > On Fri, 20 Nov 2026, Ville Syrjälä wrote: > > On Fri, Nov 20, 2026 at 05:57:34PM +0200, Jani Nikula wrote: > >> Treat the gvt/ subdirectory and Makefile like a regular kernel driver > >> directory, and descend to it through kbuild, not Makefile include. > >> > >> The main change is that the resulting kvmgt.ko is also placed in the > >> gvt/ subdirectory in the build directory. > > > > Does this also change where the module gets installed finally? > > Probably. If anyone depends on the exact location, they'll be hosed. I suspect this thing is niche enough that we can go for it without fear of drowning in bug reports afterwards. Should highlight the change in installation directory in the commit message regardless. With that, the series is Reviewed-by: Ville Syrjälä > > BR, > Jani. > > > > > >> > >> Signed-off-by: Jani Nikula > >> --- > >> drivers/gpu/drm/i915/Makefile | 4 +-- > >> drivers/gpu/drm/i915/gvt/Makefile | 48 ++++++++++++++++--------------- > >> 2 files changed, 27 insertions(+), 25 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > >> index d4e7764621e1..ba7eecfffdca 100644 > >> --- a/drivers/gpu/drm/i915/Makefile > >> +++ b/drivers/gpu/drm/i915/Makefile > >> @@ -433,10 +433,10 @@ i915-y += \ > >> i915-$(CONFIG_DRM_I915_GVT) += \ > >> intel_gvt.o \ > >> intel_gvt_mmio_table.o > >> -include $(src)/gvt/Makefile > >> > >> obj-$(CONFIG_DRM_I915) += i915.o > >> -obj-$(CONFIG_DRM_I915_GVT_KVMGT) += kvmgt.o > >> + > >> +obj-$(CONFIG_DRM_I915_GVT_KVMGT) += gvt/ > >> > >> # kernel-doc test > >> # > >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile > >> index 47f4f6f43c15..dfbf813f672c 100644 > >> --- a/drivers/gpu/drm/i915/gvt/Makefile > >> +++ b/drivers/gpu/drm/i915/gvt/Makefile > >> @@ -1,25 +1,27 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> > >> -kvmgt-$(CONFIG_DRM_I915_GVT) += \ > >> - gvt/aperture_gm.o \ > >> - gvt/cfg_space.o \ > >> - gvt/cmd_parser.o \ > >> - gvt/debugfs.o \ > >> - gvt/display.o \ > >> - gvt/dmabuf.o \ > >> - gvt/edid.o \ > >> - gvt/execlist.o \ > >> - gvt/fb_decoder.o \ > >> - gvt/firmware.o \ > >> - gvt/gtt.o \ > >> - gvt/handlers.o \ > >> - gvt/interrupt.o \ > >> - gvt/kvmgt_module.o \ > >> - gvt/mmio.o \ > >> - gvt/mmio_context.o \ > >> - gvt/opregion.o \ > >> - gvt/page_track.o \ > >> - gvt/sched_policy.o \ > >> - gvt/scheduler.o \ > >> - gvt/trace_points.o \ > >> - gvt/vgpu.o > >> +kvmgt-y += \ > >> + aperture_gm.o \ > >> + cfg_space.o \ > >> + cmd_parser.o \ > >> + debugfs.o \ > >> + display.o \ > >> + dmabuf.o \ > >> + edid.o \ > >> + execlist.o \ > >> + fb_decoder.o \ > >> + firmware.o \ > >> + gtt.o \ > >> + handlers.o \ > >> + interrupt.o \ > >> + kvmgt_module.o \ > >> + mmio.o \ > >> + mmio_context.o \ > >> + opregion.o \ > >> + page_track.o \ > >> + sched_policy.o \ > >> + scheduler.o \ > >> + trace_points.o \ > >> + vgpu.o > >> + > >> +obj-$(CONFIG_DRM_I915_GVT_KVMGT) += kvmgt.o > >> -- > >> 2.47.3 > > -- > Jani Nikula, Intel -- Ville Syrjälä Intel