From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.108 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795276171; b=JgA6Iv6MEC8ax3GnXiQo38ZQhXnQKOLdCrJ2n+1vPqPMVnAgNTpMgW73/C1AEM2OyUs6 J07ywgZiox2gzyZgXnPRnN7D4ZKUO4RKuC0lV0T1fQ47a0gyubncKWrBpuQAIoxAjUjcB +kY4k56AVgTOuW5wUHxkpB9VsS25ifGL4BMdKssO9WBffvpi/P7XUwUnTGmZz0BtmUFYH GukXE1zNCQg5KjBSPK1ghrE4DPuM8UFZXwauNlkJjZqFl1n6bB8wc4pfz7h3Teh6HBycK 7qAYvKFn7ezJ7rlRVsfCIicycJEb/LvxQLf5U0Nr+z1DmGQXYTt01jiGqkr0kP89wiA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795276171; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=0YZb9vl8h3h2s9tCOBwKg7YDMBx7IJ0VENcqcFynRLs=; b=J6tSzRTdiodSq3FUKik2sOKxsyN5Gj/6Hlg62XDq5oftox7BDTdxOBKy2e/nVwfgwI8H XigOEH9tGtZCMkmnQBYI/5gWn0jubI33p0MeAn8k6fjqH94gNI6YYQQi1M7YenRTXvmD4 t9Rggm0XrwKKlf9sZ8T8eVzvOXhAwBgYs+rKyP9u6gRefkjk9kbeW/6PBhVrRkez1aMgn oDok1A0fI+IXZFWd0T4yqcMruamLneNQYos1ROhxUXz/8nlB/pRFD1RxFvXM/Rtf47G2I 3dyu63iUQ0YCKaQTiCHCJQvIj9bXGqyN+jHN58OZD8DqP3ku6973nQF6GGV4YO7/KNg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=w2pR9wVL; arc=none smtp.remote-ip=95.215.58.108 Received: from mta1.migadu.com (out-108.mta1.migadu.com [95.215.58.108]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920E6606A320 for ; Sat, 21 Nov 2026 15:49:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 920E6606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=w2pR9wVL X-Envelope-To: kvm@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=87tG5wTJqa8KKU5Vw1XcYaRFIKmNyRkg1DQIqfjExPM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795276168; v=1; x=1795880968; b=w2pR9wVLVUEmNc/0xvbGAfErcyc7Q064cNe2Qb0JIQ8E3trfNPtCcUuXokXWWavloaXnxfRU Y3drjX4obip27K21vOfT/kadJGIDVNpdHfim3KoKCHqoBpoWUFI7VggUrR3pFshFi6VvgDpAEym dXAczSt5dyLO0XQ6IT/CY/Lk= X-Envelope-To: kvm@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 1cf4a9c89376da71; Sat, 21 Nov 2026 15:49:28 +0000 X-Mizu-Trace-ID: 1cf4a9c89376da71 X-Migadu-Flow: FLOW_OUT Date: Sat, 21 Nov 2026 16:48:51 +0100 From: Andrew Jones To: Gong Shuai Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Tomasz Jeznach , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Paolo Bonzini , Sean Christopherson , Jason Gunthorpe , Kevin Tian , Andrew Jones , Fangyu Yu , Tan Chi , Wu Fei , Zhao Qingye Subject: Re: [RFC PATCH v3 09/10] iommu/riscv: Add riscv_iommu_attach_dev_nested Message-ID: References: <20261119132744.396426-1-gong.shuai@sanechips.com.cn> <20261119132744.396426-10-gong.shuai@sanechips.com.cn> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261119132744.396426-10-gong.shuai@sanechips.com.cn> On Thu, Nov 19, 2026 at 09:27:43PM +0800, Gong Shuai wrote: ... > + if (riscv_iommu_bond_link(s2_parent, dev, nested_domain->viommu->gscid)) > + return -ENOMEM; > + > + riscv_iommu_iodir_update(iommu, dev, &dc); > + riscv_iommu_bond_unlink(info->domain, dev); > + info->domain = s2_parent; > + When moving between the S2 parent and a nested domain on it, the parent briefly has two bonds for dev. bond_link() puts the new bond after the first bond with the same GSCID, which may come before dev's old bond, and since it's then dev's first bond, bond_unlink() removes it. dev is left bonded with its old GSCID, so its new GSCID misses invalidations once no other device's bond has it. Passing the old domain to bond_unlink(), like I do in [1] for a different reason, would let it remove the bond matching both dev and old's GSCID. [1] https://lore.kernel.org/all/20260928143113.49838-12-andrew.jones@oss.qualcomm.com/ Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73BE606A320 for ; Sat, 21 Nov 2026 15:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TMXBnkqQ; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=w2pR9wVL DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=7BzoeRbTp4DikqzL2oi1ENfdL6aVE5dmYH5PSESIP4E=; b=TMXBnkqQ5XgZYXUFVkJnWOQI4Z rRTLZSio1BTtmvwp9YcsMpI2RxhPQZbyuah/NZ1IH4wbS4VhAYp/bV40RSRmR3vUH8GhTatEhTGbM M+yknj5j/tRGYkPS+5ZK0HCfUgIaEGRznGKGtXNoi1M2GEYIZmB42xVxfa92eu1suhRS3yUTVOa7c EYxPyqrzD8nOYPDnguZ26HKh4kN2qqTrNtnBp2yu1KPsmbv+yybc6YEEC9cNhwCpZFN5rNUAP6XOx cOusM9FA3joNC0D18+e7Ttgt4qqchci4UoeuWtf2igp/SXX9KlI2KtcmUaPXHGp0m8wvYsi4R8Foy 6U01GILw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUnLK-0000000HOou-2HwA; Sat, 21 Nov 2026 15:49:34 +0000 Received: from out-83.mta0.migadu.com ([2001:41d0:1004:224b::53] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUnLH-0000000HOoE-0gBn for kvm-riscv@lists.infradead.org; Sat, 21 Nov 2026 15:49:33 +0000 X-Envelope-To: kvm-riscv@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=87tG5wTJqa8KKU5Vw1XcYaRFIKmNyRkg1DQIqfjExPM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795276168; v=1; x=1795880968; b=w2pR9wVLVUEmNc/0xvbGAfErcyc7Q064cNe2Qb0JIQ8E3trfNPtCcUuXokXWWavloaXnxfRU Y3drjX4obip27K21vOfT/kadJGIDVNpdHfim3KoKCHqoBpoWUFI7VggUrR3pFshFi6VvgDpAEym dXAczSt5dyLO0XQ6IT/CY/Lk= X-Envelope-To: kvm-riscv@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 1cf4a9c89376da71; Sat, 21 Nov 2026 15:49:28 +0000 X-Mizu-Trace-ID: 1cf4a9c89376da71 X-Migadu-Flow: FLOW_OUT Date: Sat, 21 Nov 2026 16:48:51 +0100 From: Andrew Jones To: Gong Shuai Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Tomasz Jeznach , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Paolo Bonzini , Sean Christopherson , Jason Gunthorpe , Kevin Tian , Andrew Jones , Fangyu Yu , Tan Chi , Wu Fei , Zhao Qingye Subject: Re: [RFC PATCH v3 09/10] iommu/riscv: Add riscv_iommu_attach_dev_nested Message-ID: References: <20261119132744.396426-1-gong.shuai@sanechips.com.cn> <20261119132744.396426-10-gong.shuai@sanechips.com.cn> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261119132744.396426-10-gong.shuai@sanechips.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261121_074932_184024_83E50C83 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 19, 2026 at 09:27:43PM +0800, Gong Shuai wrote: ... > + if (riscv_iommu_bond_link(s2_parent, dev, nested_domain->viommu->gscid)) > + return -ENOMEM; > + > + riscv_iommu_iodir_update(iommu, dev, &dc); > + riscv_iommu_bond_unlink(info->domain, dev); > + info->domain = s2_parent; > + When moving between the S2 parent and a nested domain on it, the parent briefly has two bonds for dev. bond_link() puts the new bond after the first bond with the same GSCID, which may come before dev's old bond, and since it's then dev's first bond, bond_unlink() removes it. dev is left bonded with its old GSCID, so its new GSCID misses invalidations once no other device's bond has it. Passing the old domain to bond_unlink(), like I do in [1] for a different reason, would let it remove the bond matching both dev and old's GSCID. [1] https://lore.kernel.org/all/20260928143113.49838-12-andrew.jones@oss.qualcomm.com/ Thanks, drew -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CBEF606A337 for ; Sat, 21 Nov 2026 15:49:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Ob57u3g5; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=w2pR9wVL DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=WFNronv3oGXJTGyrXdWlCS+jgKNnyzKAlfYFjsOOpqI=; b=Ob57u3g5AK/Pg0YJz7u46xWLXu fu4B7qzb97G3oxcgK/VWlPKABBiezMaBcFtcAS2YjAiJcGBSOEP4MDIz8RiCUZ56gQGcgrGoQsGWP V/xbDLzBlWlMMhv031dCHfF98BEllewBxE9AwLogMKLoDwX6iXXaZ5IO1vIGzDtj6YzCUcQsSbv18 quYZYAoGoGY0IbrzMzFKFtlI4XAkb/DIfH4gHbCPKT9KyEEcA0IIj5vWucKmmAEUJMJ7SCC/bflOZ 9ZJEJ0UJKOGHT4ZXJ2DLLYG3hEkqJdKMTN+zqabfP9kPbdEJ/RFTwlEJ/IAQvm2cKhfoHLhO/AR8W A4RUbfLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUnLK-0000000HOoq-1shX; Sat, 21 Nov 2026 15:49:34 +0000 Received: from out-84.mta0.migadu.com ([2001:41d0:1004:224b::54] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUnLH-0000000HOoF-0g8J for linux-riscv@lists.infradead.org; Sat, 21 Nov 2026 15:49:33 +0000 X-Envelope-To: linux-riscv@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=87tG5wTJqa8KKU5Vw1XcYaRFIKmNyRkg1DQIqfjExPM=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795276168; v=1; x=1795880968; b=w2pR9wVLVUEmNc/0xvbGAfErcyc7Q064cNe2Qb0JIQ8E3trfNPtCcUuXokXWWavloaXnxfRU Y3drjX4obip27K21vOfT/kadJGIDVNpdHfim3KoKCHqoBpoWUFI7VggUrR3pFshFi6VvgDpAEym dXAczSt5dyLO0XQ6IT/CY/Lk= X-Envelope-To: linux-riscv@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 1cf4a9c89376da71; Sat, 21 Nov 2026 15:49:28 +0000 X-Mizu-Trace-ID: 1cf4a9c89376da71 X-Migadu-Flow: FLOW_OUT Date: Sat, 21 Nov 2026 16:48:51 +0100 From: Andrew Jones To: Gong Shuai Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Tomasz Jeznach , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Paolo Bonzini , Sean Christopherson , Jason Gunthorpe , Kevin Tian , Andrew Jones , Fangyu Yu , Tan Chi , Wu Fei , Zhao Qingye Subject: Re: [RFC PATCH v3 09/10] iommu/riscv: Add riscv_iommu_attach_dev_nested Message-ID: References: <20261119132744.396426-1-gong.shuai@sanechips.com.cn> <20261119132744.396426-10-gong.shuai@sanechips.com.cn> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261119132744.396426-10-gong.shuai@sanechips.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261121_074932_183673_FE4D12D4 X-CRM114-Status: UNSURE ( 8.53 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 19, 2026 at 09:27:43PM +0800, Gong Shuai wrote: ... > + if (riscv_iommu_bond_link(s2_parent, dev, nested_domain->viommu->gscid)) > + return -ENOMEM; > + > + riscv_iommu_iodir_update(iommu, dev, &dc); > + riscv_iommu_bond_unlink(info->domain, dev); > + info->domain = s2_parent; > + When moving between the S2 parent and a nested domain on it, the parent briefly has two bonds for dev. bond_link() puts the new bond after the first bond with the same GSCID, which may come before dev's old bond, and since it's then dev's first bond, bond_unlink() removes it. dev is left bonded with its old GSCID, so its new GSCID misses invalidations once no other device's bond has it. Passing the old domain to bond_unlink(), like I do in [1] for a different reason, would let it remove the bond matching both dev and old's GSCID. [1] https://lore.kernel.org/all/20260928143113.49838-12-andrew.jones@oss.qualcomm.com/ Thanks, drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv