All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Caione <ccaione@baylibre.com>
To: Steffen Dirkwinkel <lists@steffen.cc>
Cc: GSS_MTK_Uboot_upstream <GSS_MTK_Uboot_upstream@mediatek.com>,
	 u-boot@lists.u-boot-project.org, Tom Rini <trini@konsulko.com>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	 Weijie Gao <weijie.gao@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Igor Belwon <igor.belwon@mentallysanemainliners.org>,
	David Lechner <dlechner@baylibre.com>,
	 Julien Stephan <jstephan@baylibre.com>,
	Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>,
	 Chris Chen <chris-qj.chen@mediatek.com>,
	Julien Masson <jmasson@baylibre.com>,
	 Johan Jonker <jbx6244@gmail.com>
Subject: Re: [PATCH v3 2/2] arm: mediatek: run board_init_f() with the caches on
Date: Sat, 21 Nov 2026 17:30:55 +0100	[thread overview]
Message-ID: <awHG70eD8qDwGc7L@macbook> (raw)
In-Reply-To: <20261120-std-upstream-mt8188-spl-caches-v3-2-b5ab70d56006@beckhoff.com>

On Fri, Nov 20, 2026 at 17:29:19 +0100, Steffen Dirkwinkel wrote:
> From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
> 
> Device tree walks and other setup is very slow without caches, so turn
> them on before relocation.
> 
> On an MT8370 module, from bootstage marks before each initcall, two
> boots each:
> 
>   step                            caches off        caches on
>   initf_dm                        349.8 / 349.7     4.6 / 4.6 ms
>   serial_init                     204.7 / 204.7     3.0 / 3.0 ms
>   dram_init                       162.2 / 162.1     2.3 / 2.3 ms
>   relocate_code                   22.0 / 22.0       0.4 / 0.4 ms
>   board_init_f() to main_loop()   819 / 819         87 / 87 ms
> 
> and from the serial console, after power-on (includes 5s debug usb wait):
> 
>   U-Boot banner                   7336 / 7335 ms    6772 / 6775 ms
> 
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com>
> ---
>  arch/arm/include/asm/arch-mediatek/misc.h |  1 +
>  arch/arm/mach-mediatek/Kconfig            | 10 +++++++++-
>  arch/arm/mach-mediatek/cpu.c              |  6 ++++++
>  arch/arm/mach-mediatek/early_caches.c     | 10 ++++++++++
>  4 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-mediatek/misc.h b/arch/arm/include/asm/arch-mediatek/misc.h
> index dd248d222b97..517fbe7842ff 100644
> --- a/arch/arm/include/asm/arch-mediatek/misc.h
> +++ b/arch/arm/include/asm/arch-mediatek/misc.h
> @@ -15,5 +15,6 @@
>  #define APSW_VER		0x0c
>  
>  void mtk_early_enable_caches(void);
> +void mtk_early_disable_caches(void);

nit: same as before these functions are really only dealing with
dcache, not caches in general so I think a more proper name would be
mtk_early_disable_dcache

Otherwise:

Reviewed-by: Carlo Caione <ccaione@baylibre.com>


--
Carlo Caione

      reply	other threads:[~2026-11-21 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:29 [PATCH v3 0/2] arm: mediatek: run SPL and pre-relocation U-Boot with caches Steffen Dirkwinkel
2026-11-20 16:29 ` [PATCH v3 1/2] arm: mediatek: enable the caches in SPL Steffen Dirkwinkel
2026-11-21 16:29   ` Carlo Caione
2026-11-20 16:29 ` [PATCH v3 2/2] arm: mediatek: run board_init_f() with the caches on Steffen Dirkwinkel
2026-11-21 16:30   ` Carlo Caione [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awHG70eD8qDwGc7L@macbook \
    --to=ccaione@baylibre.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=chris-qj.chen@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=dlechner@baylibre.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jbx6244@gmail.com \
    --cc=jmasson@baylibre.com \
    --cc=jstephan@baylibre.com \
    --cc=lists@steffen.cc \
    --cc=ryder.lee@mediatek.com \
    --cc=s.dirkwinkel@beckhoff.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=weijie.gao@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.