From: David Hildenbrand <david@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Rik van Riel <riel@surriel.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Harry Yoo <harry.yoo@oracle.com>
Subject: Re: [PATCH 2/3] selftests/mm: put general ksm operation into vm_util
Date: Thu, 17 Jul 2025 13:57:33 +0200 [thread overview]
Message-ID: <b0213e78-d985-4a31-acce-e83189bc276c@redhat.com> (raw)
In-Reply-To: <20250717033031.rts7keqjrt6jc77t@master>
On 17.07.25 05:30, Wei Yang wrote:
> On Thu, Jul 17, 2025 at 02:45:04AM +0000, Wei Yang wrote:
> [...]
>>
>> Looks reasonable, will remove it.
>>
>> So how about leave three helpers:
>>
>> ksm_merge()
>> ksm_start()
>> ksm_stop_and_unmerge()
>>
>> Would this be better?
>
> Or maybe we just export ksm_merge() and ksm_unmerge(). Leave ksm_start() as an
> internal function, since only ksm_merge() use it.
Either that or start/stop. Whatever you think is best.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-17 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 8:27 [PATCH 0/3] selftests/mm: assert rmap behave as expected Wei Yang
2025-07-16 8:27 ` [PATCH 1/3] selftests/mm: check a valid fd with negative value Wei Yang
2025-07-16 8:52 ` David Hildenbrand
2025-07-17 1:18 ` Wei Yang
2025-07-17 8:27 ` David Hildenbrand
2025-07-16 8:27 ` [PATCH 2/3] selftests/mm: put general ksm operation into vm_util Wei Yang
2025-07-16 9:20 ` David Hildenbrand
2025-07-17 2:45 ` Wei Yang
2025-07-17 3:30 ` Wei Yang
2025-07-17 11:57 ` David Hildenbrand [this message]
2025-07-17 11:56 ` David Hildenbrand
2025-07-16 8:27 ` [PATCH 3/3] selftests/mm: assert rmap behave as expected Wei Yang
2025-07-16 13:34 ` David Hildenbrand
2025-07-17 3:17 ` Wei Yang
2025-07-25 2:16 ` Wei Yang
2025-07-25 13:34 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0213e78-d985-4a31-acce-e83189bc276c@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harry.yoo@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=richard.weiyang@gmail.com \
--cc=riel@surriel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.