Re: [PATCH 10/41] backends/cryptodev-lkcf: skip cleanup when not initialized

[zhenwei pi <zhenwei.pi@linux.dev>]

On 4/28/26 03:42, Marc-André Lureau wrote:
> cryptodev_lkcf_cleanup() locks a mutex that is only initialized
> during the init vfunc (called at realize time). When the backend
> is destroyed without ever being realized, the mutex is uninitialized
> and the lock aborts.
> 
> Return early from cleanup when the backend was never started.
> 
> Note: it looks like cryptodev init/cleanup callbacks should rather be
> regular complete/finalize overrides (calling the parent method).
> 
> Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   backends/cryptodev-lkcf.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c
> index 40c7bd3c5a0..74db03fe96b 100644
> --- a/backends/cryptodev-lkcf.c
> +++ b/backends/cryptodev-lkcf.c
> @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *backend, Error **errp)
>       CryptoDevBackendClient *cc;
>       CryptoDevLKCFTask *task, *next;
>   
> +    if (!lkcf->running) {
> +        return;
> +    }
> +
>       qemu_mutex_lock(&lkcf->mutex);
>       lkcf->running = false;
>       qemu_mutex_unlock(&lkcf->mutex);
> 

'lkcf->running' is used for synchronization between main thread and LKCF 
works, 'backend->ready' indicates the status of cryptodev, so I prefer 
the following code instead:

if (!cryptodev_backend_is_ready(backend)) {
     return;
}