From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E76C433DB for ; Mon, 15 Mar 2021 09:21:08 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id ABA5F64E33 for ; Mon, 15 Mar 2021 09:21:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABA5F64E33 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 436F74B48E; Mon, 15 Mar 2021 05:21:07 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JwDhmSPKc8Ut; Mon, 15 Mar 2021 05:21:05 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3CCAA4B431; Mon, 15 Mar 2021 05:21:05 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B4CAC4B407 for ; Mon, 15 Mar 2021 05:21:04 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jwkZ8rg0j+SL for ; Mon, 15 Mar 2021 05:21:03 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 7CE104B307 for ; Mon, 15 Mar 2021 05:21:03 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADB7264E12; Mon, 15 Mar 2021 09:21:00 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lLjPG-001cIb-KN; Mon, 15 Mar 2021 09:20:58 +0000 MIME-Version: 1.0 Date: Mon, 15 Mar 2021 09:20:58 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [PATCH v4 5/6] KVM: arm64: GICv4.1: Restore VLPI pending state to physical side In-Reply-To: <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> References: <20210313083900.234-1-lushenming@huawei.com> <20210313083900.234-6-lushenming@huawei.com> <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Lorenzo Pieralisi , kvm@vger.kernel.org, Cornelia Huck , linux-kernel@vger.kernel.org, Alex Williamson , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMS0wMy0xNSAwOToxMSwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gT24gMjAyMS8zLzE1IDE2 OjMwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIDIwMjEtMDMtMTMgMDg6MzgsIFNoZW5taW5n IEx1IHdyb3RlOgo+Pj4gRnJvbTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4+ PiAKPj4+IFdoZW4gc2V0dGluZyB0aGUgZm9yd2FyZGluZyBwYXRoIG9mIGEgVkxQSSAoc3dpdGNo IHRvIHRoZSBIVyBtb2RlKSwKPj4+IHdlIGNhbiBhbHNvIHRyYW5zZmVyIHRoZSBwZW5kaW5nIHN0 YXRlIGZyb20gaXJxLT5wZW5kaW5nX2xhdGNoIHRvCj4+PiBWUFQgKGVzcGVjaWFsbHkgaW4gbWln cmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMgYXJlIAo+Pj4gcmVzdG9yZWQKPj4+ IGludG8ga3Zt4oCZcyB2Z2ljIGZpcnN0KS4gQW5kIHdlIGN1cnJlbnRseSBzZW5kICJJTlQrVlNZ TkMiIHRvIHRyaWdnZXIKPj4+IGEgVkxQSSB0byBwZW5kaW5nLgo+Pj4gCj4+PiBTaWduZWQtb2Zm LWJ5OiBaZW5naHVpIFl1IDx5dXplbmdodWlAaHVhd2VpLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6 IFNoZW5taW5nIEx1IDxsdXNoZW5taW5nQGh1YXdlaS5jb20+Cj4+PiAtLS0KPj4+IMKgYXJjaC9h cm02NC9rdm0vdmdpYy92Z2ljLXY0LmMgfCAxOCArKysrKysrKysrKysrKysrKysKPj4+IMKgMSBm aWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKPj4+IAo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gv YXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIAo+Pj4gYi9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMt djQuYwo+Pj4gaW5kZXggYWMwMjliYTNkMzM3Li4zYjgyYWI4MGMyZjMgMTAwNjQ0Cj4+PiAtLS0g YS9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMtdjQuYwo+Pj4gKysrIGIvYXJjaC9hcm02NC9rdm0v dmdpYy92Z2ljLXY0LmMKPj4+IEBAIC00NDksNiArNDQ5LDI0IEBAIGludCBrdm1fdmdpY192NF9z ZXRfZm9yd2FyZGluZyhzdHJ1Y3Qga3ZtICprdm0sIAo+Pj4gaW50IHZpcnEsCj4+PiDCoMKgwqDC oCBpcnEtPmhvc3RfaXJxwqDCoMKgID0gdmlycTsKPj4+IMKgwqDCoMKgIGF0b21pY19pbmMoJm1h cC52cGUtPnZscGlfY291bnQpOwo+Pj4gCj4+PiArwqDCoMKgIC8qIFRyYW5zZmVyIHBlbmRpbmcg c3RhdGUgKi8KPj4+ICvCoMKgwqAgaWYgKGlycS0+cGVuZGluZ19sYXRjaCkgewo+Pj4gK8KgwqDC oMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+PiArCj4+PiArwqDCoMKgwqDCoMKgwqAg cmV0ID0gaXJxX3NldF9pcnFjaGlwX3N0YXRlKGlycS0+aG9zdF9pcnEsCj4+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBJUlFDSElQX1NUQVRFX1BFTkRJ TkcsCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBp cnEtPnBlbmRpbmdfbGF0Y2gpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIFdBUk5fUkFURUxJTUlUKHJl dCwgIklSUSAlZCIsIGlycS0+aG9zdF9pcnEpOwo+Pj4gKwo+Pj4gK8KgwqDCoMKgwqDCoMKgIC8q Cj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIENsZWFyIHBlbmRpbmdfbGF0Y2ggYW5kIGNvbW11bmlj YXRlIHRoaXMgc3RhdGUKPj4+ICvCoMKgwqDCoMKgwqDCoMKgICogY2hhbmdlIHZpYSB2Z2ljX3F1 ZXVlX2lycV91bmxvY2suCj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoMKgwqDC oMKgIHJhd19zcGluX2xvY2tfaXJxc2F2ZSgmaXJxLT5pcnFfbG9jaywgZmxhZ3MpOwo+Pj4gK8Kg wqDCoMKgwqDCoMKgIGlycS0+cGVuZGluZ19sYXRjaCA9IGZhbHNlOwo+Pj4gK8KgwqDCoMKgwqDC oMKgIHZnaWNfcXVldWVfaXJxX3VubG9jayhrdm0sIGlycSwgZmxhZ3MpOwo+Pj4gK8KgwqDCoCB9 Cj4+PiArCj4+PiDCoG91dDoKPj4+IMKgwqDCoMKgIG11dGV4X3VubG9jaygmaXRzLT5pdHNfbG9j ayk7Cj4+PiDCoMKgwqDCoCByZXR1cm4gcmV0Owo+PiAKPj4gVGhlIHJlYWQgc2lkZSBvZiB0aGUg cGVuZGluZyBzdGF0ZSBpc24ndCBsb2NrZWQsIGJ1dCB0aGUgd3JpdGUgc2lkZSAKPj4gaXMuCj4+ IEknZCByYXRoZXIgeW91IGxvY2sgdGhlIHdob2xlIHNlcXVlbmNlIGZvciBwZWFjZSBvZiBtaW5k Lgo+IAo+IERpZCB5b3UgbWVhbiB0byBsb2NrIGJlZm9yZSBlbWl0dGluZyB0aGUgbWFwcGluZyBy ZXF1ZXN0LCBPciBqdXN0IAo+IGJlZm9yZSByZWFkaW5nCj4gdGhlIHBlbmRpbmcgc3RhdGU/CgpK dXN0IGJlZm9yZSByZWFkaW5nIHRoZSBwZW5kaW5nIHN0YXRlLCBzbyB0aGF0IHdlIGNhbid0IGdl dCBhIGNvbmN1cnJlbnQKbW9kaWZpY2F0aW9uIG9mIHRoYXQgc3RhdGUgd2hpbGUgd2UgbWFrZSB0 aGUgaW50ZXJydXB0IHBlbmRpbmcgaW4gdGhlIApWUFQKYW5kIGNsZWFyaW5nIGl0IGluIHRoZSBl bXVsYXRpb24uCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQg anVzdCBzbWVsbHMgZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEu ZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJt Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA35C433E0 for ; Mon, 15 Mar 2021 09:22:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C943C64E31 for ; Mon, 15 Mar 2021 09:22:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C943C64E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n+amDZlEN2e9MBxshYN/NdwxA72L/5TRNmhNO6EWjys=; b=hc/OTc5MeHk4E+ZgjJ7xA/DZc WsH39fvkoGhnk5+AABNoFX3jtQFk1km8enjEa2npn7RCrdJLSr+Y/VA4io+XMnvgWqZEI15y5L6cm Mkf4XsaHMR9+vqRDohVmMpyvM1m7eItG/BUiQsah6ToEBBfGKS4JBdQXhDw7f7Ki0UvB/T2tcpa3I /zCpYExDITPSZcx44vu3B7T+Ql3JV482pKpLrZSpj5RfEUXF02/obd2Z1GiDwVDBNJQS17ed9rIM2 2SaQqq2NjMHrSXfz6/XIAs4/RoYRDlHpc+4+1rIV9v4iLKdJUEk6W+m/Qm+LAu5LCkcgsDRfy+O9t p3EwHUoIw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lLjPU-00FMj7-1e; Mon, 15 Mar 2021 09:21:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLjPK-00FMiA-CH for linux-arm-kernel@lists.infradead.org; Mon, 15 Mar 2021 09:21:04 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADB7264E12; Mon, 15 Mar 2021 09:21:00 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lLjPG-001cIb-KN; Mon, 15 Mar 2021 09:20:58 +0000 MIME-Version: 1.0 Date: Mon, 15 Mar 2021 09:20:58 +0000 From: Marc Zyngier To: Shenming Lu Cc: Eric Auger , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Williamson , Cornelia Huck , Lorenzo Pieralisi , wanghaibin.wang@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v4 5/6] KVM: arm64: GICv4.1: Restore VLPI pending state to physical side In-Reply-To: <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> References: <20210313083900.234-1-lushenming@huawei.com> <20210313083900.234-6-lushenming@huawei.com> <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210315_092102_969305_DECC6CC9 X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMy0xNSAwOToxMSwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gT24gMjAyMS8zLzE1IDE2 OjMwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIDIwMjEtMDMtMTMgMDg6MzgsIFNoZW5taW5n IEx1IHdyb3RlOgo+Pj4gRnJvbTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4+ PiAKPj4+IFdoZW4gc2V0dGluZyB0aGUgZm9yd2FyZGluZyBwYXRoIG9mIGEgVkxQSSAoc3dpdGNo IHRvIHRoZSBIVyBtb2RlKSwKPj4+IHdlIGNhbiBhbHNvIHRyYW5zZmVyIHRoZSBwZW5kaW5nIHN0 YXRlIGZyb20gaXJxLT5wZW5kaW5nX2xhdGNoIHRvCj4+PiBWUFQgKGVzcGVjaWFsbHkgaW4gbWln cmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMgYXJlIAo+Pj4gcmVzdG9yZWQKPj4+ IGludG8ga3Zt4oCZcyB2Z2ljIGZpcnN0KS4gQW5kIHdlIGN1cnJlbnRseSBzZW5kICJJTlQrVlNZ TkMiIHRvIHRyaWdnZXIKPj4+IGEgVkxQSSB0byBwZW5kaW5nLgo+Pj4gCj4+PiBTaWduZWQtb2Zm LWJ5OiBaZW5naHVpIFl1IDx5dXplbmdodWlAaHVhd2VpLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6 IFNoZW5taW5nIEx1IDxsdXNoZW5taW5nQGh1YXdlaS5jb20+Cj4+PiAtLS0KPj4+IMKgYXJjaC9h cm02NC9rdm0vdmdpYy92Z2ljLXY0LmMgfCAxOCArKysrKysrKysrKysrKysrKysKPj4+IMKgMSBm aWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKPj4+IAo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gv YXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIAo+Pj4gYi9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMt djQuYwo+Pj4gaW5kZXggYWMwMjliYTNkMzM3Li4zYjgyYWI4MGMyZjMgMTAwNjQ0Cj4+PiAtLS0g YS9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMtdjQuYwo+Pj4gKysrIGIvYXJjaC9hcm02NC9rdm0v dmdpYy92Z2ljLXY0LmMKPj4+IEBAIC00NDksNiArNDQ5LDI0IEBAIGludCBrdm1fdmdpY192NF9z ZXRfZm9yd2FyZGluZyhzdHJ1Y3Qga3ZtICprdm0sIAo+Pj4gaW50IHZpcnEsCj4+PiDCoMKgwqDC oCBpcnEtPmhvc3RfaXJxwqDCoMKgID0gdmlycTsKPj4+IMKgwqDCoMKgIGF0b21pY19pbmMoJm1h cC52cGUtPnZscGlfY291bnQpOwo+Pj4gCj4+PiArwqDCoMKgIC8qIFRyYW5zZmVyIHBlbmRpbmcg c3RhdGUgKi8KPj4+ICvCoMKgwqAgaWYgKGlycS0+cGVuZGluZ19sYXRjaCkgewo+Pj4gK8KgwqDC oMKgwqDCoMKgIHVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4+PiArCj4+PiArwqDCoMKgwqDCoMKgwqAg cmV0ID0gaXJxX3NldF9pcnFjaGlwX3N0YXRlKGlycS0+aG9zdF9pcnEsCj4+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBJUlFDSElQX1NUQVRFX1BFTkRJ TkcsCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBp cnEtPnBlbmRpbmdfbGF0Y2gpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIFdBUk5fUkFURUxJTUlUKHJl dCwgIklSUSAlZCIsIGlycS0+aG9zdF9pcnEpOwo+Pj4gKwo+Pj4gK8KgwqDCoMKgwqDCoMKgIC8q Cj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqIENsZWFyIHBlbmRpbmdfbGF0Y2ggYW5kIGNvbW11bmlj YXRlIHRoaXMgc3RhdGUKPj4+ICvCoMKgwqDCoMKgwqDCoMKgICogY2hhbmdlIHZpYSB2Z2ljX3F1 ZXVlX2lycV91bmxvY2suCj4+PiArwqDCoMKgwqDCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoMKgwqDC oMKgIHJhd19zcGluX2xvY2tfaXJxc2F2ZSgmaXJxLT5pcnFfbG9jaywgZmxhZ3MpOwo+Pj4gK8Kg wqDCoMKgwqDCoMKgIGlycS0+cGVuZGluZ19sYXRjaCA9IGZhbHNlOwo+Pj4gK8KgwqDCoMKgwqDC oMKgIHZnaWNfcXVldWVfaXJxX3VubG9jayhrdm0sIGlycSwgZmxhZ3MpOwo+Pj4gK8KgwqDCoCB9 Cj4+PiArCj4+PiDCoG91dDoKPj4+IMKgwqDCoMKgIG11dGV4X3VubG9jaygmaXRzLT5pdHNfbG9j ayk7Cj4+PiDCoMKgwqDCoCByZXR1cm4gcmV0Owo+PiAKPj4gVGhlIHJlYWQgc2lkZSBvZiB0aGUg cGVuZGluZyBzdGF0ZSBpc24ndCBsb2NrZWQsIGJ1dCB0aGUgd3JpdGUgc2lkZSAKPj4gaXMuCj4+ IEknZCByYXRoZXIgeW91IGxvY2sgdGhlIHdob2xlIHNlcXVlbmNlIGZvciBwZWFjZSBvZiBtaW5k Lgo+IAo+IERpZCB5b3UgbWVhbiB0byBsb2NrIGJlZm9yZSBlbWl0dGluZyB0aGUgbWFwcGluZyBy ZXF1ZXN0LCBPciBqdXN0IAo+IGJlZm9yZSByZWFkaW5nCj4gdGhlIHBlbmRpbmcgc3RhdGU/CgpK dXN0IGJlZm9yZSByZWFkaW5nIHRoZSBwZW5kaW5nIHN0YXRlLCBzbyB0aGF0IHdlIGNhbid0IGdl dCBhIGNvbmN1cnJlbnQKbW9kaWZpY2F0aW9uIG9mIHRoYXQgc3RhdGUgd2hpbGUgd2UgbWFrZSB0 aGUgaW50ZXJydXB0IHBlbmRpbmcgaW4gdGhlIApWUFQKYW5kIGNsZWFyaW5nIGl0IGluIHRoZSBl bXVsYXRpb24uCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQg anVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E07C433E6 for ; Mon, 15 Mar 2021 09:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC7A964E33 for ; Mon, 15 Mar 2021 09:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbhCOJVC (ORCPT ); Mon, 15 Mar 2021 05:21:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:47744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbhCOJVB (ORCPT ); Mon, 15 Mar 2021 05:21:01 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADB7264E12; Mon, 15 Mar 2021 09:21:00 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1lLjPG-001cIb-KN; Mon, 15 Mar 2021 09:20:58 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 15 Mar 2021 09:20:58 +0000 From: Marc Zyngier To: Shenming Lu Cc: Eric Auger , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Williamson , Cornelia Huck , Lorenzo Pieralisi , wanghaibin.wang@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v4 5/6] KVM: arm64: GICv4.1: Restore VLPI pending state to physical side In-Reply-To: <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> References: <20210313083900.234-1-lushenming@huawei.com> <20210313083900.234-6-lushenming@huawei.com> <81fbadda-0489-ffc3-cb38-08e89871ec95@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, eric.auger@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, cohuck@redhat.com, lorenzo.pieralisi@arm.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021-03-15 09:11, Shenming Lu wrote: > On 2021/3/15 16:30, Marc Zyngier wrote: >> On 2021-03-13 08:38, Shenming Lu wrote: >>> From: Zenghui Yu >>> >>> When setting the forwarding path of a VLPI (switch to the HW mode), >>> we can also transfer the pending state from irq->pending_latch to >>> VPT (especially in migration, the pending states of VLPIs are >>> restored >>> into kvm’s vgic first). And we currently send "INT+VSYNC" to trigger >>> a VLPI to pending. >>> >>> Signed-off-by: Zenghui Yu >>> Signed-off-by: Shenming Lu >>> --- >>>  arch/arm64/kvm/vgic/vgic-v4.c | 18 ++++++++++++++++++ >>>  1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm64/kvm/vgic/vgic-v4.c >>> b/arch/arm64/kvm/vgic/vgic-v4.c >>> index ac029ba3d337..3b82ab80c2f3 100644 >>> --- a/arch/arm64/kvm/vgic/vgic-v4.c >>> +++ b/arch/arm64/kvm/vgic/vgic-v4.c >>> @@ -449,6 +449,24 @@ int kvm_vgic_v4_set_forwarding(struct kvm *kvm, >>> int virq, >>>      irq->host_irq    = virq; >>>      atomic_inc(&map.vpe->vlpi_count); >>> >>> +    /* Transfer pending state */ >>> +    if (irq->pending_latch) { >>> +        unsigned long flags; >>> + >>> +        ret = irq_set_irqchip_state(irq->host_irq, >>> +                        IRQCHIP_STATE_PENDING, >>> +                        irq->pending_latch); >>> +        WARN_RATELIMIT(ret, "IRQ %d", irq->host_irq); >>> + >>> +        /* >>> +         * Clear pending_latch and communicate this state >>> +         * change via vgic_queue_irq_unlock. >>> +         */ >>> +        raw_spin_lock_irqsave(&irq->irq_lock, flags); >>> +        irq->pending_latch = false; >>> +        vgic_queue_irq_unlock(kvm, irq, flags); >>> +    } >>> + >>>  out: >>>      mutex_unlock(&its->its_lock); >>>      return ret; >> >> The read side of the pending state isn't locked, but the write side >> is. >> I'd rather you lock the whole sequence for peace of mind. > > Did you mean to lock before emitting the mapping request, Or just > before reading > the pending state? Just before reading the pending state, so that we can't get a concurrent modification of that state while we make the interrupt pending in the VPT and clearing it in the emulation. Thanks, M. -- Jazz is not dead. It just smells funny...