From: Martin KaFai Lau <martin.lau@linux.dev>
To: Tonghao Zhang <tong@infragraf.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Hou Tao <houtao1@huawei.com>,
bpf@vger.kernel.org
Subject: Re: [bpf-next v5 3/3] bpf: hash map, suppress false lockdep warning
Date: Thu, 12 Jan 2023 21:14:05 -0800 [thread overview]
Message-ID: <b05c4042-ee7e-43ad-b518-411bd3afa95e@linux.dev> (raw)
In-Reply-To: <97068F10-C869-4FF3-8FE0-21FA6DA82D98@infragraf.org>
On 1/12/23 6:17 PM, Tonghao Zhang wrote:
>> I am not very sure about the lockdep_off/on. Other than the false warning when using the very same htab map by both NMI and non-NMI context, I think the lockdep will still be useful
> Agree, but there is no good way to fix this warning.
I applied patch 1 to the bpf tree with the 'Fixes: 20b6cc34ea74 ("bpf: Avoid
hashtab deadlock with map_locked")' tag. Thanks.
The commit message has a link to the test. Not ideal but keeping the lockdep is
more important.
next prev parent reply other threads:[~2023-01-13 5:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 9:29 [bpf-next v5 1/3] bpf: hash map, avoid deadlock with suitable hash mask tong
2023-01-11 9:29 ` [bpf-next v5 2/3] selftests/bpf: add test case for htab map tong
2023-01-11 9:29 ` [bpf-next v5 3/3] bpf: hash map, suppress false lockdep warning tong
2023-01-13 1:53 ` Martin KaFai Lau
2023-01-13 2:03 ` Alexei Starovoitov
2023-01-13 2:17 ` Tonghao Zhang
2023-01-13 5:14 ` Martin KaFai Lau [this message]
2023-01-13 9:15 ` Tonghao Zhang
2023-01-15 22:51 ` Martin KaFai Lau
2023-02-01 7:12 ` Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b05c4042-ee7e-43ad-b518-411bd3afa95e@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=tong@infragraf.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.