From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D938BC4332F for ; Fri, 16 Dec 2022 16:04:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B80DA16F3; Fri, 16 Dec 2022 17:03:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B80DA16F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1671206643; bh=lF4vw7e9EdXWDJLOD83gO5PEMesX68FvheF+irKVV2g=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=r7tLpPtpHwc4gS7wxpte0F3zNnPaWbRY1V0DzJTbRKaJY0xvIimu2ExHVGGjO7NTG lND2hc2WSkBT070IkxAjB4NaiHhrvx5Gpn2SWPQF6XOhaDBjxJ4Zx8Sj1e0KTPevdz V9z2mNv1g1rV9mkB2Vvh7ZiHMSWxH0wz+j+cKSik= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5C336F804E0; Fri, 16 Dec 2022 17:03:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96245F804E2; Fri, 16 Dec 2022 17:03:11 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 80FF0F804D0 for ; Fri, 16 Dec 2022 17:03:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 80FF0F804D0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Eaww+J4W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671206590; x=1702742590; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lF4vw7e9EdXWDJLOD83gO5PEMesX68FvheF+irKVV2g=; b=Eaww+J4WlYA8wLtMCe1P0VnltX6FsVswgZr4Kesaw+Mu/NP0tY2ss76L G5ergcUPHskHb/glb5xynhev6SiRtwGFk1jxQmLTiUxXHhkcyKOvHL/0h TZjS0uNiPeV1Ktq7VNTCizFeM0Iovmhl9G7Pibnhu9BUJz3z2EF7z2TjY JB2yNnQ14h1bNxje82ygis9uot/VCRmv2ucQnU7m7zi6tmWP5sLOTYlVU zBK/fc98IcjDZ0d8zOz25shjRZzxP+HS5QJjZonCd8sX/jc1smnY6VRve ccbaa0m30malibipc0ww2eSkOJzk8hCo7U0RiNoTdmopxddygWv/OKNje g==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="383327929" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="383327929" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:03:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="824148061" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="824148061" Received: from krojasle-mobl.amr.corp.intel.com (HELO [10.209.187.31]) ([10.209.187.31]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:03:04 -0800 Message-ID: Date: Fri, 16 Dec 2022 10:03:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. Content-Language: en-US To: Ajye Huang , linux-kernel@vger.kernel.org References: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> From: Pierre-Louis Bossart In-Reply-To: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Libin Yang , "balamurugan . c" , Cezary Rojewski , Kai Vehmanen , Bard Liao , Takashi Iwai , Ranjani Sridharan , Liam Girdwood , Mark Brown , Muralidhar Reddy , Akihiko Odaki , ye xingchen , David Lin , alsa-devel@alsa-project.org, Peter Ujfalusi , Brent Lu , Yong Zhi Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/16/22 09:49, Ajye Huang wrote: > This patch adds the driver data for two nau8318 speaker amplifiers on > SSP1 and nau8825 on SSP0 for ADL platform. So here you are making reference to two amplifiers... > +static struct snd_soc_dai_link_component nau8318_components[] = { > + { > + .name = "NVTN2012:00", > + .dai_name = "nau8315-hifi", > + } > +}; but here there's only one? I was expecting something like what we've used for Maxim amplifiers with a codec configuration and dailink components that list the two amplifiers. static struct snd_soc_codec_conf max_98373_codec_conf[] = { { .dlc = COMP_CODEC_CONF(MAX_98373_DEV0_NAME), .name_prefix = "Right", }, { .dlc = COMP_CODEC_CONF(MAX_98373_DEV1_NAME), .name_prefix = "Left", }, }; struct snd_soc_dai_link_component max_98373_components[] = { { /* For Right */ .name = MAX_98373_DEV0_NAME, .dai_name = MAX_98373_CODEC_DAI, }, { /* For Left */ .name = MAX_98373_DEV1_NAME, .dai_name = MAX_98373_CODEC_DAI, }, }; Or is this a commit message problem and there's really only one amplifier? > + > static struct snd_soc_dai_link_component dummy_component[] = { > { > .name = "snd-soc-dummy", > @@ -486,6 +494,11 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, > max_98360a_dai_link(&links[id]); > } else if (sof_nau8825_quirk & SOF_RT1015P_SPEAKER_AMP_PRESENT) { > sof_rt1015p_dai_link(&links[id]); > + } else if (sof_nau8825_quirk & > + SOF_NAU8318_SPEAKER_AMP_PRESENT) { > + links[id].codecs = nau8318_components; > + links[id].num_codecs = ARRAY_SIZE(nau8318_components); > + links[id].init = speaker_codec_init; The rest looks fine, I only have this one/two amplifier question. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E3AC4332F for ; Fri, 16 Dec 2022 16:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232613AbiLPQG5 (ORCPT ); Fri, 16 Dec 2022 11:06:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231624AbiLPQGM (ORCPT ); Fri, 16 Dec 2022 11:06:12 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF88062D9 for ; Fri, 16 Dec 2022 08:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671206586; x=1702742586; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lF4vw7e9EdXWDJLOD83gO5PEMesX68FvheF+irKVV2g=; b=Trr81rJ5nzMPMshoemErIiuV2IdEgWV9syPe5c1l3Nbj3c8XLYPv72WM u8BJ2jQphzIpppbYf56MEZcpT4kgBf04Kc17fl2748T4rKrEnz59EMW45 WTxAn3f4i73Vbf+nW6sLKVm+aC9kkQwANPyzYxc4sCSxyQ6HKax5Zs6SY +x8tS4hxzE7HBjIYkMH2q9u65H25p4OiAHvktWSW09CqlD9AxB6cHyfSX izPjh+8ddkvmZva1Az32RSf/nvZVD/1ipSVG8DjCdT6Gfppj5WMH30KQM 7h2VyOYpW7HmxjAEqdcyIV2PhBVPBDJx7zwWt0qqAmMASwMyZ4PsxyJSq w==; X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="383327925" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="383327925" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:03:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10563"; a="824148061" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="824148061" Received: from krojasle-mobl.amr.corp.intel.com (HELO [10.209.187.31]) ([10.209.187.31]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 08:03:04 -0800 Message-ID: Date: Fri, 16 Dec 2022 10:03:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH v2] ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier. Content-Language: en-US To: Ajye Huang , linux-kernel@vger.kernel.org Cc: Mark Brown , Bard Liao , Peter Ujfalusi , Liam Girdwood , Akihiko Odaki , Yong Zhi , ye xingchen , Muralidhar Reddy , "balamurugan . c" , Libin Yang , Jaroslav Kysela , Ranjani Sridharan , Cezary Rojewski , David Lin , Brent Lu , Takashi Iwai , Kai Vehmanen , alsa-devel@alsa-project.org References: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> From: Pierre-Louis Bossart In-Reply-To: <20221216154938.9426-1-ajye_huang@compal.corp-partner.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/16/22 09:49, Ajye Huang wrote: > This patch adds the driver data for two nau8318 speaker amplifiers on > SSP1 and nau8825 on SSP0 for ADL platform. So here you are making reference to two amplifiers... > +static struct snd_soc_dai_link_component nau8318_components[] = { > + { > + .name = "NVTN2012:00", > + .dai_name = "nau8315-hifi", > + } > +}; but here there's only one? I was expecting something like what we've used for Maxim amplifiers with a codec configuration and dailink components that list the two amplifiers. static struct snd_soc_codec_conf max_98373_codec_conf[] = { { .dlc = COMP_CODEC_CONF(MAX_98373_DEV0_NAME), .name_prefix = "Right", }, { .dlc = COMP_CODEC_CONF(MAX_98373_DEV1_NAME), .name_prefix = "Left", }, }; struct snd_soc_dai_link_component max_98373_components[] = { { /* For Right */ .name = MAX_98373_DEV0_NAME, .dai_name = MAX_98373_CODEC_DAI, }, { /* For Left */ .name = MAX_98373_DEV1_NAME, .dai_name = MAX_98373_CODEC_DAI, }, }; Or is this a commit message problem and there's really only one amplifier? > + > static struct snd_soc_dai_link_component dummy_component[] = { > { > .name = "snd-soc-dummy", > @@ -486,6 +494,11 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, > max_98360a_dai_link(&links[id]); > } else if (sof_nau8825_quirk & SOF_RT1015P_SPEAKER_AMP_PRESENT) { > sof_rt1015p_dai_link(&links[id]); > + } else if (sof_nau8825_quirk & > + SOF_NAU8318_SPEAKER_AMP_PRESENT) { > + links[id].codecs = nau8318_components; > + links[id].num_codecs = ARRAY_SIZE(nau8318_components); > + links[id].init = speaker_codec_init; The rest looks fine, I only have this one/two amplifier question.