From: okaya@codeaurora.org
To: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com,
shankerd@codeaurora.org, vikrams@codeaurora.org,
marc.zyngier@arm.com, mark.rutland@arm.com,
eric.auger@linaro.org, agross@codeaurora.org, arnd@arndb.de,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dan Williams <dan.j.williams@intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks
Date: Tue, 26 Apr 2016 08:08:16 -0400 [thread overview]
Message-ID: <b068ead6474f2ffee5acef9ea799aba3@codeaurora.org> (raw)
In-Reply-To: <20160426033029.GB2274@localhost>
On 2016-04-25 23:30, Vinod Koul wrote:
> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote:
>
>> +static int hidma_chan_stats(struct seq_file *s, void *unused)
>> +{
>> + struct hidma_chan *mchan = s->private;
>> + struct hidma_desc *mdesc;
>> + struct hidma_dev *dmadev = mchan->dmadev;
>> +
>> + pm_runtime_get_sync(dmadev->ddev.dev);
>
> debug shouldn't power up device, why do you want to do that
Clocks are turned off while the hw is idle. I can’t reach hw registers
without restoring power.
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (okaya at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks
Date: Tue, 26 Apr 2016 08:08:16 -0400 [thread overview]
Message-ID: <b068ead6474f2ffee5acef9ea799aba3@codeaurora.org> (raw)
In-Reply-To: <20160426033029.GB2274@localhost>
On 2016-04-25 23:30, Vinod Koul wrote:
> On Mon, Apr 11, 2016 at 10:21:12AM -0400, Sinan Kaya wrote:
>
>> +static int hidma_chan_stats(struct seq_file *s, void *unused)
>> +{
>> + struct hidma_chan *mchan = s->private;
>> + struct hidma_desc *mdesc;
>> + struct hidma_dev *dmadev = mchan->dmadev;
>> +
>> + pm_runtime_get_sync(dmadev->ddev.dev);
>
> debug shouldn't power up device, why do you want to do that
Clocks are turned off while the hw is idle. I can?t reach hw registers
without restoring power.
next prev parent reply other threads:[~2016-04-26 12:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 14:21 [PATCH V17 0/3] dmaengine: add Qualcomm Technologies HIDMA driver Sinan Kaya
2016-04-11 14:21 ` Sinan Kaya
2016-04-11 14:21 ` [PATCH V17 1/3] dmaengine: qcom_hidma: implement lower level hardware interface Sinan Kaya
2016-04-11 14:21 ` Sinan Kaya
2016-04-26 3:28 ` Vinod Koul
2016-04-26 3:28 ` Vinod Koul
2016-04-26 15:04 ` Sinan Kaya
2016-04-26 15:04 ` Sinan Kaya
[not found] ` <571F8397.5000803-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-26 15:10 ` Andy Shevchenko
2016-04-26 15:10 ` Andy Shevchenko
2016-04-26 15:10 ` Andy Shevchenko
2016-04-26 15:23 ` Sinan Kaya
2016-04-26 15:23 ` Sinan Kaya
2016-04-26 16:24 ` Vinod Koul
2016-04-26 16:24 ` Vinod Koul
2016-04-26 16:24 ` Vinod Koul
2016-04-28 19:30 ` Sinan Kaya
2016-04-28 19:30 ` Sinan Kaya
2016-05-01 4:38 ` Sinan Kaya
2016-05-01 4:38 ` Sinan Kaya
2016-04-11 14:21 ` [PATCH V17 2/3] dmaengine: qcom_hidma: add debugfs hooks Sinan Kaya
2016-04-11 14:21 ` Sinan Kaya
2016-04-26 3:30 ` Vinod Koul
2016-04-26 3:30 ` Vinod Koul
2016-04-26 12:08 ` okaya [this message]
2016-04-26 12:08 ` okaya at codeaurora.org
[not found] ` <b068ead6474f2ffee5acef9ea799aba3-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-26 16:25 ` Vinod Koul
2016-04-26 16:25 ` Vinod Koul
2016-04-26 16:25 ` Vinod Koul
2016-04-26 16:55 ` Sinan Kaya
2016-04-26 16:55 ` Sinan Kaya
2016-04-27 8:15 ` Vinod Koul
2016-04-27 8:15 ` Vinod Koul
2016-04-27 8:47 ` Marc Zyngier
2016-04-27 8:47 ` Marc Zyngier
2016-04-27 8:47 ` Marc Zyngier
2016-04-27 13:25 ` okaya
2016-04-27 13:25 ` okaya at codeaurora.org
2016-04-27 12:51 ` okaya
2016-04-27 12:51 ` okaya at codeaurora.org
2016-05-01 4:35 ` Sinan Kaya
2016-05-01 4:35 ` Sinan Kaya
[not found] ` <57258799.70803-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-05-02 9:25 ` Vinod Koul
2016-05-02 9:25 ` Vinod Koul
2016-05-02 9:25 ` Vinod Koul
2016-05-02 10:40 ` Mark Brown
2016-05-02 10:40 ` Mark Brown
2016-04-11 14:21 ` [PATCH V17 3/3] dmaengine: qcom_hidma: add support for object hierarchy Sinan Kaya
2016-04-11 14:21 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b068ead6474f2ffee5acef9ea799aba3@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@linaro.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=shankerd@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=vikrams@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.