Re: [PATCH] selftests/bpf: Enforce definition order for __msg macros in BPF tests

[Eduard Zingerman <eddyz87@gmail.com>]

On Thu, 2026-03-05 at 13:00 +0000, Cupertino Miranda wrote:
> Ensure that __msg macros, and similars, used for BPF test validation are
> processed in the order they are defined in the source code.
> 
> Neither GCC nor the C standard defines the order in which function
> attributes are consumed. While Clang tends to preserve definition order,
> GCC may process them out of sequence. This inconsistency causes BPF
> tests with multiple __msg entries to fail when compiled with GCC.
> 
> This patch fixes the test runner to explicitly sort or process these
> attributes to guarantee predictable matching behavior across different
> compilers.
> 
> Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com>
> Cc: David Faust  <david.faust@oracle.com>
> Cc: Jose Marchesi  <jose.marchesi@oracle.com>
> Cc: Elena Zannoni  <elena.zannoni@oracle.com>
> ---

Looks like this patch fell through the cracks.

It looks a bit intrusive, given the amount of places index has to be
passed through. An alternative would be to modify parse_test_spec()
such that it collects decl tag ids into the array first and then sorts
the array. It will have to use strverscmp() for comparator, though.
This way all the changes would be localized to a single function
collecting the array.

Up to you if that is worth the hassle.

Reviewed-by: Eduard Zingerman <eddyz87@gmail.com>

[...]