From: Catalin Marinas <catalin.marinas@gmail.com>
To: Chuck Lever <cel@citi.umich.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 6/7] Add a "--clone" option to "stg branch"
Date: Thu, 1 Dec 2005 21:05:32 +0000 [thread overview]
Message-ID: <b0943d9e0512011305v3299f27au@mail.gmail.com> (raw)
In-Reply-To: <20051129220949.9885.51533.stgit@dexter.citi.umich.edu>
On 29/11/05, Chuck Lever <cel@netapp.com> wrote:
> Cloning a branch means creating a new branch and copying all of the
> original branch's patches and its base to it. Like creating a tag,
> but this also preserves all the StGIT patches as well.
[...]
> --- a/stgit/commands/branch.py
> +++ b/stgit/commands/branch.py
[...]
> + print 'Cloning current branch to "%s"...' % clone
I would put a comma after this line and add sys.stdout.flush(). So
that 'done' is shown on the same line.
[...]
> --- a/stgit/stack.py
> +++ b/stgit/stack.py
[...]
> + def clone(self, target_series):
> + """Clones a series
> + """
Wouldn't it be easier to do a recursive copy at the directory level
(.git/patches/<branch> into .git/patches/<clone> and
.git/refs/bases/<branch> into .git/refs/bases/<clone>)? Is there
anything that could go wrong if we do this?
--
Catalin
next prev parent reply other threads:[~2005-12-01 21:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-29 22:05 [PATCH 0/7] Chuck Lever
2005-11-29 22:09 ` [PATCH 1/7] Make "stg export" save the base commit in the output directory Chuck Lever
2005-11-30 21:53 ` Catalin Marinas
2005-11-29 22:09 ` [PATCH 2/7] Use git-rev-parse to find the local GIT repository Chuck Lever
2005-11-29 22:09 ` [PATCH 3/7] Align branch descriptions in output of "stg branch -l" Chuck Lever
2005-11-29 22:09 ` [PATCH 4/7] "stg series" option to show patch summary descriptions Chuck Lever
2005-11-29 22:09 ` [PATCH 5/7] Add facility to print short list of patches around 'top' Chuck Lever
2005-11-29 22:09 ` [PATCH 6/7] Add a "--clone" option to "stg branch" Chuck Lever
2005-12-01 21:05 ` Catalin Marinas [this message]
2005-12-01 21:47 ` Chuck Lever
2005-11-29 22:09 ` [PATCH 7/7] Use a separate directory for patches under each branch subdir Chuck Lever
2005-11-30 22:23 ` Catalin Marinas
2005-11-30 22:28 ` Chuck Lever
2005-11-30 22:32 ` Catalin Marinas
2005-12-01 2:53 ` Chuck Lever
2005-11-30 22:27 ` [PATCH 0/7] Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0943d9e0512011305v3299f27au@mail.gmail.com \
--to=catalin.marinas@gmail.com \
--cc=cel@citi.umich.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.