From: Jeff Layton <jlayton@kernel.org>
To: Eryu Guan <guan@eryu.me>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS
Date: Mon, 09 Nov 2020 13:56:29 -0500 [thread overview]
Message-ID: <b0adb484dac6c2020467f148c7e00a9dab6af5df.camel@kernel.org> (raw)
In-Reply-To: <20201108063701.GG3853@desktop>
On Sun, 2020-11-08 at 14:37 +0800, Eryu Guan wrote:
> On Thu, Nov 05, 2020 at 10:09:36AM -0500, Jeff Layton wrote:
> > We already have a $TEST_FS_MOUNT_OPTS which gets applied only to the
> > test mount, but we don't have a corresponding variable for the scratch
> > mount. Add one.
>
> MOUNT_OPTIONS is used for the scratch mount, and
> _common_dev_mount_options includes it. Would you please confirm if that
> works for you?
>
> Thanks,
> Eryu
>
Yes, it does. I had had a problem with that at one point, but I don't
currently recall what it was. In any case, feel free to drop this one.
Thanks,
Jeff
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > common/rc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/rc b/common/rc
> > index 65ebfe201139..23874d1e5b8e 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -308,7 +308,7 @@ _scratch_mount_options()
> > {
> > _scratch_options mount
> >
> >
> >
> >
> > - echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
> > + echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $SCRATCH_FS_MOUNT_OPTS \
> > $SCRATCH_DEV $SCRATCH_MNT
> > }
> >
> >
> >
> >
> > --
> > 2.28.0
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-11-09 18:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:09 [PATCH] common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS Jeff Layton
2020-11-08 6:37 ` Eryu Guan
2020-11-09 18:56 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0adb484dac6c2020467f148c7e00a9dab6af5df.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.