From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 120F7165F16 for ; Fri, 2 Jan 2026 03:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767325234; cv=none; b=K/6GoY4ME5hF5phiGCZD+FfgjESkd/b0f2zJ4CQDpZyQarRY9OK/JHt/rHG3KqLlBjPvt4zyhg86K8LCWR4RdUhxa4PT5o34lo+yuKaN+HEC8NYet1YWUo25ht7vwcsouJB249zkgF19RZ1JHvzEBMXa9kqrdTsRPJWMpVpqRq0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767325234; c=relaxed/simple; bh=QB+Pn/Vx8AoL9WltKwNOVQhjw3GUNAFZQ3n5v/CwL08=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BNDZKFwk/PcLuwsvX4KI8dgRIgXfz7i7ItD8ibjm8pvfRpKhQ8TiDk5pPGuvZEki0+voc8hPVZMR6qbG69BiC4WKHyO6MAKB/BH/4Dyqy0FD+9lOmCydb/PPxvV6aVNgsmMrB3u54EOiEKUi7OmG6r+n+qgURRPIc9oTaxfgmZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=T2LyRMDi; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="T2LyRMDi" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1767325230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zEgOlwRSoqJj1EQEAAgbESyU2DPEGif3EAHdQ90hydk=; b=T2LyRMDi+Ym0QMoRXVMeMd6DLLs/6IJr5GQnPweQXjJPCaiUL67cqIhXODRDOWOkhBfZpQ YxALXoRudis87rh3FrMdH8hULZKE3XvhZF83L7JsGZJB3NPpx/eqWW+xTfysXnN+eHsGO4 BINSK1+Lj/evNY8GllNDjHUUfkaZqT8= Date: Fri, 2 Jan 2026 11:40:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [v5 PATCH 1/2] hung_task: Introduce helper for hung task warning Content-Language: en-US To: Aaron Tomlin Cc: sean@ashe.io, akpm@linux-foundation.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, joel.granados@kernel.org, pmladek@suse.com, mhiramat@kernel.org References: <20251231004125.2380105-1-atomlin@atomlin.com> <20251231004125.2380105-2-atomlin@atomlin.com> <8a82158f-370a-4c6d-b7f8-71f80aa3e3d2@linux.dev> <5n62kpipakytp6u7be24ltvhwqryztoe5goorgrnserwnrwfyt@owbkj3pezq55> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <5n62kpipakytp6u7be24ltvhwqryztoe5goorgrnserwnrwfyt@owbkj3pezq55> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/1/2 03:28, Aaron Tomlin wrote: > On Thu, Jan 01, 2026 at 05:49:59PM +0800, Lance Yang wrote: >> I am wondering whether we should leave that code as-is to >> avoid unnecessary churn ... >> >> That code was not particularly complex or duplicated :) > > Hi Lance, > > While I agree the current logic is simple, separating the verbose reporting > from the detection loop significantly improves the readability of > check_hung_task(). This refactoring introduces no runtime overhead > (static inline) while providing a cleaner, encapsulated structure for any > future diagnostic enhancements. For a single-use diagnostic block, I still think this refactoring does not add much practical value ... Let's leave the code alone - it's probably not worth the churn :)