From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C00DC433EF for ; Fri, 21 Jan 2022 07:12:08 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A4DA837CC; Fri, 21 Jan 2022 08:12:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="I9rHkus8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D41B5837DE; Fri, 21 Jan 2022 08:12:05 +0100 (CET) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D471783494 for ; Fri, 21 Jan 2022 08:12:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vigneshr@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 20L7Bw1W047369; Fri, 21 Jan 2022 01:11:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1642749118; bh=w5qTQK/h88mUMhSu0CzsewWE35rWBvo+k4mYvL5c6mk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=I9rHkus8yRA2cQgcu7zQ8MwhNmQbRnzHRsMtIW1w1cm56qCxxpLtC8FRHF8jRpO3H dx1T1KV8G4Drs5+P1PttJrkTLWvHjuIe4KFf9XuPVsFbXVvWxc4vKhpEAOoxbGIG4W 8i433CICtWa5jX46ld+0FxOFOwqsJZFFy6/aXRzY= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 20L7Bw3P053998 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Jan 2022 01:11:58 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 21 Jan 2022 01:11:57 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 21 Jan 2022 01:11:57 -0600 Received: from [10.250.149.244] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 20L7Bt4i014739; Fri, 21 Jan 2022 01:11:56 -0600 Message-ID: Date: Fri, 21 Jan 2022 12:41:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 6/8] configs: am64x_evm: set eth1 as boot interface Content-Language: en-US To: Tom Rini CC: Dave Gerlach , Joe Hershberger , Ramon Fried , , Grygorii Strashko References: <20211224072536.270251-1-vigneshr@ti.com> <20211224072536.270251-7-vigneshr@ti.com> <20220117144650.GA2631507@bill-the-cat> From: Vignesh Raghavendra In-Reply-To: <20220117144650.GA2631507@bill-the-cat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 17/01/22 8:16 pm, Tom Rini wrote: > On Fri, Dec 24, 2021 at 12:55:34PM +0530, Vignesh Raghavendra wrote: > >> ROM supports boot from CPSW second port, therefore set eth1 boot >> interface >> >> Signed-off-by: Vignesh Raghavendra >> --- >> include/configs/am64x_evm.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h >> index 99624081c3..cd4b658e5f 100644 >> --- a/include/configs/am64x_evm.h >> +++ b/include/configs/am64x_evm.h >> @@ -33,7 +33,7 @@ >> * our memory footprint. The less we use for BSS the more we have available >> * for everything else. >> */ >> -#define CONFIG_SPL_BSS_MAX_SIZE 0x1000 >> +#define CONFIG_SPL_BSS_MAX_SIZE 0xa000 >> /* >> * Link BSS to be within SPL in a dedicated region located near the top of >> * the MCU SRAM, this way making it available also before relocation. Note >> @@ -64,6 +64,7 @@ >> "if test $fdtfile = undefined; then " \ >> "echo WARNING: Could not determine device tree to use; fi; \0" \ >> "name_kern=Image\0" \ >> + "ethact=eth0\0" \ This is redundant, will drop. >> "console=ttyS2,115200n8\0" \ >> "args_all=setenv optargs earlycon=ns16550a,mmio32,0x02800000 " \ >> "${mtdparts}\0" \ >> @@ -140,4 +141,6 @@ >> >> #define CONFIG_SYS_USB_FAT_BOOT_PARTITION 1 >> >> +#define CONFIG_SPL_ETH_DEVICE "eth1" >> + >> #endif /* __CONFIG_AM642_EVM_H */ > > What's going on exactly here? First, CONFIG_SPL_ETH_DEVICE needs to be > migrated to Kconfig now, if we're going to use it. But, it's used to > set "ethact", which wouldd normally be eth0, but you're setting it to > eth1 here and eth0 for U-Boot itself? Can you please explain the setup > here? Thanks! > ROM supports boot from cpsw_port2 (eth1) and not cpsw_port1 (eth0), hence I had to set CONFIG_SPL_ETH_DEVICE to eth1. Thinking a bit more, it does not make sense to enable both ports in SPL as only eth1 is used during ethboot. So CONFIG_SPL_ETH_DEVICE need not be touched if eth0 is disabled for SPL. Will update DT files accordingly. Regards Vignesh