From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH] compat: add header guard to xlat.h
Date: Tue, 3 Jun 2025 08:44:08 +0200 [thread overview]
Message-ID: <b113fa13-b006-4ec9-9412-fe8fdf0f096a@suse.com> (raw)
This is to conform with Misra C:2012 Directive 4.10.
Reported-by: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/Makefile
+++ b/xen/include/Makefile
@@ -105,9 +105,14 @@ xlat-y := $(shell sed -ne 's,@arch@,$(co
xlat-y := $(filter $(patsubst compat/%,%,$(headers-y)),$(xlat-y))
quiet_cmd_xlat_h = GEN $@
-cmd_xlat_h = \
- cat $(filter %.h,$^) >$@.new; \
- mv -f $@.new $@
+define cmd_xlat_h
+ echo "#ifndef COMPAT_XLAT_H" >$@.new; \
+ echo "#define COMPAT_XLAT_H" >>$@.new; \
+ cat $(filter %.h,$^) >>$@.new; \
+ echo "" >>$@.new; \
+ echo "#endif /* COMPAT_XLAT_H */" >>$@.new; \
+ mv -f $@.new $@
+endef
$(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) FORCE
$(call if_changed,xlat_h)
next reply other threads:[~2025-06-03 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 6:44 Jan Beulich [this message]
2025-06-03 7:13 ` [PATCH] compat: add header guard to xlat.h Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b113fa13-b006-4ec9-9412-fe8fdf0f096a@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.