From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEB1810E478 for ; Wed, 16 Nov 2022 17:28:04 +0000 (UTC) Message-ID: Date: Wed, 16 Nov 2022 18:28:00 +0100 MIME-Version: 1.0 Content-Language: en-US To: Ashutosh Dixit , igt-dev@lists.freedesktop.org References: <20221116170751.195223-1-ashutosh.dixit@intel.com> From: "Das, Nirmoy" In-Reply-To: <20221116170751.195223-1-ashutosh.dixit@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915/perf: Propagate return from unsupported_i915_perf_platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Reviewed-by: Nirmoy Das On 11/16/2022 6:07 PM, Ashutosh Dixit wrote: > NULL return from unsupported_i915_perf_platform must be propagated up the > call stack to inform callers of intel_perf_for_devinfo and > intel_perf_for_fd. > > Cc: Lionel Landwerlin > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/7358 > Signed-off-by: Ashutosh Dixit > --- > lib/i915/perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/i915/perf.c b/lib/i915/perf.c > index 28f37948e52..4a946906a84 100644 > --- a/lib/i915/perf.c > +++ b/lib/i915/perf.c > @@ -366,7 +366,7 @@ intel_perf_for_devinfo(uint32_t device_id, > intel_perf_load_metrics_tglgt2(perf); > break; > default: > - unsupported_i915_perf_platform(perf); > + return unsupported_i915_perf_platform(perf); > } > } else if (devinfo->is_rocketlake) { > intel_perf_load_metrics_rkl(perf); > @@ -391,7 +391,7 @@ intel_perf_for_devinfo(uint32_t device_id, > else if (is_acm_gt3(&perf->devinfo)) > intel_perf_load_metrics_acmgt3(perf); > else > - unsupported_i915_perf_platform(perf); > + return unsupported_i915_perf_platform(perf); > } else { > return unsupported_i915_perf_platform(perf); > }