Re: [PATCHv3 1/1] io_uring: add support for IORING_SETUP_SQE_MIXED

[Jens Axboe <axboe@kernel.dk>]

On 9/25/25 12:21 PM, Caleb Sander Mateos wrote:
>>> +int io_uring_cmd128_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
>>> +{
>>> +     if (!(req->ctx->flags & IORING_SETUP_SQE_MIXED))
>>> +             return -EINVAL;
>>> +     return io_uring_cmd_prep(req, sqe);
>>> +}
>>
>> Why isn't this just allowed for SQE128 as well? There should be no
>> reason to disallow explicitly 128b sqe commands in SQE128 mode, they
>> should work for any mode that supports 128b SQEs which is either
>> SQE_MIXED or SQE128?
> 
> Not to mention, the check in io_init_req() should already have
> rejected a 128-byte operation on a non-IORING_SETUP_SQE_MIXED
> io_ring_ctx.

Yes good point, it should all be caught there, no need for any per-op
checking (or the separate prep handler).

-- 
Jens Axboe