From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5379CC9830B for ; Wed, 23 Sep 2026 21:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gopMSo0mzfjrUmtaCVKnC5i427RNBJMYYN+bfD5UTH4=; b=pE0O2Dif3O+qu+aMzg8OPEjaoO Kkr5srImFBcr/uYx4Qg6zzHhdjYkjInShv8kozY+6OodzznQHKiSzU6V5MqsDTGkFQY1l/A3mKL6d a03u9T5Kllf83vXri5pnPcwqMUkhN/rKOmWKta/OLJ/abbRV7iilHXNpoZ/3QsJUmvbmPg03cIDfb NTBkIFrcf+0g6h60m+m9LwZXKYOvwOxYTthlyIwDPu0vIYWf/9NivNJOdqhIHSO4qA9kjTEPgMtoB NH1GVKLE1vuYx0gv83KXvpXvkZ41H5M77ggchGT0iBibF74/QXsFh/d4Nf/KB5homDjxcS3Rl5LKO nKHnB+TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9U4g-00000009WoA-3zkp; Wed, 23 Sep 2026 21:00:18 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9U4f-00000009Wnz-21KU; Wed, 23 Sep 2026 21:00:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB6E943963; Wed, 23 Sep 2026 21:00:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53A831F000FF; Wed, 23 Sep 2026 21:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790197216; bh=gopMSo0mzfjrUmtaCVKnC5i427RNBJMYYN+bfD5UTH4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=j12baXkZU6VWzbYrJ0+NzEVS/CfB8Rh8M798lc+51zoz+KwjyW3gRw6z7EbYzEKEt ZvK0X4S2aRfw3cy98PCg798VnCw2rE7bfIYDt0xAL3U971Y+q8VpPNSApFBWoOB/KT GYT2UyxeQI99pJh0d6zdMidf9LV8/FqeIZJtB0pCSDN+mByRuB8vFuwtybfAlOxXz5 Emh6muuBBbpxRkqAdRwCwdcgzHCg2AkyVLFkGW5mRTdrDHfNbeedm2Zedp/LbGYsw9 HH+YBEKk6Hr2IUcRUjHJrynTu5TcVnQd3Gg0SAZBacZirPA9pv1eDsGDNBQUY5X6UD eqECMtzKo5Dig== Message-ID: Date: Wed, 23 Sep 2026 22:00:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] firmware: qcom: scm: pass qcom_scm to internal helpers To: Albert Esteve , Bjorn Andersson , Konrad Dybcio , Philipp Zabel , Russell King , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Maximilian Luz , Bartosz Golaszewski , Rob Clark , Sean Paul , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" , Thomas Gleixner , Radu Rendec , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Srinivas Kandagatla , Ekansh Gupta , Arnd Bergmann , Greg Kroah-Hartman , Jeff Johnson , Linus Walleij , Mathieu Poirier , Amirreza Zarrabi , Jens Wiklander , Sumit Garg , Amit Kucheria , Thara Gopinath , Zhang Rui , Lukasz Luba , Brian Norris , Govind Singh , Niklas Cassel , Kalle Valo Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-gpio@vger.kernel.org, linux-remoteproc@vger.kernel.org, op-tee@lists.trustedfirmware.org, Maxime Ripard References: <20260914-scm-device-api-v1-0-3573e2596c51@redhat.com> <20260914-scm-device-api-v1-1-3573e2596c51@redhat.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260914-scm-device-api-v1-1-3573e2596c51@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On 14/09/2026 13:41, Albert Esteve wrote: > int qcom_scm_pas_auth_and_reset(u32 pas_id) > { > - return __qcom_scm_pas_auth_and_reset(__scm->dev, pas_id); > + struct qcom_scm *scm = __scm; > + > + return __qcom_scm_pas_auth_and_reset(scm->dev, pas_id); > } > EXPORT_SYMBOL_GPL(qcom_scm_pas_auth_and_reset); Why make this change at all though ? It takes a pointer to the file static _scm The reset of the patch looks straight-forward to me but this change caught my eye. --- bod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.trustedfirmware.org (lists.trustedfirmware.org [18.214.241.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E669C98304 for ; Wed, 23 Sep 2026 21:00:25 +0000 (UTC) Received: from lists.trustedfirmware.org (localhost [127.0.0.1]) by lists.trustedfirmware.org (Postfix) with ESMTP id CC73E4539B for ; Wed, 23 Sep 2026 21:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.trustedfirmware.org; s=2024; t=1790197224; bh=ccQz9YvjRV9nNKuWS/TlWg8SWDYqOPJmHdP9RIhMSUY=; h=Date:Subject:To:References:In-Reply-To:CC:List-Id:List-Archive: List-Help:List-Owner:List-Post:List-Subscribe:List-Unsubscribe: From:Reply-To:From; b=aA3JHxCt+5xz4V8CZQymOkA/EfkfXHY2TxZ2RpLHqFqQF8/KP6syHVUYLtD7qNdS2 95m5pDx1+az/XX4s/ECLTO2XkvhqUnmiNJ8KdFMckWuQeGRVuiuDc1NUsXt7+Kbvkz fPKmv5aaqxnEgVPSr4WNa0/63zU4z3bIhIw/km3rxWMcAaQhaIkDsN4TkmdBK9c1Ps U3qiTbIE+Y9TqVv8/VhNBuDlezETWihpBz/TbxMuqEYQd56cGm4jZyjXH3u5nj/NaV V3nYslJ4KPr6IYAklZuWxU07xKp3S+8I9w7VCrOLMnDwkxepdF/8E2JeXy1fYohChY H8cFhlm5HqfRA== Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by lists.trustedfirmware.org (Postfix) with ESMTPS id C47614323F for ; Wed, 23 Sep 2026 21:00:17 +0000 (UTC) Authentication-Results: lists.trustedfirmware.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j12baXkZ; dkim-atps=neutral Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id DB6E943963; Wed, 23 Sep 2026 21:00:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53A831F000FF; Wed, 23 Sep 2026 21:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790197216; bh=gopMSo0mzfjrUmtaCVKnC5i427RNBJMYYN+bfD5UTH4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=j12baXkZU6VWzbYrJ0+NzEVS/CfB8Rh8M798lc+51zoz+KwjyW3gRw6z7EbYzEKEt ZvK0X4S2aRfw3cy98PCg798VnCw2rE7bfIYDt0xAL3U971Y+q8VpPNSApFBWoOB/KT GYT2UyxeQI99pJh0d6zdMidf9LV8/FqeIZJtB0pCSDN+mByRuB8vFuwtybfAlOxXz5 Emh6muuBBbpxRkqAdRwCwdcgzHCg2AkyVLFkGW5mRTdrDHfNbeedm2Zedp/LbGYsw9 HH+YBEKk6Hr2IUcRUjHJrynTu5TcVnQd3Gg0SAZBacZirPA9pv1eDsGDNBQUY5X6UD eqECMtzKo5Dig== Message-ID: Date: Wed, 23 Sep 2026 22:00:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] firmware: qcom: scm: pass qcom_scm to internal helpers To: Albert Esteve , Bjorn Andersson , Konrad Dybcio , Philipp Zabel , Russell King , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Maximilian Luz , Bartosz Golaszewski , Rob Clark , Sean Paul , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" , Thomas Gleixner , Radu Rendec , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Srinivas Kandagatla , Ekansh Gupta , Arnd Bergmann , Greg Kroah-Hartman , Jeff Johnson , Linus Walleij , Mathieu Poirier , Amirreza Zarrabi , Jens Wiklander , Sumit Garg , Amit Kucheria , Thara Gopinath , Zhang Rui , Lukasz Luba , Brian Norris , Govind Singh , Niklas Cassel , Kalle Valo References: <20260914-scm-device-api-v1-0-3573e2596c51@redhat.com> <20260914-scm-device-api-v1-1-3573e2596c51@redhat.com> Content-Language: en-US In-Reply-To: <20260914-scm-device-api-v1-1-3573e2596c51@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-2.50 / 15.00]; WHITELIST_SPF_DKIM(-3.00)[kernel.org:d:+,kernel.org:s:+]; SUSPICIOUS_RECIPS(1.50)[]; DMARC_POLICY_ALLOW(-0.50)[kernel.org,quarantine]; R_DKIM_ALLOW(-0.20)[kernel.org:s=k20260515]; R_SPF_ALLOW(-0.20)[+ip4:172.234.252.31]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; ASN(0.00)[asn:63949, ipnet:172.234.224.0/19, country:SG]; FREEMAIL_TO(0.00)[redhat.com,kernel.org,pengutronix.de,armlinux.org.uk,arm.com,gmail.com,oss.qualcomm.com,poorly.run,linux.dev,somainline.org,ffwll.ch,8bytes.org,rendec.net,arndb.de,linuxfoundation.org,linaro.org,intel.com,chromium.org,codeaurora.org]; DWL_DNSWL_BLOCKED(0.00)[kernel.org:dkim]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-1.000]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; DNSWL_BLOCKED(0.00)[172.234.252.31:from]; RCPT_COUNT_GT_50(0.00)[59]; RCVD_COUNT_TWO(0.00)[2]; ALIAS_RESOLVED(0.00)[]; DKIM_TRACE(0.00)[kernel.org:+] X-Rspamd-Server: lists.trustedfirmware.org X-Rspamd-Queue-Id: C47614323F X-Spamd-Bar: -- Message-ID-Hash: VY5MHM5RA2TRCGFQO2ZVQAXJ5OGGD3DL X-Message-ID-Hash: VY5MHM5RA2TRCGFQO2ZVQAXJ5OGGD3DL X-MailFrom: bod@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-op-tee.lists.trustedfirmware.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-gpio@vger.kernel.org, linux-remoteproc@vger.kernel.org, op-tee@lists.trustedfirmware.org, Maxime Ripard X-Mailman-Version: 3.3.5 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Bryan O'Donoghue via OP-TEE Reply-To: Bryan O'Donoghue On 14/09/2026 13:41, Albert Esteve wrote: > int qcom_scm_pas_auth_and_reset(u32 pas_id) > { > - return __qcom_scm_pas_auth_and_reset(__scm->dev, pas_id); > + struct qcom_scm *scm = __scm; > + > + return __qcom_scm_pas_auth_and_reset(scm->dev, pas_id); > } > EXPORT_SYMBOL_GPL(qcom_scm_pas_auth_and_reset); Why make this change at all though ? It takes a pointer to the file static _scm The reset of the patch looks straight-forward to me but this change caught my eye. --- bod