From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:c68a:b0:84d:2074:29bb with SMTP id ue10csp644905ejc; Thu, 19 Jan 2023 13:57:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXtGWz1Dn3qdRX/hz51PP6h1fH41Z64ZtDkayWLoTlY6caBrqQyCtSA23S8yzVh4odDo5iPJ X-Received: by 2002:a05:622a:5917:b0:3b6:2c11:ec76 with SMTP id ga23-20020a05622a591700b003b62c11ec76mr18529182qtb.52.1674165461058; Thu, 19 Jan 2023 13:57:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674165461; cv=none; d=google.com; s=arc-20160816; b=A1YeR1mTfK74ASYjV1JuAP4EbP+q9WEgKFW5ae6auXqegtUVTRNL5T8Ob0/d19VGS5 j9LKuCxFS1y4xUwtfW1lELDpIyzmudYW6wuoyEyberPDzG4jjYbbdMQbQr7o2BUVrnEI HOlBlFitQIt3wm16zfLf2f2HRDRfIuhag6/wFNFPG8wibCI7J00QfH/KGyfFALDgKDsT YRJ5ENkIih3wvSisxzOyNQFLhf43UAaonLNdTnqIkXOVGmNtPH/DZ2r0QANuk8lsun0W /uTGpaZWtJq+pI11krEQ/tj5v/WcDhVRstqHbNmxOZdtdZoXGsMsxjYUuIP/lO9iPWAf PByw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature:dkim-filter; bh=ox9Mgqpo2btbYUKl6NZR0OsVv+FdVRx11CPR/p7v8Uk=; b=Oco8KHXxiXStLnDRFWDt+RCOCiupK3q+a9JgSzTEz8ZqtBn8Mg2EzL0pNm4xhTFlJc p0fBshKJjfL1iIoaaxaulITecQCIKBZaNp+kjBjQXVDD6wJMhIi6qt334T8w796pb/S/ DgxJn5MgdilZ05gxMTEoEkAJm7vWYIZqn+5AIkv88uhRhhUf/mgkI0zZqfClQFoeVUTT uyBI050QDsDXE1XKVKuYuewl2hz1q1o+1wVLCV8iHc0VwkAupUGCBc+OtFwyigpgoduj iCWaDL4hUJv+GDdBYph+V3LNzq5daPFOlS/DYiB/5O14Ngth5Zku9NuhID6zANlXG42N wNAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=ahLzHjM0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id az12-20020a05620a170c00b006eec07f92c2si4882471qkb.696.2023.01.19.13.57.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Jan 2023 13:57:41 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=ahLzHjM0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIcuZ-0007mo-UN; Thu, 19 Jan 2023 16:57:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIcuY-0007mX-Jr; Thu, 19 Jan 2023 16:57:30 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIcuX-0005Wd-4G; Thu, 19 Jan 2023 16:57:30 -0500 Received: from [192.168.0.20] (unknown [77.64.253.186]) by linux.microsoft.com (Postfix) with ESMTPSA id C170920E09FC; Thu, 19 Jan 2023 13:57:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C170920E09FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674165446; bh=ox9Mgqpo2btbYUKl6NZR0OsVv+FdVRx11CPR/p7v8Uk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ahLzHjM0v7SllW+H/FcqUaJcEONdKKMQW4D03tFFBByVkeSHZ40xNELrUdhPhp967 8HWEBGsEnPFHqkqRTPYEgkJ04PmRLux6P2j0XloJrdB55Auawz4nx3Rj6zmcVmUX8q qqYkMec0CQ52vyW+BHc2sRv8dac7CcjPTx6oQo6k= Message-ID: Date: Thu, 19 Jan 2023 22:57:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 2/4] hw/char/pl011: implement a reset method Content-Language: en-US To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20230117220523.20911-1-eiakovlev@linux.microsoft.com> <20230117220523.20911-3-eiakovlev@linux.microsoft.com> From: Evgeny Iakovlev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -198 X-Spam_score: -19.9 X-Spam_bar: ------------------- X-Spam_report: (-19.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: /24mMrOGQ13M On 1/19/2023 14:27, Peter Maydell wrote: > On Tue, 17 Jan 2023 at 22:05, Evgeny Iakovlev > wrote: >> PL011 currently lacks a reset method. Implement it. >> >> Signed-off-by: Evgeny Iakovlev >> --- >> hw/char/pl011.c | 31 ++++++++++++++++++++++++++----- >> 1 file changed, 26 insertions(+), 5 deletions(-) >> >> diff --git a/hw/char/pl011.c b/hw/char/pl011.c >> index 329cc6926d..404d52a3b8 100644 >> --- a/hw/char/pl011.c >> +++ b/hw/char/pl011.c >> @@ -397,11 +397,6 @@ static void pl011_init(Object *obj) >> s->clk = qdev_init_clock_in(DEVICE(obj), "clk", pl011_clock_update, s, >> ClockUpdate); >> >> - s->read_trigger = 1; >> - s->ifl = 0x12; >> - s->cr = 0x300; >> - s->flags = 0x90; >> - >> s->id = pl011_id_arm; >> } >> >> @@ -413,11 +408,37 @@ static void pl011_realize(DeviceState *dev, Error **errp) >> pl011_event, NULL, s, NULL, true); >> } >> >> +static void pl011_reset(DeviceState *dev) >> +{ >> + PL011State *s = PL011(dev); >> + int i; >> + >> + s->lcr = 0; >> + s->rsr = 0; >> + s->dmacr = 0; >> + s->int_enabled = 0; >> + s->int_level = 0; >> + s->ilpr = 0; >> + s->ibrd = 0; >> + s->fbrd = 0; >> + s->read_pos = 0; >> + s->read_count = 0; >> + s->read_trigger = 1; >> + s->ifl = 0x12; >> + s->cr = 0x300; >> + s->flags = 0x90; >> + >> + for (i = 0; i < ARRAY_SIZE(s->irq); i++) { >> + qemu_irq_lower(s->irq[i]); >> + } > Reset should never touch outbound qemu_irq lines. > (The other end of the line will also reset and will end > up in the correct "as if the input is 0" state.) Really? I saw this reset happening on other devices in hw/char (don't remember which ones specifically), so i though it is needed. > > Otherwise > Reviewed-by: Peter Maydell > > thanks > -- PMM