Re: [dpdk-dev] [PATCH v1] net/ice: enable to set HW debug mask

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Tuesday, June 29, 2021 9:34 PM
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; Wang, Haiyue <haiyue.wang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v1] net/ice: enable to set HW debug mask
> 
> The HW debug mask is always zero, so user can't enable the related debug
> function like ICE_DBG_XXX etc.
> 
> Add the devarg 'hw_debug_mask' to set the function like for ICE_DBG_NVM:
>   -a 0000:88:00.0,hw_debug_mask=0x80 --log-level=pmd.net.ice.driver:8

This looks good, please also update the document (ice.rst).

> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> 09e38590e5..5a18663430 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -26,11 +26,13 @@
>  #define ICE_SAFE_MODE_SUPPORT_ARG "safe-mode-support"
>  #define ICE_PIPELINE_MODE_SUPPORT_ARG  "pipeline-mode-support"
>  #define ICE_PROTO_XTR_ARG         "proto_xtr"
> +#define ICE_HW_DEBUG_MASK_ARG     "hw_debug_mask"
> 
>  static const char * const ice_valid_args[] = {
>  	ICE_SAFE_MODE_SUPPORT_ARG,
>  	ICE_PIPELINE_MODE_SUPPORT_ARG,
>  	ICE_PROTO_XTR_ARG,
> +	ICE_HW_DEBUG_MASK_ARG,
>  	NULL
>  };
> 
> @@ -1836,6 +1838,25 @@ parse_bool(const char *key, const char *value,
> void *args)
>  	return 0;
>  }
> 
> +static int
> +parse_u64(const char *key, const char *value, void *args) {
> +	u64 *num = (u64 *)args;
> +	u64 tmp;
> +
> +	errno = 0;
> +	tmp = strtoull(value, NULL, 16);
> +	if (errno) {
> +		PMD_DRV_LOG(WARNING, "%s: \"%s\" is not a valid u64",
> +			    key, value);
> +		return -1;
> +	}
> +
> +	*num = tmp;
> +
> +	return 0;
> +}
> +
>  static int ice_parse_devargs(struct rte_eth_dev *dev)  {
>  	struct ice_adapter *ad =
> @@ -1872,6 +1893,11 @@ static int ice_parse_devargs(struct rte_eth_dev
> *dev)
>  	if (ret)
>  		goto bail;
> 
> +	ret = rte_kvargs_process(kvlist, ICE_HW_DEBUG_MASK_ARG,
> +				 &parse_u64, &ad->hw.debug_mask);
> +	if (ret)
> +		goto bail;
> +
>  bail:
>  	rte_kvargs_free(kvlist);
>  	return ret;
> @@ -5306,6 +5332,7 @@ RTE_PMD_REGISTER_PCI(net_ice, rte_ice_pmd);
> RTE_PMD_REGISTER_PCI_TABLE(net_ice, pci_id_ice_map);
> RTE_PMD_REGISTER_KMOD_DEP(net_ice, "* igb_uio | uio_pci_generic |
> vfio-pci");  RTE_PMD_REGISTER_PARAM_STRING(net_ice,
> +			      ICE_HW_DEBUG_MASK_ARG "=0xXXX"
>  			      ICE_PROTO_XTR_ARG
> "=[queue:]<vlan|ipv4|ipv6|ipv6_flow|tcp|ip_offset>"
>  			      ICE_SAFE_MODE_SUPPORT_ARG "=<0|1>"
>  			      ICE_PIPELINE_MODE_SUPPORT_ARG "=<0|1>");
> --
> 2.32.0