From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Roberts Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() Date: Tue, 27 Jun 2023 09:09:31 +0100 Message-ID: References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-ID: Content-Type: text/plain; charset="windows-1252" To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists On 27/06/2023 08:08, Yu Zhao wrote: > On Mon, Jun 26, 2023 at 11:14=E2=80=AFAM Ryan Roberts wrote: >> >> Like folio_add_new_anon_rmap() but batch-rmaps a range of pages >> belonging to a folio, for effciency savings. All pages are accounted as >> small pages. >> >> Signed-off-by: Ryan Roberts >> --- >> include/linux/rmap.h | 2 ++ >> mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 45 insertions(+) >> >> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >> index a3825ce81102..15433a3d0cbf 100644 >> --- a/include/linux/rmap.h >> +++ b/include/linux/rmap.h >> @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct vm= _area_struct *, >> unsigned long address); >> void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, >> unsigned long address); >> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *pa= ge, >> + int nr, struct vm_area_struct *vma, unsigned long addres= s); >=20 > We should update folio_add_new_anon_rmap() to support large() && > !folio_test_pmd_mappable() folios instead. >=20 > I double checked all places currently using folio_add_new_anon_rmap(), > and as expected, none actually allocates large() && > !folio_test_pmd_mappable() and maps it one by one, which makes the > cases simpler, i.e., > if (!large()) > // the existing basepage case > else if (!folio_test_pmd_mappable()) > // our new case > else > // the existing THP case I don't have a strong opinion either way. Happy to go with this suggestion.= But the reason I did it as a new function was because I was following the patte= rn in [1] which adds a new folio_add_file_rmap_range() function. [1] https://lore.kernel.org/linux-mm/20230315051444.3229621-35-willy@infrad= ead.org/ >=20 >> void page_add_file_rmap(struct page *, struct vm_area_struct *, >> bool compound); >> void folio_add_file_rmap_range(struct folio *, struct page *, unsigned = int nr, >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 1d8369549424..4050bcea7ae7 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *folio,= struct vm_area_struct *vma, >> __page_set_anon_rmap(folio, &folio->page, vma, address, 1); >> } >> >> +/** >> + * folio_add_new_anon_rmap_range - Add mapping to a set of pages within= a new >> + * anonymous potentially large folio. >> + * @folio: The folio containing the pages to be mapped >> + * @page: First page in the folio to be mapped >> + * @nr: Number of pages to be mapped >> + * @vma: the vm area in which the mapping is added >> + * @address: the user virtual address of the first page to be mapped >> + * >> + * Like folio_add_new_anon_rmap() but batch-maps a range of pages withi= n a folio >> + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-an= d-test is >> + * bypassed and the folio does not have to be locked. All pages in the = folio are >> + * individually accounted. >> + * >> + * As the folio is new, it's assumed to be mapped exclusively by a sing= le >> + * process. >> + */ >> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *pa= ge, >> + int nr, struct vm_area_struct *vma, unsigned long addres= s) >> +{ >> + int i; >> + >> + VM_BUG_ON_VMA(address < vma->vm_start || >> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); >=20 > BTW, VM_BUG_ON* shouldn't be used in new code: > Documentation/process/coding-style.rst Thanks, sorry about that. Was copy-pasting from folio_add_new_anon_rmap(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C13DEB64DD for ; Tue, 27 Jun 2023 08:09:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbjF0IJj (ORCPT ); Tue, 27 Jun 2023 04:09:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjF0IJi (ORCPT ); Tue, 27 Jun 2023 04:09:38 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id ACF931FC7; Tue, 27 Jun 2023 01:09:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7400B2F4; Tue, 27 Jun 2023 01:10:21 -0700 (PDT) Received: from [10.57.76.16] (unknown [10.57.76.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 780303F663; Tue, 27 Jun 2023 01:09:33 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 09:09:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ia64@vger.kernel.org On 27/06/2023 08:08, Yu Zhao wrote: > On Mon, Jun 26, 2023 at 11:14 AM Ryan Roberts wrote: >> >> Like folio_add_new_anon_rmap() but batch-rmaps a range of pages >> belonging to a folio, for effciency savings. All pages are accounted as >> small pages. >> >> Signed-off-by: Ryan Roberts >> --- >> include/linux/rmap.h | 2 ++ >> mm/rmap.c | 43 +++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 45 insertions(+) >> >> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >> index a3825ce81102..15433a3d0cbf 100644 >> --- a/include/linux/rmap.h >> +++ b/include/linux/rmap.h >> @@ -196,6 +196,8 @@ void page_add_new_anon_rmap(struct page *, struct vm_area_struct *, >> unsigned long address); >> void folio_add_new_anon_rmap(struct folio *, struct vm_area_struct *, >> unsigned long address); >> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >> + int nr, struct vm_area_struct *vma, unsigned long address); > > We should update folio_add_new_anon_rmap() to support large() && > !folio_test_pmd_mappable() folios instead. > > I double checked all places currently using folio_add_new_anon_rmap(), > and as expected, none actually allocates large() && > !folio_test_pmd_mappable() and maps it one by one, which makes the > cases simpler, i.e., > if (!large()) > // the existing basepage case > else if (!folio_test_pmd_mappable()) > // our new case > else > // the existing THP case I don't have a strong opinion either way. Happy to go with this suggestion. But the reason I did it as a new function was because I was following the pattern in [1] which adds a new folio_add_file_rmap_range() function. [1] https://lore.kernel.org/linux-mm/20230315051444.3229621-35-willy@infradead.org/ > >> void page_add_file_rmap(struct page *, struct vm_area_struct *, >> bool compound); >> void folio_add_file_rmap_range(struct folio *, struct page *, unsigned int nr, >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 1d8369549424..4050bcea7ae7 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1305,6 +1305,49 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, >> __page_set_anon_rmap(folio, &folio->page, vma, address, 1); >> } >> >> +/** >> + * folio_add_new_anon_rmap_range - Add mapping to a set of pages within a new >> + * anonymous potentially large folio. >> + * @folio: The folio containing the pages to be mapped >> + * @page: First page in the folio to be mapped >> + * @nr: Number of pages to be mapped >> + * @vma: the vm area in which the mapping is added >> + * @address: the user virtual address of the first page to be mapped >> + * >> + * Like folio_add_new_anon_rmap() but batch-maps a range of pages within a folio >> + * using non-THP accounting. Like folio_add_new_anon_rmap(), the inc-and-test is >> + * bypassed and the folio does not have to be locked. All pages in the folio are >> + * individually accounted. >> + * >> + * As the folio is new, it's assumed to be mapped exclusively by a single >> + * process. >> + */ >> +void folio_add_new_anon_rmap_range(struct folio *folio, struct page *page, >> + int nr, struct vm_area_struct *vma, unsigned long address) >> +{ >> + int i; >> + >> + VM_BUG_ON_VMA(address < vma->vm_start || >> + address + (nr << PAGE_SHIFT) > vma->vm_end, vma); > > BTW, VM_BUG_ON* shouldn't be used in new code: > Documentation/process/coding-style.rst Thanks, sorry about that. Was copy-pasting from folio_add_new_anon_rmap(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65377EB64DC for ; Tue, 27 Jun 2023 08:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I6pLjdliHY/yMHPK1bMTulhLM/8MdDOmq9023Tb58WE=; b=ai94un0ozOx1yU mdV7ctPR25h8ruUbB34VJpttG7Fk4YPhtwXerociJFmIfCdnsPgd5BraG60pqEdXAsC27n+MrZ+6a 7oE2BcJvRROQNiSmMCXfxiIxHIrd9c5Q3S6I95oUAvPH9P4NuIGua5wDMziTsxfo154rUOBXWxHR+ vyz5w13Rr4j/E6YDniVfn/uO/lXWdffFFStimEZJwOlj2XlQXqb6sIC6XDyVDuekj+fOy6AC8Qphv OlRz6h/RDNcjwihc+tp2orthCW37MlQNaLvZGCgf+0oZ7XUMcftJffO6r5mZPsDezmZf6oyRhgXAt y/9xIn2EZWM7f/9ZI7ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE3lf-00CW7I-1i; Tue, 27 Jun 2023 08:09:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qE3lc-00CW6C-0v for linux-arm-kernel@lists.infradead.org; Tue, 27 Jun 2023 08:09:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7400B2F4; Tue, 27 Jun 2023 01:10:21 -0700 (PDT) Received: from [10.57.76.16] (unknown [10.57.76.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 780303F663; Tue, 27 Jun 2023 01:09:33 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 09:09:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 04/10] mm: Implement folio_add_new_anon_rmap_range() To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-5-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230627_010940_414292_91BAB7D6 X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjcvMDYvMjAyMyAwODowOCwgWXUgWmhhbyB3cm90ZToKPiBPbiBNb24sIEp1biAyNiwgMjAy MyBhdCAxMToxNOKAr0FNIFJ5YW4gUm9iZXJ0cyA8cnlhbi5yb2JlcnRzQGFybS5jb20+IHdyb3Rl Ogo+Pgo+PiBMaWtlIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCkgYnV0IGJhdGNoLXJtYXBzIGEg cmFuZ2Ugb2YgcGFnZXMKPj4gYmVsb25naW5nIHRvIGEgZm9saW8sIGZvciBlZmZjaWVuY3kgc2F2 aW5ncy4gQWxsIHBhZ2VzIGFyZSBhY2NvdW50ZWQgYXMKPj4gc21hbGwgcGFnZXMuCj4+Cj4+IFNp Z25lZC1vZmYtYnk6IFJ5YW4gUm9iZXJ0cyA8cnlhbi5yb2JlcnRzQGFybS5jb20+Cj4+IC0tLQo+ PiAgaW5jbHVkZS9saW51eC9ybWFwLmggfCAgMiArKwo+PiAgbW0vcm1hcC5jICAgICAgICAgICAg fCA0MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ICAyIGZp bGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv bGludXgvcm1hcC5oIGIvaW5jbHVkZS9saW51eC9ybWFwLmgKPj4gaW5kZXggYTM4MjVjZTgxMTAy Li4xNTQzM2EzZDBjYmYgMTAwNjQ0Cj4+IC0tLSBhL2luY2x1ZGUvbGludXgvcm1hcC5oCj4+ICsr KyBiL2luY2x1ZGUvbGludXgvcm1hcC5oCj4+IEBAIC0xOTYsNiArMTk2LDggQEAgdm9pZCBwYWdl X2FkZF9uZXdfYW5vbl9ybWFwKHN0cnVjdCBwYWdlICosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAq LAo+PiAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKTsKPj4gIHZvaWQgZm9s aW9fYWRkX25ld19hbm9uX3JtYXAoc3RydWN0IGZvbGlvICosIHN0cnVjdCB2bV9hcmVhX3N0cnVj dCAqLAo+PiAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBhZGRyZXNzKTsKPj4gK3ZvaWQg Zm9saW9fYWRkX25ld19hbm9uX3JtYXBfcmFuZ2Uoc3RydWN0IGZvbGlvICpmb2xpbywgc3RydWN0 IHBhZ2UgKnBhZ2UsCj4+ICsgICAgICAgICAgICAgICBpbnQgbnIsIHN0cnVjdCB2bV9hcmVhX3N0 cnVjdCAqdm1hLCB1bnNpZ25lZCBsb25nIGFkZHJlc3MpOwo+IAo+IFdlIHNob3VsZCB1cGRhdGUg Zm9saW9fYWRkX25ld19hbm9uX3JtYXAoKSB0byBzdXBwb3J0IGxhcmdlKCkgJiYKPiAhZm9saW9f dGVzdF9wbWRfbWFwcGFibGUoKSBmb2xpb3MgaW5zdGVhZC4KPiAKPiBJIGRvdWJsZSBjaGVja2Vk IGFsbCBwbGFjZXMgY3VycmVudGx5IHVzaW5nIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCksCj4g YW5kIGFzIGV4cGVjdGVkLCBub25lIGFjdHVhbGx5IGFsbG9jYXRlcyBsYXJnZSgpICYmCj4gIWZv bGlvX3Rlc3RfcG1kX21hcHBhYmxlKCkgYW5kIG1hcHMgaXQgb25lIGJ5IG9uZSwgd2hpY2ggbWFr ZXMgdGhlCj4gY2FzZXMgc2ltcGxlciwgaS5lLiwKPiAgIGlmICghbGFyZ2UoKSkKPiAgICAgLy8g dGhlIGV4aXN0aW5nIGJhc2VwYWdlIGNhc2UKPiAgIGVsc2UgaWYgKCFmb2xpb190ZXN0X3BtZF9t YXBwYWJsZSgpKQo+ICAgICAvLyBvdXIgbmV3IGNhc2UKPiAgIGVsc2UKPiAgICAgLy8gdGhlIGV4 aXN0aW5nIFRIUCBjYXNlCgpJIGRvbid0IGhhdmUgYSBzdHJvbmcgb3BpbmlvbiBlaXRoZXIgd2F5 LiBIYXBweSB0byBnbyB3aXRoIHRoaXMgc3VnZ2VzdGlvbi4gQnV0CnRoZSByZWFzb24gSSBkaWQg aXQgYXMgYSBuZXcgZnVuY3Rpb24gd2FzIGJlY2F1c2UgSSB3YXMgZm9sbG93aW5nIHRoZSBwYXR0 ZXJuIGluClsxXSB3aGljaCBhZGRzIGEgbmV3IGZvbGlvX2FkZF9maWxlX3JtYXBfcmFuZ2UoKSBm dW5jdGlvbi4KClsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1tbS8yMDIzMDMxNTA1 MTQ0NC4zMjI5NjIxLTM1LXdpbGx5QGluZnJhZGVhZC5vcmcvCgoKPiAKPj4gIHZvaWQgcGFnZV9h ZGRfZmlsZV9ybWFwKHN0cnVjdCBwYWdlICosIHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqLAo+PiAg ICAgICAgICAgICAgICAgYm9vbCBjb21wb3VuZCk7Cj4+ICB2b2lkIGZvbGlvX2FkZF9maWxlX3Jt YXBfcmFuZ2Uoc3RydWN0IGZvbGlvICosIHN0cnVjdCBwYWdlICosIHVuc2lnbmVkIGludCBuciwK Pj4gZGlmZiAtLWdpdCBhL21tL3JtYXAuYyBiL21tL3JtYXAuYwo+PiBpbmRleCAxZDgzNjk1NDk0 MjQuLjQwNTBiY2VhN2FlNyAxMDA2NDQKPj4gLS0tIGEvbW0vcm1hcC5jCj4+ICsrKyBiL21tL3Jt YXAuYwo+PiBAQCAtMTMwNSw2ICsxMzA1LDQ5IEBAIHZvaWQgZm9saW9fYWRkX25ld19hbm9uX3Jt YXAoc3RydWN0IGZvbGlvICpmb2xpbywgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsCj4+ICAg ICAgICAgX19wYWdlX3NldF9hbm9uX3JtYXAoZm9saW8sICZmb2xpby0+cGFnZSwgdm1hLCBhZGRy ZXNzLCAxKTsKPj4gIH0KPj4KPj4gKy8qKgo+PiArICogZm9saW9fYWRkX25ld19hbm9uX3JtYXBf cmFuZ2UgLSBBZGQgbWFwcGluZyB0byBhIHNldCBvZiBwYWdlcyB3aXRoaW4gYSBuZXcKPj4gKyAq IGFub255bW91cyBwb3RlbnRpYWxseSBsYXJnZSBmb2xpby4KPj4gKyAqIEBmb2xpbzogICAgICBU aGUgZm9saW8gY29udGFpbmluZyB0aGUgcGFnZXMgdG8gYmUgbWFwcGVkCj4+ICsgKiBAcGFnZTog ICAgICAgRmlyc3QgcGFnZSBpbiB0aGUgZm9saW8gdG8gYmUgbWFwcGVkCj4+ICsgKiBAbnI6ICAg ICAgICAgTnVtYmVyIG9mIHBhZ2VzIHRvIGJlIG1hcHBlZAo+PiArICogQHZtYTogICAgICAgIHRo ZSB2bSBhcmVhIGluIHdoaWNoIHRoZSBtYXBwaW5nIGlzIGFkZGVkCj4+ICsgKiBAYWRkcmVzczog ICAgdGhlIHVzZXIgdmlydHVhbCBhZGRyZXNzIG9mIHRoZSBmaXJzdCBwYWdlIHRvIGJlIG1hcHBl ZAo+PiArICoKPj4gKyAqIExpa2UgZm9saW9fYWRkX25ld19hbm9uX3JtYXAoKSBidXQgYmF0Y2gt bWFwcyBhIHJhbmdlIG9mIHBhZ2VzIHdpdGhpbiBhIGZvbGlvCj4+ICsgKiB1c2luZyBub24tVEhQ IGFjY291bnRpbmcuIExpa2UgZm9saW9fYWRkX25ld19hbm9uX3JtYXAoKSwgdGhlIGluYy1hbmQt dGVzdCBpcwo+PiArICogYnlwYXNzZWQgYW5kIHRoZSBmb2xpbyBkb2VzIG5vdCBoYXZlIHRvIGJl IGxvY2tlZC4gQWxsIHBhZ2VzIGluIHRoZSBmb2xpbyBhcmUKPj4gKyAqIGluZGl2aWR1YWxseSBh Y2NvdW50ZWQuCj4+ICsgKgo+PiArICogQXMgdGhlIGZvbGlvIGlzIG5ldywgaXQncyBhc3N1bWVk IHRvIGJlIG1hcHBlZCBleGNsdXNpdmVseSBieSBhIHNpbmdsZQo+PiArICogcHJvY2Vzcy4KPj4g KyAqLwo+PiArdm9pZCBmb2xpb19hZGRfbmV3X2Fub25fcm1hcF9yYW5nZShzdHJ1Y3QgZm9saW8g KmZvbGlvLCBzdHJ1Y3QgcGFnZSAqcGFnZSwKPj4gKyAgICAgICAgICAgICAgIGludCBuciwgc3Ry dWN0IHZtX2FyZWFfc3RydWN0ICp2bWEsIHVuc2lnbmVkIGxvbmcgYWRkcmVzcykKPj4gK3sKPj4g KyAgICAgICBpbnQgaTsKPj4gKwo+PiArICAgICAgIFZNX0JVR19PTl9WTUEoYWRkcmVzcyA8IHZt YS0+dm1fc3RhcnQgfHwKPj4gKyAgICAgICAgICAgICAgICAgICAgIGFkZHJlc3MgKyAobnIgPDwg UEFHRV9TSElGVCkgPiB2bWEtPnZtX2VuZCwgdm1hKTsKPiAKPiBCVFcsIFZNX0JVR19PTiogc2hv dWxkbid0IGJlIHVzZWQgaW4gbmV3IGNvZGU6Cj4gRG9jdW1lbnRhdGlvbi9wcm9jZXNzL2NvZGlu Zy1zdHlsZS5yc3QKClRoYW5rcywgc29ycnkgYWJvdXQgdGhhdC4gV2FzIGNvcHktcGFzdGluZyBm cm9tIGZvbGlvX2FkZF9uZXdfYW5vbl9ybWFwKCkuCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=