Re: [PATCH v5 3/4] xen/arm: switch ARM to use generic implementation of bug.h

[Oleksii <oleksii.kurochko@gmail.com>]

On Fri, 2023-03-03 at 12:29 +0100, Jan Beulich wrote:
> On 03.03.2023 11:38, Oleksii Kurochko wrote:
> > The following changes were made:
> > * make GENERIC_BUG_FRAME mandatory for ARM
> > * As do_bug_frame() returns -EINVAL in case something goes wrong
> >   otherwise id of bug frame. Thereby 'if' cases where
> > do_bug_frame() was
> >   updated to check if the returned value is less than 0
> > * Switch ARM's implementation of bug.h macros to generic one
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > Changes in V5:
> >  * Nothing changed
> 
> I'm glad this isn't true, and the change to common/bug.c ...
> 
> > ---
> >  xen/arch/arm/Kconfig                 |  1 +
> >  xen/arch/arm/arm32/traps.c           |  2 +-
> >  xen/arch/arm/include/asm/arm32/bug.h |  2 -
> >  xen/arch/arm/include/asm/arm64/bug.h |  2 -
> >  xen/arch/arm/include/asm/bug.h       | 75 +-----------------------
> > --
> >  xen/arch/arm/include/asm/traps.h     |  2 -
> >  xen/arch/arm/traps.c                 | 81 +-----------------------
> > ----
> >  7 files changed, 4 insertions(+), 161 deletions(-)
> 
> ... is gone.
Thanks for clarification.

I had to add this information.

It is gone because the first patch of the patch series was
updated and the changes from common/bug.c which were in
the previous version of the patch has been removed so after
rebase they disappered in the current patch.

~ Oleksii