From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F98C56202 for ; Thu, 26 Nov 2020 15:57:37 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 16105221E2 for ; Thu, 26 Nov 2020 15:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0FVOyftv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16105221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9789D4BB46; Thu, 26 Nov 2020 10:57:36 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJAjeYuALYsS; Thu, 26 Nov 2020 10:57:35 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6D6784BB10; Thu, 26 Nov 2020 10:57:35 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A9EA94BAF3 for ; Thu, 26 Nov 2020 10:57:34 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YeWpYv4AXaIU for ; Thu, 26 Nov 2020 10:57:33 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A681E4BA4E for ; Thu, 26 Nov 2020 10:57:33 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 673C921D40; Thu, 26 Nov 2020 15:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606406252; bh=Cd+lqHcWQa2Lfyc0AEv5uFc3rl+QCTnok0WlZltox6w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0FVOyftviVxfR6AqRCei/O8Hs41Kog3LoDPsdsCmDt6oU1ivHYCbmBUSsz4E6M9Wc NDpXx/YU/JpFSW6cOj+uixK+ZRAA3N2FsZGjgKGemNwXbuSv8mDU+puEQPdJmdQLSd 30EGNrv0NA0x0nUxwCJUSC//Rha7BpNybub7M+E0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kiJeE-00DqgV-CU; Thu, 26 Nov 2020 15:57:30 +0000 MIME-Version: 1.0 Date: Thu, 26 Nov 2020 15:57:30 +0000 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH 6/8] KVM: arm64: Remove dead PMU sysreg decoding code In-Reply-To: References: <20201113182602.471776-1-maz@kernel.org> <20201113182602.471776-7-maz@kernel.org> <1ed6dfd6-4ace-a562-bc2f-054a5c853fa6@arm.com> <3ae09ecc95b732129f71076b4b59c873@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0xMS0yNiAxNTo1NCwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSBNYXJjLAo+ IAo+IE9uIDExLzI2LzIwIDM6MzQgUE0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gSGkgQWxleCwK Pj4gCj4+IE9uIDIwMjAtMTEtMjYgMTU6MTgsIEFsZXhhbmRydSBFbGlzZWkgd3JvdGU6Cj4+PiBI aSBNYXJjLAo+Pj4gCj4+PiBJIGNoZWNrZWQgYW5kIGluZGVlZCB0aGUgcmVtYWluaW5nIGNhc2Vz IGNvdmVyIGFsbCByZWdpc3RlcnMgdGhhdCB1c2UKPj4+IHRoaXMgYWNjZXNzb3IuCj4+PiAKPj4+ IEhvd2V2ZXIsIEknbSBhIGJpdCB0b3JuIGhlcmUuIFRoZSB3YXJuaW5nIHRoYXQgSSBnb3Qgd2hl biB0cnlpbmcgdG8gCj4+PiBydW4gYSBndWVzdAo+Pj4gd2l0aCB0aGUgUE1VIGZlYXR1cmUgZmxh ZyBzZXQsIGJ1dCBub3QgaW5pdGlhbGl6ZWQgKHJlcG9ydGVkIGF0IFsxXSkKPj4+IHdhcyBhbHNv IG5vdAo+Pj4gc3VwcG9zZWQgdG8gZXZlciBiZSByZWFjaGVkOgo+Pj4gCj4+PiBzdGF0aWMgdTMy IGt2bV9wbXVfZXZlbnRfbWFzayhzdHJ1Y3Qga3ZtICprdm0pCj4+PiB7Cj4+PiDCoMKgwqAgc3dp dGNoIChrdm0tPmFyY2gucG11dmVyKSB7Cj4+PiDCoMKgwqAgY2FzZSAxOsKgwqDCoCDCoMKgwqAg wqDCoMKgIC8qIEFSTXY4LjAgKi8KPj4+IMKgwqDCoCDCoMKgwqAgcmV0dXJuIEdFTk1BU0soOSwg MCk7Cj4+PiDCoMKgwqAgY2FzZSA0OsKgwqDCoCDCoMKgwqAgwqDCoMKgIC8qIEFSTXY4LjEgKi8K Pj4+IMKgwqDCoCBjYXNlIDU6wqDCoMKgIMKgwqDCoCDCoMKgwqAgLyogQVJNdjguNCAqLwo+Pj4g wqDCoMKgIGNhc2UgNjrCoMKgwqAgwqDCoMKgIMKgwqDCoCAvKiBBUk12OC41ICovCj4+PiDCoMKg wqAgwqDCoMKgIHJldHVybiBHRU5NQVNLKDE1LCAwKTsKPj4+IMKgwqDCoCBkZWZhdWx0OsKgwqDC oCDCoMKgwqAgLyogU2hvdWxkbid0IGJlIGhlcmUsIGp1c3QgZm9yIHNhbml0eSAqLwo+Pj4gwqDC oMKgIMKgwqDCoCBXQVJOX09OQ0UoMSwgIlVua25vd24gUE1VIHZlcnNpb24gJWRcbiIsIGt2bS0+ YXJjaC5wbXV2ZXIpOwo+Pj4gwqDCoMKgIMKgwqDCoCByZXR1cm4gMDsKPj4+IMKgwqDCoCB9Cj4+ PiB9Cj4+PiAKPj4+IEkgcmVhbGl6ZSBpdCdzIG5vdCBleGFjdGx5IHRoZSBzYW1lIHRoaW5nIGFu ZCBJJ2xsIGxlYXZlIGl0IHVwIHRvIHlvdQo+Pj4gaWYgeW91IHdhbnQKPj4+IHRvIGFkZCBhIHdh cm5pbmcgZm9yIHRoZSBjYXNlcyB0aGF0IHNob3VsZCBuZXZlciBoYXBwZW4uIEknbSBmaW5lIAo+ Pj4gZWl0aGVyIHdheToKPj4gCj4+IEkgYWxyZWFkeSBoYXZlIHF1ZXVlZCBzdWNoIGEgd2Fybmlu Z1sxXS4gSXQgdHVybnMgb3V0IHRoYXQgTExWTSB3YXJucwo+PiBpZHggY2FuIGJlIGxlZnQgdW5p bml0aWFsaXplZCwgYW5kIHNob3V0cy4gTGV0IG1lIGtub3cgaWYgdGhhdCB3b3Jrcwo+PiBmb3Ig eW91Lgo+IAo+IExvb2tzIGdvb2QgdG8gbWUsIHVuc2lnbmVkIGxvbmcgaXMgNjQgYml0cyBhbmQg aW5zdHJ1Y3Rpb25zIGFyZSAzMgo+IGJpdHMsIHNvIHdlJ2xsIG5ldmVyIHJ1biBpbnRvIGEgc2l0 dWF0aW9uIHdoZXJlIGEgdmFsaWQgZW5jb2RpbmcgaXMgCj4gfjBVTC4KPiAKPiBZb3UgY2FuIGFk ZCBteSBSZXZpZXdlZC1ieSB0byB0aGlzIHBhdGNoIChhbmQgdG8gdGhlIG9uZSBhdCBbMV0gaWYg aXQncyAKPiBzdGlsbAo+IHBvc3NpYmxlKS4KCkl0J3MgYSBmaXh1cCwgc28gaXQgd2lsbCBnZXQg Zm9sZGVkIGludG8gdGhlIG9yaWdpbmFsIHBhdGNoLgoKVGhhbmtzIGZvciBzcGVuZGluZyB0aW1l IHJldmlld2luZyAoYW5kIGZpeGluZykgdGhpcyEKCiAgICAgICBNLgotLSAKSmF6eiBpcyBub3Qg ZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3Mu Y29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGlu Zm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EEF9C56202 for ; Thu, 26 Nov 2020 16:05:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F8F21D7E for ; Thu, 26 Nov 2020 16:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IzJwfQrz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0FVOyftv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32F8F21D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+vLjNeFvb45HsI/e1jc9K9L7rxZxZIARW69k8tkF4Yc=; b=IzJwfQrz215LCryO/pgsmjmqN r6GVnq9NPfSLIqNKR26DeRB5O0uqLOZ3kdC7U46TgSe1hrLJCgz6M0dVOErScgRWHtG6GxxxVYShk qPiNRy5TpFY33uhLk/2h+sA93VHr5WzyZNozp+vsCy+e0gnoqryNeCtfQFVZmFqrNJVaW0NCZwpup pBMp9h8kaoH4BPN2HnOLXgklb8oqzOxkLL2EgBGMj/MlffFgQlv24nIZsgu9lo20LIAQqgwb1sryv qimZg60BzRNHQJExZ555n6u7+63kj2ICuQD2+65uzbcWFvAkMSdnkO3+RRYOiHPaH/gF9Q/QE/7/R p/972WSNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiJir-0002cN-Tp; Thu, 26 Nov 2020 16:02:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiJeI-0000Su-2f for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2020 15:57:35 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 673C921D40; Thu, 26 Nov 2020 15:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606406252; bh=Cd+lqHcWQa2Lfyc0AEv5uFc3rl+QCTnok0WlZltox6w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0FVOyftviVxfR6AqRCei/O8Hs41Kog3LoDPsdsCmDt6oU1ivHYCbmBUSsz4E6M9Wc NDpXx/YU/JpFSW6cOj+uixK+ZRAA3N2FsZGjgKGemNwXbuSv8mDU+puEQPdJmdQLSd 30EGNrv0NA0x0nUxwCJUSC//Rha7BpNybub7M+E0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kiJeE-00DqgV-CU; Thu, 26 Nov 2020 15:57:30 +0000 MIME-Version: 1.0 Date: Thu, 26 Nov 2020 15:57:30 +0000 From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH 6/8] KVM: arm64: Remove dead PMU sysreg decoding code In-Reply-To: References: <20201113182602.471776-1-maz@kernel.org> <20201113182602.471776-7-maz@kernel.org> <1ed6dfd6-4ace-a562-bc2f-054a5c853fa6@arm.com> <3ae09ecc95b732129f71076b4b59c873@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_105734_348551_49122248 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMS0yNiAxNTo1NCwgQWxleGFuZHJ1IEVsaXNlaSB3cm90ZToKPiBIaSBNYXJjLAo+ IAo+IE9uIDExLzI2LzIwIDM6MzQgUE0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gSGkgQWxleCwK Pj4gCj4+IE9uIDIwMjAtMTEtMjYgMTU6MTgsIEFsZXhhbmRydSBFbGlzZWkgd3JvdGU6Cj4+PiBI aSBNYXJjLAo+Pj4gCj4+PiBJIGNoZWNrZWQgYW5kIGluZGVlZCB0aGUgcmVtYWluaW5nIGNhc2Vz IGNvdmVyIGFsbCByZWdpc3RlcnMgdGhhdCB1c2UKPj4+IHRoaXMgYWNjZXNzb3IuCj4+PiAKPj4+ IEhvd2V2ZXIsIEknbSBhIGJpdCB0b3JuIGhlcmUuIFRoZSB3YXJuaW5nIHRoYXQgSSBnb3Qgd2hl biB0cnlpbmcgdG8gCj4+PiBydW4gYSBndWVzdAo+Pj4gd2l0aCB0aGUgUE1VIGZlYXR1cmUgZmxh ZyBzZXQsIGJ1dCBub3QgaW5pdGlhbGl6ZWQgKHJlcG9ydGVkIGF0IFsxXSkKPj4+IHdhcyBhbHNv IG5vdAo+Pj4gc3VwcG9zZWQgdG8gZXZlciBiZSByZWFjaGVkOgo+Pj4gCj4+PiBzdGF0aWMgdTMy IGt2bV9wbXVfZXZlbnRfbWFzayhzdHJ1Y3Qga3ZtICprdm0pCj4+PiB7Cj4+PiDCoMKgwqAgc3dp dGNoIChrdm0tPmFyY2gucG11dmVyKSB7Cj4+PiDCoMKgwqAgY2FzZSAxOsKgwqDCoCDCoMKgwqAg wqDCoMKgIC8qIEFSTXY4LjAgKi8KPj4+IMKgwqDCoCDCoMKgwqAgcmV0dXJuIEdFTk1BU0soOSwg MCk7Cj4+PiDCoMKgwqAgY2FzZSA0OsKgwqDCoCDCoMKgwqAgwqDCoMKgIC8qIEFSTXY4LjEgKi8K Pj4+IMKgwqDCoCBjYXNlIDU6wqDCoMKgIMKgwqDCoCDCoMKgwqAgLyogQVJNdjguNCAqLwo+Pj4g wqDCoMKgIGNhc2UgNjrCoMKgwqAgwqDCoMKgIMKgwqDCoCAvKiBBUk12OC41ICovCj4+PiDCoMKg wqAgwqDCoMKgIHJldHVybiBHRU5NQVNLKDE1LCAwKTsKPj4+IMKgwqDCoCBkZWZhdWx0OsKgwqDC oCDCoMKgwqAgLyogU2hvdWxkbid0IGJlIGhlcmUsIGp1c3QgZm9yIHNhbml0eSAqLwo+Pj4gwqDC oMKgIMKgwqDCoCBXQVJOX09OQ0UoMSwgIlVua25vd24gUE1VIHZlcnNpb24gJWRcbiIsIGt2bS0+ YXJjaC5wbXV2ZXIpOwo+Pj4gwqDCoMKgIMKgwqDCoCByZXR1cm4gMDsKPj4+IMKgwqDCoCB9Cj4+ PiB9Cj4+PiAKPj4+IEkgcmVhbGl6ZSBpdCdzIG5vdCBleGFjdGx5IHRoZSBzYW1lIHRoaW5nIGFu ZCBJJ2xsIGxlYXZlIGl0IHVwIHRvIHlvdQo+Pj4gaWYgeW91IHdhbnQKPj4+IHRvIGFkZCBhIHdh cm5pbmcgZm9yIHRoZSBjYXNlcyB0aGF0IHNob3VsZCBuZXZlciBoYXBwZW4uIEknbSBmaW5lIAo+ Pj4gZWl0aGVyIHdheToKPj4gCj4+IEkgYWxyZWFkeSBoYXZlIHF1ZXVlZCBzdWNoIGEgd2Fybmlu Z1sxXS4gSXQgdHVybnMgb3V0IHRoYXQgTExWTSB3YXJucwo+PiBpZHggY2FuIGJlIGxlZnQgdW5p bml0aWFsaXplZCwgYW5kIHNob3V0cy4gTGV0IG1lIGtub3cgaWYgdGhhdCB3b3Jrcwo+PiBmb3Ig eW91Lgo+IAo+IExvb2tzIGdvb2QgdG8gbWUsIHVuc2lnbmVkIGxvbmcgaXMgNjQgYml0cyBhbmQg aW5zdHJ1Y3Rpb25zIGFyZSAzMgo+IGJpdHMsIHNvIHdlJ2xsIG5ldmVyIHJ1biBpbnRvIGEgc2l0 dWF0aW9uIHdoZXJlIGEgdmFsaWQgZW5jb2RpbmcgaXMgCj4gfjBVTC4KPiAKPiBZb3UgY2FuIGFk ZCBteSBSZXZpZXdlZC1ieSB0byB0aGlzIHBhdGNoIChhbmQgdG8gdGhlIG9uZSBhdCBbMV0gaWYg aXQncyAKPiBzdGlsbAo+IHBvc3NpYmxlKS4KCkl0J3MgYSBmaXh1cCwgc28gaXQgd2lsbCBnZXQg Zm9sZGVkIGludG8gdGhlIG9yaWdpbmFsIHBhdGNoLgoKVGhhbmtzIGZvciBzcGVuZGluZyB0aW1l IHJldmlld2luZyAoYW5kIGZpeGluZykgdGhpcyEKCiAgICAgICBNLgotLSAKSmF6eiBpcyBub3Qg ZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB19DC56202 for ; Thu, 26 Nov 2020 15:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 734B521D40 for ; Thu, 26 Nov 2020 15:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0FVOyftv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391500AbgKZP5d (ORCPT ); Thu, 26 Nov 2020 10:57:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:54850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391267AbgKZP5d (ORCPT ); Thu, 26 Nov 2020 10:57:33 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 673C921D40; Thu, 26 Nov 2020 15:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606406252; bh=Cd+lqHcWQa2Lfyc0AEv5uFc3rl+QCTnok0WlZltox6w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0FVOyftviVxfR6AqRCei/O8Hs41Kog3LoDPsdsCmDt6oU1ivHYCbmBUSsz4E6M9Wc NDpXx/YU/JpFSW6cOj+uixK+ZRAA3N2FsZGjgKGemNwXbuSv8mDU+puEQPdJmdQLSd 30EGNrv0NA0x0nUxwCJUSC//Rha7BpNybub7M+E0= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kiJeE-00DqgV-CU; Thu, 26 Nov 2020 15:57:30 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 26 Nov 2020 15:57:30 +0000 From: Marc Zyngier To: Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 6/8] KVM: arm64: Remove dead PMU sysreg decoding code In-Reply-To: References: <20201113182602.471776-1-maz@kernel.org> <20201113182602.471776-7-maz@kernel.org> <1ed6dfd6-4ace-a562-bc2f-054a5c853fa6@arm.com> <3ae09ecc95b732129f71076b4b59c873@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-11-26 15:54, Alexandru Elisei wrote: > Hi Marc, > > On 11/26/20 3:34 PM, Marc Zyngier wrote: >> Hi Alex, >> >> On 2020-11-26 15:18, Alexandru Elisei wrote: >>> Hi Marc, >>> >>> I checked and indeed the remaining cases cover all registers that use >>> this accessor. >>> >>> However, I'm a bit torn here. The warning that I got when trying to >>> run a guest >>> with the PMU feature flag set, but not initialized (reported at [1]) >>> was also not >>> supposed to ever be reached: >>> >>> static u32 kvm_pmu_event_mask(struct kvm *kvm) >>> { >>>     switch (kvm->arch.pmuver) { >>>     case 1:            /* ARMv8.0 */ >>>         return GENMASK(9, 0); >>>     case 4:            /* ARMv8.1 */ >>>     case 5:            /* ARMv8.4 */ >>>     case 6:            /* ARMv8.5 */ >>>         return GENMASK(15, 0); >>>     default:        /* Shouldn't be here, just for sanity */ >>>         WARN_ONCE(1, "Unknown PMU version %d\n", kvm->arch.pmuver); >>>         return 0; >>>     } >>> } >>> >>> I realize it's not exactly the same thing and I'll leave it up to you >>> if you want >>> to add a warning for the cases that should never happen. I'm fine >>> either way: >> >> I already have queued such a warning[1]. It turns out that LLVM warns >> idx can be left uninitialized, and shouts. Let me know if that works >> for you. > > Looks good to me, unsigned long is 64 bits and instructions are 32 > bits, so we'll never run into a situation where a valid encoding is > ~0UL. > > You can add my Reviewed-by to this patch (and to the one at [1] if it's > still > possible). It's a fixup, so it will get folded into the original patch. Thanks for spending time reviewing (and fixing) this! M. -- Jazz is not dead. It just smells funny...