From: Michael Walle <mwalle@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
linux-mtd@lists.infradead.org,
Alexander Usyskin <alexander.usyskin@intel.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] Revert "mtd: core: always create master device"
Date: Mon, 16 Jun 2025 10:17:15 +0200 [thread overview]
Message-ID: <b16dbc82976e2454afb6aa53ea97bd0f@kernel.org> (raw)
In-Reply-To: <20250613180722.1268159-1-miquel.raynal@bootlin.com>
Hi,
> The idea behind this patch was to always let a "master" mtd device
> available to anchor runtime PM. Historically, there was no mtd device
> representing the whole storage as soon as partitions were coming into
> play. The introduction of CONFIG_MTD_PARTITIONED_MASTER allowed to keep
> this "master" device, but was not enabled by default to avoid breaking
> existing users (otherwise the mtd device numbering would be totally
> messed up with an off by 1, at least).
>
> The approach of adding an mtd_master class on top of partitioned mtd
> devices is breaking the mtd core in many creative ways, so better think
> again this approach and revert the faulty changes for now.
>
> This reverts commit 0aa7b390fc40a871267a2328bbbefca8b37ad307.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Should this have a Fixes tag?
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-06-16 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 18:07 [PATCH] Revert "mtd: core: always create master device" Miquel Raynal
2025-06-16 8:17 ` Michael Walle [this message]
2025-06-16 8:21 ` Richard Weinberger
2025-06-16 16:49 ` Guenter Roeck
2025-06-17 13:35 ` Miquel Raynal
2025-06-17 13:55 ` Guenter Roeck
2025-06-17 13:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16dbc82976e2454afb6aa53ea97bd0f@kernel.org \
--to=mwalle@kernel.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.